[PHP-DEV] php interactive shell: save history on SIGINT exit

2014-07-21 Thread Dmitry Saprykin
history on Ctrl+C exit. Threre is request on bugs.php.net for this feature https://bugs.php.net/bug.php?id=67496. I have created pull request https://github.com/php/php-src/pull/727 but was advised to create RFC to discuss this change. So could you provide some feedback. Kind regards, Dmitry Saprykin

Re: [PHP-DEV] php interactive shell: save history on SIGINT exit

2014-07-21 Thread Dmitry Saprykin
Ok, I will NOT )) God saves us from bureaucracy On 21 July 2014 13:46, Michael Wallner wrote: > > On 21 Jul 2014 11:24, "Yasuo Ohgaki" wrote: > > > > Hi all, > > > > On Mon, Jul 21, 2014 at 6:12 PM, Dmitry Saprykin < > saprykin.dmi...@gmail.c

Re: [PHP-DEV] php interactive shell: save history on SIGINT exit

2014-07-21 Thread Dmitry Saprykin
but I have no enough wiki karma. On 21 July 2014 14:52, Pierre Joye wrote: > On Mon, Jul 21, 2014 at 11:50 AM, Dmitry Saprykin > wrote: > > Ok, I will NOT )) > > God saves us from bureaucracy > > Well, Michael's view is known. > > However let me explain w

Re: [PHP-DEV] php interactive shell: save history on SIGINT exit

2014-07-21 Thread Dmitry Saprykin
changed "write_history" at the end to "append_history" after each cli_is_valid_code. Now it is -1 line, +1 line commit and completely looks like bug fix. ) On 21 July 2014 18:00, Johannes Schlüter wrote: > On Mon, 2014-07-21 at 13:12 +0400, Dmitry Saprykin wrote: &g

Re: [PHP-DEV] php interactive shell: save history on SIGINT exit

2014-07-23 Thread Dmitry Saprykin
Yes, you are right. append_history is not suitable for libedit. I left write_history call for libedit. On 23 July 2014 16:38, Johannes Schlüter wrote: > On Mon, 2014-07-21 at 18:17 +0400, Dmitry Saprykin wrote: > > changed "write_history" at the end to "append