Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Eric Norris
Thanks Rowan! > I think calling it a "vision for a high-level API" is making it sound > far more grandiose than what I suggested. What I suggested, and would > still like to see, is a small number of additional methods, for setting > really common options in a more user-friendly way. I apologize

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Rowan Tommins [IMSoP]
On 26/06/2025 17:53, Larry Garfield wrote: Now here's the big one: Using enums rather than a bunch of constants is a good change. However, I feel like it doesn't go far enough. 100% this. Writing "$ch->setOptionInt(Curl\Option\IntOpt::ConnectTimeout, 30);" instead of "curl_setopt(CURLOPT_

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Marco Aurélio Deleu
> > On 26 Jun 2025, at 18:07, Rowan Tommins [IMSoP] wrote: > > On 26/06/2025 17:53, Larry Garfield wrote: > >> Now here's the big one: Using enums rather than a bunch of constants is a >> good change. However, I feel like it doesn't go far enough. > > > 100% this. > > Writing "$ch->setO

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Eric Norris
Thanks Larry! > 1. I don't think the Curl\Option namespace is necessary. They can just be in > the main Curl namespace. I don't feel strongly here, but I thought it would be nice to group the enums (if we go the multiple enum route) for discoverability. Thoughts? > 2. Please don't name the exc

[PHP-DEV] Allow BcMath\Number to work identically to bcmath functions

2025-06-26 Thread Russell Lee
When `BcMath\Number` was introduced it allowed `string|int` method arguments. According to a separate RFC to allow `int` to the functions this was done as a performance optimization. Unfortunately this also means it effectively disallows `float` types because PHP will truncate them to integers

Re: [PHP-DEV][RFC] Deprecate type juggling to and from bool type within the function type juggling context

2025-06-26 Thread Gina P. Banyard
On Monday, 2 June 2025 at 17:11, Gina P. Banyard wrote: > Hello internals, > > This is the first RFC out of a set of type system related RFCs I want to > propose for PHP 8.5. > It also used the recently enabled Markdown support on the wiki, so there > might be a few oddities. > > The RFC prop

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Ben Ramsey
On Thu, Jun 26, 2025 at 11:27 Eric Norris wrote: > Hello Internals, > > I'd like to formally propose a restart of the original object-oriented > curl API RFC (https://wiki.php.net/rfc/curl-oop): > > https://wiki.php.net/rfc/curl_oop_v2 > > The prior RFC seemed to get positive feedback, with a sma

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Larry Garfield
On Thu, Jun 26, 2025, at 11:25 AM, Eric Norris wrote: > Hello Internals, > > I'd like to formally propose a restart of the original object-oriented > curl API RFC (https://wiki.php.net/rfc/curl-oop): > > https://wiki.php.net/rfc/curl_oop_v2 > > The prior RFC seemed to get positive feedback, with a

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Eric Norris
> IMO, this sounds like something that would be great to start as a userland > OOP wrapper for cURL, where it can be iterated on and the interface can be > tested and changed much quicker. Then, maybe proceed to an external extension > that can be migrated into core later, once its interface is

[PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Eric Norris
Hello Internals, I'd like to formally propose a restart of the original object-oriented curl API RFC (https://wiki.php.net/rfc/curl-oop): https://wiki.php.net/rfc/curl_oop_v2 The prior RFC seemed to get positive feedback, with a small consensus around wanting enum(s) for curl options. I've taken

Re: [PHP-DEV] [RFC][DISCUSSION] Object-oriented curl API v2

2025-06-26 Thread Thomas Bley
> Ben Ramsey hat am 26.06.2025 18:54 CEST geschrieben: > > > On Thu, Jun 26, 2025 at 11:27 Eric Norris mailto:eric.t.nor...@gmail.com> wrote: > > > Hello Internals, > > > > I'd like to formally propose a restart of the original object-oriented > > curl API RFC (https://wiki.php.net/rfc/c

Re: [PHP-DEV][RFC][DISCUSSION] Add $locale parameter for grapheme_* functions

2025-06-26 Thread youkidearitai
2025年6月16日(月) 15:46 youkidearitai : > > Hi, Internals > > I would like go to "Under Discussion" section. > And I noticed that add locale parameter for grapheme_levenshetin function. > Therefore, I added an RFC and pull request. > > - https://github.com/php/php-src/pull/18792 > - https://wiki.php.ne