[PHP-DEV] [VOTE] RFC: Nested Classes

2025-05-03 Thread Rob Landers
Hello Internals, I've opened the vote for nested classes https://wiki.php.net/rfc/short-and-inner-classes. Voting ends in a little over two weeks: May 17, at 23:59:59 UTC. — Rob

Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API

2025-05-03 Thread Máté Kocsis
Hi Ignace, I have just added the SensitiveParameter attribute to the Uri\Rfc3986\Uri::withUserInfo() and Uri\WhatWg\Url::withPassword() methods. > Reading the WHATWG URL specification and checking how > >- Chrome, >- Firefox >- and even https://github.com/TRowbotham/URL-Parser > > >

Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API

2025-05-03 Thread Máté Kocsis
Hi Ignace, Why can't the Url::resolve method also expose the `$errors` parameter like > the constructor and the parse static method ? As far as I understand it > nothing prevents the API from exposing the errors during URI resolution > which is a proxy method for the constructor call just like the

Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API

2025-05-03 Thread Máté Kocsis
Hey Ignace, > I see you updated the RFC but I believe there's still some errors in the > example: > $url = Uri\WhatWg\Url::parse("/foo", ".com"); // Throws > Uri\WhatWg\InvalidUrlException because of $baseUri > After following the suggestion of Tim, I changed the type of the $baseUrl parameters