Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct into a standard function

2024-08-08 Thread Gina P. Banyard
On Wednesday, 7 August 2024 at 17:07, Andreas Heigl wrote: > Stupid question maybe, but are we voting on the RFC or on the patch? > > If the patch does not match what.the RFC proposes, then the patch has a > problem. That should IMO though not affect voting on an RFC. > Or am I.missimg something

Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct into a standard function

2024-08-08 Thread Andreas Heigl
Hey Gina, hey all Am 08.08.24 um 15:44 schrieb Gina P. Banyard: On Wednesday, 7 August 2024 at 17:07, Andreas Heigl wrote: Stupid question maybe, but are we voting on the RFC or on the patch? If the patch does not match what.the RFC proposes, then the patch has a problem. That should IMO tho

Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a languageconstructinto a standard function

2024-08-08 Thread Tim Düsterhus
Hi On 8/6/24 00:55, Christoph M. Becker wrote: So, what are the cons: * removing the ZEND_EXIT opcode That immediately breaks any extension using it. A quick Github search lists 3.1 k occurrences[1]. For me this is a pro, because it makes the implementation simpler going forward: The engin

Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct into a standard function

2024-08-08 Thread Tim Düsterhus
Hi On 8/7/24 22:33, Theodore Brown wrote: I'm confused by this, since earlier in the thread Tim responded with examples showing how the behavior of exit() can still be observed and correctly handled. If that didn't address your issue, can you explain it further? It seems like right now everyo

Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct into a standard function

2024-08-08 Thread Rob Landers
On Thu, Aug 8, 2024, at 16:10, Andreas Heigl wrote: > Hey Gina, hey all > > Am 08.08.24 um 15:44 schrieb Gina P. Banyard: > > On Wednesday, 7 August 2024 at 17:07, Andreas Heigl > > wrote: > >> Stupid question maybe, but are we voting on the RFC or on the patch? > >> > >> If the patch does not