[PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Gina P. Banyard
Hello internals, While reviewing the PR for the "Adding bcround, bcfloor and bcceil to BCMath" RFC [1] with the different rounding modes, I was made aware of the unfortunate wrong terminology usage of PHP_ROUND_HALF_UP and PHP_ROUND_HALF_DOWN. Indeed, PHP_ROUND_HALF_UP is implemented as "roundi

Re: [PHP-DEV] [RFC] Casing of acronyms in class and method names

2024-04-14 Thread Tim Düsterhus
Hi On 4/12/24 15:53, Saki Takamachi wrote: This isn't a BC Break in theory as class names are, for the time being, case-insensitive. Strictly speaking, this can be considered a BC Break because the string returned by `::class` changes. However, I'm not sure how much of an impact it will have

Re: [PHP-DEV] [RFC] [Discussion] Support object type in BCMath

2024-04-14 Thread Saki Takamachi
Hi internals, I have reflected the discussion up to this point in the RFC. https://wiki.php.net/rfc/support_object_type_in_bcmath However, the point that the argument of `round()` is "precision" has not yet been reflected in the RFC. The argument names of standard's `round()` are also the same,

Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Saki Takamachi
Hi Gina, > Hello internals, > > While reviewing the PR for the "Adding bcround, bcfloor and bcceil to BCMath" > RFC [1] with the different rounding modes, > I was made aware of the unfortunate wrong terminology usage of > PHP_ROUND_HALF_UP and PHP_ROUND_HALF_DOWN. > > Indeed, PHP_ROUND_HALF_UP

Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Derick Rethans
On 14 April 2024 16:55:43 BST, Saki Takamachi wrote: >Hi Gina, > >> Hello internals, >> >> While reviewing the PR for the "Adding bcround, bcfloor and bcceil to >> BCMath" RFC [1] with the different rounding modes, >> I was made aware of the unfortunate wrong terminology usage of >> PHP_ROUND_H

Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Tim Düsterhus
Hi On 4/14/24 16:33, Gina P. Banyard wrote: Considering that PHP 8.4 is also adding new rounding modes via the "Add 4 new rounding modes to round() function" RFC [4] attempting to solve this issue in this next version of PHP seems like a good idea. In my discussions with Saki about this issue,

Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Jordan LeDoux
On Sun, Apr 14, 2024 at 9:50 AM Tim Düsterhus wrote: > > I don't think it should be in a namespace. The name is sufficiently > unique and clear. Without a broader concept for the namespace, we > probably should not introduce one. > > +1 For this, I don't think a namespace is necessary. Though I

Re: [PHP-DEV] Incorrect terminology usage for rounding modes of round()

2024-04-14 Thread Larry Garfield
On Sun, Apr 14, 2024, at 11:49 AM, Tim Düsterhus wrote: > Hi > > On 4/14/24 16:33, Gina P. Banyard wrote: >> Considering that PHP 8.4 is also adding new rounding modes via the "Add 4 >> new rounding modes to round() function" RFC [4] attempting to solve this >> issue in this next version of PHP s

Re: [PHP-DEV] [RFC][Vote announcement] Property hooks

2024-04-14 Thread Ilija Tovilo
Hi Matthew We're going to skip over the reiterations of Juliettes arguments, as they have already been responded to. On Thu, Apr 11, 2024 at 12:08 AM Matthew Weier O'Phinney wrote: > > On Mon, Apr 8, 2024 at 4:41 PM Ilija Tovilo wrote: >> >> https://externals.io/message/122445#122667 >> > > 2.

Re: [PHP-DEV][DISCUSSION] Fix mb_trim inaccurate $character

2024-04-14 Thread youkidearitai
2024年4月12日(金) 18:32 Nicolas Grekas : > > Hi > > Le jeu. 4 avr. 2024 à 07:41, youkidearitai a écrit : >> >> 2024年4月4日(木) 6:30 Tim Düsterhus : >> > >> > Hi >> > >> > On 4/3/24 10:02, youkidearitai wrote: >> > > Therefore, I think require an RFC, I have written a draft an RFC that >> > > fixes these