Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Gina P. Banyard
On Tuesday, 23 January 2024 at 02:45, Juliette Reinders Folmer wrote: > On 23-1-2024 3:18, Gina P. Banyard wrote: > > > The RFC notes that PHPStan and friends have an easy flag to make the > > > change, which is great, but still that's a minority of PHP devs that even > > > know to use static a

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Larry Garfield
On Tue, Jan 23, 2024, at 2:18 AM, Gina P. Banyard wrote: > On Monday, 22 January 2024 at 18:53, Larry Garfield > wrote: >> I am in support of this change. My only concern is timeline. This RFC would >> deprecate it in 8.4, and presumably support would be removed in 9.0. While >> we haven't disc

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Gina P. Banyard
On Tuesday, 23 January 2024 at 16:37, Larry Garfield wrote: > On Tue, Jan 23, 2024, at 2:18 AM, Gina P. Banyard wrote: > > > I fundamentally disagree with the logic that we somehow need to "plan" > > deprecations around how much time we need to provide users to upgrade. > > > I categoricall

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Kamil Tekiela
FWIW I think one year is more than enough of deprecation time for any change, especially for something so easy as this. It's not like we are forcing users to upgrade to the newest version as soon as possible. I still haven't used PHP 8.3, and I most likely will not use it for another year. In pract

Re: [PHP-DEV] [RFC][Vote] RFC1867 for non-POST HTTP verbs

2024-01-23 Thread Sara Golemon
On Mon, Jan 22, 2024 at 1:24 AM Ilija Tovilo wrote: > I started the vote on the "RFC1867 for non-POST HTTP verbs" RFC. > https://wiki.php.net/rfc/rfc1867-non-post > > Apologies for not seeing the discussion period, but I'll qualify my "No" vote, because I'm actually +1 on the general concept, and

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Juliette Reinders Folmer
On 22-1-2024 10:50, Gina P. Banyard wrote: Hello internals, Máté Kocsis and myself would like to propose deprecating implicitly nullable parameter types. The RFC is available on the wiki at the following address: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types Best regards, Gin

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-01-23 Thread Ayesh Karunaratne
> > I just encountered this language inconsistency when trying to remove > nullable from a constructor-promoted property: > > ``` > class MyClass > { > public function __construct( > public ?string $title = null // removing "?" here causes "Fatal > error: Cannot use null as default valu