[PHP-DEV][VOTE][RFC] Add multibyte trim function mb_trim, mb_ltrim and mb_rtrim

2023-11-02 Thread youkidearitai
Hi, Internals I have just opened voting on the RFC to mb_trim. Voting started now, and will run until November 17th, 24:00 GMT Link: https://wiki.php.net/rfc/mb_trim#voting (It's my first time so please tell me if I'm any wrong) Regards Yuya -- --- Yuya Hamada (tekimen

Re: [PHP-DEV] Re: [External] : [PHP-DEV] [VOTE] [RFC] Unbundle ext/imap, ext/pspell, ext/oci8, and ext/PDO_OCI

2023-11-02 Thread Peter Kokot
On Thu, 2 Nov 2023 at 05:02, Christopher Jones wrote: > > On 2/11/2023 2:46 am, Derick Rethans wrote: > > Hi, > > > > I have just opened voting on the RFC to unbundle imap, pspell, and > > oracle integrations. > > :) > > -- > https://twitter.com/ghrd > > -- > PHP Internals - PHP Runtime Developme

[PHP-DEV] Short Function Syntax

2023-11-02 Thread Oladoyinbo Vincent
Hello Internals, I don't know maybe this discussion has been raised before, but i feel we should re-discuss this. `function` syntax is kinda verbose for naming methods in class, let's take a look at the below example: ```php class Greet { public function __construct( private strin

Re: [PHP-DEV] Short Function Syntax

2023-11-02 Thread Vinicius Dias
I honestly don't see any benefits. `function` isn't verbose, it's explicit. I prefer `function` over `fn` for methods. But despite what one may prefer, I believe changing the language syntax just because of "taste" probably isn't worth the effort. -- PHP Internals - PHP Runtime Development Maili

Re: [PHP-DEV] Short Function Syntax

2023-11-02 Thread Oleksii Bulba
> I know that the `fn` Syntax is already used for arrow functions, but what i > am suggesting is that, can't we make `fn` to be used in naming methods in > class? (this will be optional though), Hello Oladoyinbo, Personally for me, if I see `fn` in methods instead of `function` I would expect it

Re: [PHP-DEV] Short Function Syntax

2023-11-02 Thread daniil
Hi, I don't hate the idea, I actually really like the rust-ish look of it, though personally I would prefer to have short function syntax for closures before methods (I.e. fn () { ... } is a syntax I wanted and could not use countless times in all the years since the introduction of arrow functi

Re: [PHP-DEV] Previous discussions about generics syntax only?

2023-11-02 Thread daniil
Hi all, Perhaps chiming into the conversation a bit too late, but I would personally like to say that I *really* do not like the idea of attribute-like, unvalidated generics syntax. As a maintainer of Psalm and an active user of it both personally and at work, I absolutely *adore* the typesafet

Re: [PHP-DEV] Deprecate posix_times

2023-11-02 Thread daniil
Hi, I would like to echo the sentiment expressed by Tim earlier in another subthread: >If a function cannot be safely or correctly used at all, then it shouldn't >exist, especially if there are working alternatives [1]. > >Expecting users to find a warning in the docs to learn that they should

Re: [PHP-DEV] Deprecate posix_times

2023-11-02 Thread daniil
Hi, > This deprecation appears to be sufficiently simple that it can likely be > included in the bulk deprecation RFC for PHP 8.4: > > https://wiki.php.net/rfc/deprecations_php_8_4 That would be super nice, who should I ping before editing the page? Regards, Daniil Gentili

Re: [PHP-DEV] Final anonymous classes

2023-11-02 Thread daniil
Hi, > One thing I'm not sure about: What opcache optimizations would final enable?  Well for example, any JIT logic gated behind a check on ZEND_ACC_FINAL: https://github.com/php/php-src/blob/master/ext/opcache/jit/zend_jit_trace.c#L4507 Regards, Daniil Gentili