Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-05 Thread G. P. B.
On Thu, 5 Oct 2023 at 07:40, Marc Bennewitz wrote: > I don't see a bug or broken behavior here as these functions were > processing floating point numbers since forever. > > https://3v4l.org/PrrmO > That's not my point, the point is about the function being broken for large 64bit integers, w

Re: [PHP-DEV] [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-10-05 Thread Saki Takamachi
Hi, Pierre In fact, I predict that many use cases will be covered by GMP. Still, I think that there may be cases where calculation functions like mainframe BCD are required, such as when calculating money. I am unable to decide whether it is correct to deprecate BCMath and only use GMP. I'd l

RE: [PHP-DEV] [RFC] [Discussion] Adding bcround, bcfloor and bcceil to BCMath

2023-10-05 Thread Jeffrey Dafoe
> -Original Message- > Still, I think that there may be cases where calculation functions like > mainframe > BCD are required, such as when calculating money. We use BCMath for money calculations. -Jeff -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https

Re: [PHP-DEV] [RFC] [Discussion] A new JIT implementation based on IR Framework

2023-10-05 Thread Dmitry Stogov
Hi Internals, I've published a presentation about the IR Framework design and implementation details. See https://www.researchgate.net/publication/374470404_IR_JIT_Framework_a_base_for_the_next_generation_JIT_for_PHP It explains many complex things in simple pictures. Thanks. Dmitry. On Thu, Sep

Re: [PHP-DEV] [RFC] [Discussion] A new JIT implementation based on IR Framework

2023-10-05 Thread Paul Dragoonis
On Thu, 5 Oct 2023, 17:44 Dmitry Stogov, wrote: > Hi Internals, > > I've published a presentation about the IR Framework design and > implementation details. > See > > https://www.researchgate.net/publication/374470404_IR_JIT_Framework_a_base_for_the_next_generation_JIT_for_PHP > It explains many

Re: [PHP-DEV] [VOTE] Increasing the default BCrypt cost

2023-10-05 Thread Tim Düsterhus
Hi On 9/21/23 19:26, Tim Düsterhus wrote: I just opened the vote for the "Increasing the default BCrypt cost" RFC. The RFC contains a two votes, one primary vote that requires a 2/3 majority to pass and a secondary vote deciding on the new costs with a simple majority. Voting runs 2 weeks until

Re: [PHP-DEV] [VOTE] Increasing the default BCrypt cost

2023-10-05 Thread Tim Düsterhus
Hi Let me link your Fediverse reply for reference as well: https://infosec.exchange/@sc00bz/78818937154254 On 10/5/23 02:07, st...@tobtu.com wrote: I know I'm late but bcrypt cost 12 (which looks like the winner) is high. Cost 12 is ~1 kH/s/GPU and the accepted limit for good settings is

Re: [PHP-DEV] proc_open() resource to opaque object migration

2023-10-05 Thread Tim Düsterhus
Hi On 9/28/23 23:21, Derick Rethans wrote: Yes, lacking evidence that the name is actually being used: Process PHP "owns" the top level namespace. This has been documented for decades, too. I agree here. While I'm totally in favor of using namespaces in core, it should be done somewhat cons

[PHP-DEV] [PHP-DEF][RFC][VOTE] A new JIT implementation based on IR Framework

2023-10-05 Thread Dmitry Stogov
Hi internals, The vote on "A new JIT implementation based on IR Framework" RFC is started. https://wiki.php.net/rfc/jit-ir Thanks. Dmitry.

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-05 Thread Tim Düsterhus
Hi On 10/4/23 08:35, Marc Bennewitz wrote: As far as I understand you are in favor of option 1. (considering it a bugfix) but how do you make sure this will not lead to different application behavior overlooked on upgrading? Also there is no way to opt-in new behavior. Yes, I would be in favo

Re: [PHP-DEV] [PHP-DEF][RFC][VOTE] A new JIT implementation based on IR Framework

2023-10-05 Thread Tim Düsterhus
Hi On 10/5/23 21:52, Dmitry Stogov wrote: The vote on "A new JIT implementation based on IR Framework" RFC is started. https://wiki.php.net/rfc/jit-ir One small note: You forgot to adjust the 'Status' at the top of the RFC itself. It still specifies 'Under Discussion' instead of Voting. Ot

Re: [PHP-DEV] [PHP-DEF][RFC][VOTE] A new JIT implementation based on IR Framework

2023-10-05 Thread Dmitry Stogov
On Thu, Oct 5, 2023 at 11:07 PM Tim Düsterhus wrote: > Hi > > On 10/5/23 21:52, Dmitry Stogov wrote: > > The vote on "A new JIT implementation based on IR Framework" RFC is > started. > > > > https://wiki.php.net/rfc/jit-ir > > One small note: You forgot to adjust the 'Status' at the top of the R

Re: [PHP-DEV] Re: [RFC] [Discussion] Add 4 new rounding modes to round() function

2023-10-05 Thread Jorg Sowa
> I don't think deprecating the constants in the version where the aliases are introduced is a good idea. I removed the deprecation. You are right. > I will also echo Tim's idea of using an enum instead and a union type. > For the namespace, I think it would make sense to use Maths\RoundingMode