Re: [PHP-DEV] Deprecating uniqid()

2020-05-03 Thread Jakob Givoni
On Sat, May 2, 2020 at 9:58 PM Nikita Popov wrote: > > On Sat, May 2, 2020 at 9:13 PM Ben Ramsey wrote: > > > > On May 2, 2020, at 13:57, AllenJB wrote: > > > > > > Hi all, > > > > > > I'd like to discuss deprecating uniqid() > > > > > > I believe it's dangerously bad a doing "what it says on th

Re: [PHP-DEV] Deprecating uniqid()

2020-05-03 Thread Rowan Tommins
On 03/05/2020 09:54, Jakob Givoni wrote: I'm using this function frequently, but I am ok with deprecating it as I think the name is dangerously misleading - basically, anything that mentions "unique" without saying to what, is a misnomer. However, as it's useful to have a function in core that gi

Re: [PHP-DEV] opcache.jit directive should be split up

2020-05-03 Thread tyson andre
Hi CHU Zhaowei, By alias, I meant "an **alternative** name or label that refers to an item, and can be used to locate or access it." (add a way to set the option without removing existing ways) (Users would have the choice of using both the magic numbers or the strings to refer to the same sett

[PHP-DEV] Re: [RFC] Always available JSON extension

2020-05-03 Thread tyson andre
Hi internals, I plan to start the vote for https://wiki.php.net/rfc/always_enable_json on May 13th > I've created https://wiki.php.net/rfc/always_enable_json with an >implementation at https://github.com/php/php-src/pull/5495 > > The proposal is to make it impossible to disable the JSON extensi

Re: [PHP-DEV] Re: [RFC] Always available JSON extension

2020-05-03 Thread Levi Morrison via internals
Have we reached out to package maintainers for OS distributions that are not bundling json today to make sure all their concerns are resolved?

Re: [PHP-DEV] Re: [RFC] Always available JSON extension

2020-05-03 Thread tyson andre
Hi Levi, > Have we reached out to package maintainers for OS distributions that are not > bundling json today to make sure all their concerns are resolved? I CCed them on the GitHub PR just now. https://github.com/php/php-src/pull/5495#issuecomment-623163698 Hopefully, this is due to packaging

Re: [PHP-DEV] Deprecating uniqid()

2020-05-03 Thread Niklas Keller
Hey Allen, there's been discussion on whether we should deprecate or replace its functionality. Without changing the output format, it's impossible to have enough entropy. Without consensus on the best way forward, I've just never cared to put this to a vote. I'll happily collaborate on moving t

Re: [PHP-DEV] Deprecating uniqid()

2020-05-03 Thread Jakob Givoni
On Sun, May 3, 2020 at 2:57 PM Rowan Tommins wrote: > > A common suggestion is to use binhex(random_bytes($desired_length / 2)), > which isn't particularly elegant, and in my experience, the main > requirement is "a unique string of printable/alphanumeric characters, so > limiting to [0-9a-f] is j

Re: [PHP-DEV] Deprecating uniqid()

2020-05-03 Thread Andreas Heigl
Hey Ben, hey all Am 02.05.20 um 21:13 schrieb Ben Ramsey: >> On May 2, 2020, at 13:57, AllenJB wrote: >> >> Hi all, >> >> I'd like to discuss deprecating uniqid() >> >> I believe it's dangerously bad a doing "what it says on the tin". New >> developers still reach for it and do not read the warn