[PHP-DEV] Remove special Zend karma

Hi internals, We currently have separate karma for the Zend/TSRM directories in php-src. I think this separation has become more annoying than useful at this point. Most changes from newer contributors are approved on GitHub first, and we often have to grant some form of Zend karma for tests if no

Re: [PHP-DEV] Remove special Zend karma

+1 Cheers Joe On Fri, 23 Aug 2019 at 10:33, Nikita Popov wrote: > Hi internals, > > We currently have separate karma for the Zend/TSRM directories in php-src. > I think this separation has become more annoying than useful at this point. > Most changes from newer contributors are approved on Git

[PHP-DEV] Re: Remove special Zend karma

On 23.08.2019 at 10:32, Nikita Popov wrote: > We currently have separate karma for the Zend/TSRM directories in php-src. > I think this separation has become more annoying than useful at this point. > Most changes from newer contributors are approved on GitHub first, and we > often have to grant s

Re: [PHP-DEV] Remove special Zend karma

> On 23 Aug 2019, at 10:33, Nikita Popov wrote: > > Hi internals, > > We currently have separate karma for the Zend/TSRM directories in php-src. > I think this separation has become more annoying than useful at this point. > Most changes from newer contributors are approved on GitHub first, a

Re: [PHP-DEV] Remove special Zend karma

On 23 Aug 2019, at 10:56, Zeev Suraski mailto:z...@zend.com>> wrote: On 23 Aug 2019, at 10:33, Nikita Popov mailto:nikita@gmail.com>> wrote: Hi internals, We currently have separate karma for the Zend/TSRM directories in php-src. I think this separation has become more annoying than use

[PHP-DEV] Re: PHP 7.2 minimum ICU version

On 22.08.2019 at 19:05, Trevor Rowbotham wrote: > On Thursday, August 22, 2019 11:00 AM, Christoph M. Becker > wrote: > >> On 22.08.2019 at 15:54, Sara Golemon wrote: >> >>> Or perhaps tailor the deprecation warning a little? (Nevermind, I just >>> wrote it out and it gets ugly) >>> Or perhaps j

Re: [PHP-DEV] Remove special Zend karma

On Fri, Aug 23, 2019 at 11:25 AM Zeev Suraski wrote: > > On 23 Aug 2019, at 10:56, Zeev Suraski wrote: > > > > On 23 Aug 2019, at 10:33, Nikita Popov wrote: > > > Hi internals, > > > We currently have separate karma for the Zend/TSRM directories in php-src. > > I think this separation has becom

Re: [PHP-DEV] Remove special Zend karma

Hi! > Any objections to dropping this and have a single php-src karma for the > whole tree (with the exception of php_version.h, which is used to prevent > bad merges)? Makes sense to merge Zend karma into php-src karma (I imagine smaller karma sets, e.g. for tests or specific ext only, remain?).