[PHP-DEV] [RFC] [Vote] Base convert changes

Hi all I have put my RFC base convert changes to vote this morning https://wiki.php.net/rfc/base_convert_improvements Two votes, one to raise a deprecated error in PHP7.4 (raised to exception in PHP 8) when base_convert encounters something it doesnt know how to convert. Second vote is to a

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

The implementation of this does not look ready, there are conflicts so I can't test it locally, but last time CI ran there were many failures. Cheers Joe On Wed, 19 Jun 2019 at 09:24, Scott Dutton wrote: > Hi all > > I have put my RFC base convert changes to vote this morning > > https://wiki.p

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

Hi Joe, I will take a look at conflicts. The failures are extreme value checks which are a result of allowing the negative numbers. If the negative numbers one passes I will fix all tests and add some more for the negative values. The tests fail because of the unsigned -> signed change (but a

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

There should probably be a PR targeting 7.4 with the implementation of "Error on ignored characters" as proposed for 7.4, and a PR targeting master implementing "Error on ignored characters" with exception change and implementing "Allow negative arguments". None of these PR's should cause tests to

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

It will likely be easier if the Allow negative numbers implementation (targetting master only) is entirely separate from the Error on ignored characters implementation,. Cheers Joe On Wed, 19 Jun 2019 at 09:56, Joe Watkins wrote: > There should probably be a PR targeting 7.4 with the implementa

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

Hi Joe, I will have a look at splitting the PR, I am not at a computer where i can code today though so will be tomorrow at the earliest. The Negative numbers will be a fair amount of work to make the tests pass, would this still need to be done if the RFC doesnt pass ? I am happy to do this

[PHP-DEV] Re: PHP 7.4.0alpha1 is available for testing

Jan Ehrhardt in php.internals (Wed, 19 Jun 2019 03:16:58 +0200): >Derick Rethans in php.internals (Thu, 13 Jun 2019 12:50:48 +0100 (BST)): >>PHP 7.4.0alpha1 has just been released and can be downloaded from: >> >> >> >>Or use the git tag: php-7.4.0alpha1 >> >

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

On Wed, Jun 19, 2019 at 10:06 AM Scott Dutton wrote: > Hi Joe, > > I will have a look at splitting the PR, I am not at a computer where i > can code today though so will be tomorrow at the earliest. > > The Negative numbers will be a fair amount of work to make the tests > pass, would this still

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

Ah thats brilliant, I will take a look at updating the tests when I split the PR tomorrow Thanks Nikita Scott On 19.06.2019 09:13, Nikita Popov wrote: On Wed, Jun 19, 2019 at 10:06 AM Scott Dutton wrote: Hi Joe, I will have a look at splitting the PR, I am not at a computer where i c

RE: [PHP-DEV] [RFC] [Vote] Base convert changes

Hi Scott, Could you clarify what will happen if multiple negative sign occurs. I didn't find it in the RFC. e.g. base_convert('--ff', 16, 10) Thanks, CHU Zhaowei > -Original Message- > From: Scott Dutton > Sent: Wednesday, June 19, 2019 3:24 PM > To: internals@lists.php.net > Subject:

[PHP-DEV] [RFC] Desire to move RFC add_str_begin_and_end_functions to a vote

I sent this earlier this week without [RFC] in the subject line...since some people might have filters to check the subject line I wanted to send this again with the proper substring in the subject line–to make it clear I intend to take this to a vote in two weeks. Apologies for the duplicate e

[PHP-DEV] libsodium based Argon2i(d) password_hash()

I intend to move https://wiki.php.net/rfc/sodium.argon.hash into voting on Friday. Note that I need to update the PR to reflect the decision to synchronize the time_cost and mem_limit defaults for libargon based hashing with libsodium. If you have any last minute issues with this RFC, please bri

[PHP-DEV][RFC] Normalize array's "auto-increment" value on copy on write

Hello internals, I just published another RFC https://wiki.php.net/rfc/normalize-array-auto-increment-on-copy-on-write Please keep in mind that my intentions are good and I am proposing things in the interest of everybody. Also, I am aware that I might be wrong. If I am, please illustrate the rea