Re: [PHP-DEV] Re: Merging new hash algorithm (crc32c) into PHP 7.3 and maybe 7.2?

2019-03-11 Thread Sebastian Bergmann
Am 10.03.2019 um 21:12 schrieb Gabriel Caruso: As both PHP 7.2 and 7.3 has been out for a while, -1 on this one. Same here; no new functionality should be added to already released versions. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub

Re: [PHP-DEV] Wiki RFC karma request

2019-03-11 Thread Nikita Popov
On Sun, Mar 10, 2019 at 2:07 PM Guilliam Xavier wrote: > Hello, > > I'd like to do some work on the Nullable Casting RFC (encouraged by > its author). Could someone grant the wiki user guilliamxavier the > necessary karma? > Hi, I've granted you rfc karma on the wiki. Please check if it works.

Re: [PHP-DEV] Base_convert changes

2019-03-11 Thread Nikita Popov
On Sun, Mar 10, 2019 at 1:29 PM Scott Dutton wrote: > Hi, > > I have just put a pull request together to make some changes to > base_convert, the changes are as follows: > > 1, Allow conversion of negative numbers (fixes > https://bugs.php.net/bug.php?id=55393) > 2, Raise a notice when passing in

Re: [PHP-DEV] RFC: Locked Classes

2019-03-11 Thread Nikita Popov
On Sun, Mar 10, 2019 at 7:35 PM Rowan Collins wrote: > Hi all, > > I'd like to present a new RFC for "locked classes": classes which > restrict dynamically adding or removing properties from their instances. > > While it can be useful, the ability to set an object property which is > not part of

Re: [PHP-DEV] RFC: Locked Classes

2019-03-11 Thread Rowan Collins
Hi Nikita, On Mon, 11 Mar 2019 at 11:27, Nikita Popov wrote: > The solution I would prefer is the ability to declare that within a > project, all interactions with objects (whether they are my own or come > from 3rd parties) should disallow the creation of dynamic properties. This > differs from

Re: [PHP-DEV] RFC Draft: Comprehensions

2019-03-11 Thread Nikita Popov
On Sun, Mar 10, 2019 at 10:45 PM Larry Garfield wrote: > Hello, peoples. I know it's been discussed once or twice before on the > list, many years ago, but not recently. I therefore feel OK putting forth > the following draft proposal for Comprehensions, aka "compact generators", > in PHP: > >

Re: [PHP-DEV] RFC: Locked Classes

2019-03-11 Thread Rowan Collins
On Mon, 11 Mar 2019 at 12:14, Rowan Collins wrote: > > declare(strict_properties=0) { > class Foo {} > $foo = new Foo; > $foo->bar = 42; > } > declare(strict_properties=1) { > echo $foo; # Is $bar now 'defined', or do we only count the properties > in the original class definition

Re: [PHP-DEV] RFC: Locked Classes

2019-03-11 Thread Nikita Popov
On Mon, Mar 11, 2019 at 1:14 PM Rowan Collins wrote: > Hi Nikita, > > On Mon, 11 Mar 2019 at 11:27, Nikita Popov wrote: > > > The solution I would prefer is the ability to declare that within a > > project, all interactions with objects (whether they are my own or come > > from 3rd parties) shou

Re: [PHP-DEV] Re: Merging new hash algorithm (crc32c) into PHP 7.3 and maybe 7.2?

2019-03-11 Thread Andrew Brampton
Ok thanks everyone. Merging into master it is. Thanks Andrew On Mon, 11 Mar 2019, 12:33 am Sebastian Bergmann, wrote: > Am 10.03.2019 um 21:12 schrieb Gabriel Caruso: > > As both PHP 7.2 and 7.3 has been out for a while, -1 on this one. > > Same here; no new functionality should be added to alr

[PHP-DEV] Re: PHP 7.4 Release Manager Selection

2019-03-11 Thread Christoph M. Becker
Hi all! On 04.03.2019 at 17:28, Christoph M. Becker wrote: > With the first alpha of 7.4 due in three months, I think it's time to > start the process of finding and electing release managers for the next > minor release of PHP. > > We are looking for two souls to take on this role. Whomsoever

Re: [PHP-DEV] RFC: Locked Classes

2019-03-11 Thread Rowan Collins
On Mon, 11 Mar 2019 at 12:35, Nikita Popov wrote: > > Removing the ability to use dynamic properties (even excluding stdClass) > is probably not feasible on a short timetime. However, I think that having > a directory-scoped declare would also be useful for that, because it allows > a more gradua

Re: [PHP-DEV] Re: PHP 7.4 Release Manager Selection

2019-03-11 Thread Derick Rethans
On Mon, 11 Mar 2019, Christoph M. Becker wrote: > On 04.03.2019 at 17:28, Christoph M. Becker wrote: > > > With the first alpha of 7.4 due in three months, I think it's time > > to start the process of finding and electing release managers for > > the next minor release of PHP. > > > > We are

Re: [PHP-DEV] Re: Merging new hash algorithm (crc32c) into PHP 7.3 and maybe 7.2?

2019-03-11 Thread Derick Rethans
Hi, don't forget the PHP-7.4 branch, which is *not* master (master is 8.0). cheers, Derick On Mon, 11 Mar 2019, Andrew Brampton wrote: > Ok thanks everyone. Merging into master it is. > > Thanks > Andrew > > On Mon, 11 Mar 2019, 12:33 am Sebastian Bergmann, wrote: > > > Am 10.03.2019 um 21:

Re: [PHP-DEV] Re: Merging new hash algorithm (crc32c) into PHP 7.3 and maybe 7.2?

2019-03-11 Thread Sebastian Bergmann
Am 11.03.2019 um 15:20 schrieb Derick Rethans: don't forget the PHP-7.4 branch, which is *not* master (master is 8.0). Nikita already merged it into PHP-7.4 and master. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Mitigate “Magellan vulnerabilitites” in PHP 7.2?

2019-03-11 Thread Christoph M. Becker
On 19.02.2019 at 02:16, Stanislav Malyshev wrote: >> In my opinion, adding this ini setting to PHP-7.4 is a no brainer, but I >> suggest that we backport it to PHP-7.2 as well. > > I don't see a reason why not - if the option is useful for improving > security/stability, let's backport it. If it'

Re: [PHP-DEV] Mitigate “Magellan vulnerabilitites” in PHP 7.2?

2019-03-11 Thread Joe Watkins
Cheery picked into 7.1 Cheers Joe On Mon, 11 Mar 2019 at 17:35, Christoph M. Becker wrote: > On 19.02.2019 at 02:16, Stanislav Malyshev wrote: > > >> In my opinion, adding this ini setting to PHP-7.4 is a no brainer, but I > >> suggest that we backport it to PHP-7.2 as well. > > > > I don't see

Re: [PHP-DEV] Wiki RFC karma request

2019-03-11 Thread Guilliam Xavier
On Mon, Mar 11, 2019 at 11:47 AM Nikita Popov wrote: > > Hi, > > I've granted you rfc karma on the wiki. Please check if it works. Yes, now I can edit pages under /rfc, thank you :) -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Deprecate short_open_tag ini directive?

2019-03-11 Thread G. P. B.
Hello internals, I'm currently going through the PHP doc to remove mentions of PHP 4 and stumbled upon the short_open_tag ini directive [1] which only affects the availability of `From my understanding, the `https://secure.php.net/manual/en/ini.core.php#ini.short-open-tag

Re: [PHP-DEV] RFC Draft: Comprehensions

2019-03-11 Thread Larry Garfield
On Mon, Mar 11, 2019, at 8:16 AM, Nikita Popov wrote: > On Sun, Mar 10, 2019 at 10:45 PM Larry Garfield > wrote: > > > Hello, peoples. I know it's been discussed once or twice before on the > > list, many years ago, but not recently. I therefore feel OK putting forth > > the following draft pro