Re: [PHP-DEV] Translating optional zval ** withzend_parse_parameters() to PHP 7

2016-11-26 Thread Christoph M. Becker
On 26.11.2016 at 01:47, Thomas Hruska wrote: > Okay, everyone has been helpful. Thanks. I'll go with: > > > zval *zprevcount = NULL; > zend_long count; > > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|z/", > &zprevcount) == FAILURE) return; > > ... > > if (zpr

Re: [PHP-DEV] Translating optional zval ** withzend_parse_parameters() to PHP 7

2016-11-26 Thread Nikita Popov
On Sat, Nov 26, 2016 at 12:29 PM, Christoph M. Becker wrote: > On 26.11.2016 at 01:47, Thomas Hruska wrote: > > > Okay, everyone has been helpful. Thanks. I'll go with: > > > > > > zval *zprevcount = NULL; > > zend_long count; > > > > if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS

Re: [PHP-DEV] Translating optional zval ** withzend_parse_parameters()to PHP 7

2016-11-26 Thread Christoph M. Becker
On 26.11.2016 at 12:45, Nikita Popov wrote: > On Sat, Nov 26, 2016 at 12:29 PM, Christoph M. Becker > wrote: > >> On 26.11.2016 at 01:47, Thomas Hruska wrote: >> >>> Okay, everyone has been helpful. Thanks. I'll go with: >>> >>> >>> zval *zprevcount = NULL; >>> zend_long count; >>> >>>

Re: [PHP-DEV] Translating optional zval **withzend_parse_parameters()to PHP 7

2016-11-26 Thread Christoph M. Becker
On 26.11.2016 at 13:55, Christoph M. Becker wrote: > On 26.11.2016 at 12:45, Nikita Popov wrote: > >> The fact that php_pcre.c uses zval_dtor() is simply a bug, because code like >> >> $obj = new stdClass; >> $obj->obj = $obj; >> preg_match('/./', 'x', $obj); >> >> leaks. > > Indeed.

[PHP-DEV] [RFC] Distrust SHA-1 Certificates

2016-11-26 Thread Niklas Keller
Morning Internals, I plan to distrust SHA-1 certificates by default in PHP 7.2. All major browsers will no longer trust SHA-1 certificates starting already 2017-01-01. Unfortunately, PHP doesn't even provide a way yet to limit the accepted algorithms for certificates. The RFC fixes that and intro

[PHP-DEV] Re: [RFC] Parameter No Type Variance

2016-11-26 Thread Niklas Keller
2016-11-21 12:59 GMT+01:00 Christoph M. Becker : > On 21.11.2016 at 10:39, Niklas Keller wrote: > > > I'd like to announce a RFC to allow omitting the type declarations for > > parameters in subclasses: > > https://wiki.php.net/rfc/parameter-no-type-variance > > > > PHP doesn't currently allow var

Re: [PHP-DEV] [RFC] Distrust SHA-1 Certificates

2016-11-26 Thread Stanislav Malyshev
Hi! > You can read the full RFC in the wiki: > https://wiki.php.net/rfc/distrust-sha1-certificates I would propose making a constant for default value. This way if your code wants to use that option is a generic way, there is a value to fall back on, and you don't need to keep around a long strin

Re: [PHP-DEV] Re: [RFC] Parameter No Type Variance

2016-11-26 Thread Stanislav Malyshev
Hi! > Anyone else interested in the usage of "mixed" as an explicit type > declaration? Please no. We already have "mixed" - every variable is "mixed". We don't need more cruft in the code that does not add anything that doesn't already exist. -- Stas Malyshev smalys...@gmail.com -- PHP Inter