Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing - Vote reopened and restarted

2016-08-03 Thread Davey Shafik
Hey Yasuo, Unfortunately this missed beta2 (tagged yesterday), I'll confirm with Joe about putting it in for 7.1beta3. Thanks for those last minute changes, I'm much happier with this result! :) - Davey On Tue, Aug 2, 2016 at 10:29 PM, Yasuo Ohgaki wrote: > Hi all, > > Session ID without hash

Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions

2016-08-03 Thread Lauri Kenttä
Hello, I only saw you mention strpos, preg_match and substr as (slower) alternatives. However, there's already a function called substr_compare which is meant for just this kind of comparisons but which is more general than your RFC. function str_begins($a, $b) { return substr_compare($a,

Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions

2016-08-03 Thread Christoph Becker
On 03.08.2016 at 09:59, Lauri Kenttä wrote: > I only saw you mention strpos, preg_match and substr as (slower) > alternatives. However, there's already a function called substr_compare > which is meant for just this kind of comparisons but which is more > general than your RFC. Thanks for pointin

[PHP-DEV] UGLY Benchmark Results for PHP Master 2016-08-03

2016-08-03 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-08-03 06:26:58+03:00 commit: 6a748c2 previous commit:7b4157d revision date: 2016-08-03 00:35:16+02:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC][Vote] ReflectionType Improvements

2016-08-03 Thread Levi Morrison
On Sun, Jul 17, 2016 at 5:31 PM, Levi Morrison wrote: > On Mon, Jul 11, 2016 at 10:30 AM, Aaron Piotrowski > wrote: > > Hi Levi, > > > > On Jul 9, 2016, at 10:12 AM, Levi Morrison wrote: > > > > On Sat, Jul 9, 2016 at 8:16 AM, Aaron Piotrowski > wrote: > > > > > > Additionally, I propose addin

[PHP-DEV] Re: [RFC][DISCUSSION] Add validation functions to filter

2016-08-03 Thread Yasuo Ohgaki
Hi all, Patch for this RFC is update https://github.com/php/php-src/pull/2048 - Added filter_check_definition() - Check definition array for validate_*_array() and filter_*_array(). These functions ignores error silently and this behavior could result in serious security issue. We should provide

Re: [PHP-DEV] More packed hash optimizations in array.c

2016-08-03 Thread Benjamin Coutu
Hello Xinchen, Thanks for changing array_pad and array_rand accordingly, that's very good. I noticed a small improvement we could make to array_slice for the packed case: We can change line 3003: if ((Z_ARRVAL_P(input)->u.flags & HASH_FLAG_PACKED) && !preserve_keys) => if ((Z_ARRVAL_P(input)->u.

Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() to which version?

2016-08-03 Thread Christian Stadler
Am 01.08.2016 um 10:23 schrieb Yasuo Ohgaki: > P.S. It's possible to return array that contains offending values. It > is not included since users can store whole offending input array. > Whole input is more useful for attack analysis. Actually I wanted to suggest exactly that for ppl. who want to

Re: [PHP-DEV] More packed hash optimizations in array.c

2016-08-03 Thread Xinchen Hui
Hey: On Wed, Aug 3, 2016 at 10:48 PM, Benjamin Coutu wrote: > Hello Xinchen, > > Thanks for changing array_pad and array_rand accordingly, that's very good. > > I noticed a small improvement we could make to array_slice for the packed > case: > > We can change line 3003: > if ((Z_ARRVAL_P(input)

Re: [PHP-DEV] [RFC][DISCUSSION] Add validation functions to filter

2016-08-03 Thread Pierre Joye
Hi Yasuo, On Wed, Aug 3, 2016 at 1:43 PM, Yasuo Ohgaki wrote: > Hi all, > > This RFC is to add validation functions and string validation filter. > > https://wiki.php.net/rfc/add_validate_functions_to_filter > > It also allows to define multiple filters for an input. i.e. You can > apply multiple

Re: [PHP-DEV] RFC Posted for str_begins and str_ends functions

2016-08-03 Thread Stanislav Malyshev
Hi! > I guess that "i" isn't appliable when it have slashes. > In this case, functions should be: strbegins, stribegins, strends, striends. > In all case, I think that is better a third parameter and keep underlined. Please, not stribegins. We have enough functions with weird names :) I am ambiva