[PHP-DEV] NEUTRAL Benchmark Results for PHP Master 2016-01-14

2016-01-14 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-01-14 06:30:47+02:00 commit: 092a87c previous commit:bef1245 revision date: 2016-01-13 21:32:38+01:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Fixing bug #68063

2016-01-14 Thread Julien Pauli
On Wed, Jan 13, 2016 at 12:03 AM, Stanislav Malyshev wrote: > Hi! > >> I've disallowed empty session ID, but it wasn't a >> appropriate fix. >> >> https://bugs.php.net/bug.php?id=68063 > > Could you explain a bit more about the part where there are empty IDs > generated? You say it "is browser's c

Re: [PHP-DEV] Fixing bug #68063

2016-01-14 Thread Yasuo Ohgaki
Hi Julien, On Thu, Jan 14, 2016 at 7:21 PM, Julien Pauli wrote: > On Wed, Jan 13, 2016 at 12:03 AM, Stanislav Malyshev > wrote: >> Hi! >> >>> I've disallowed empty session ID, but it wasn't a >>> appropriate fix. >>> >>> https://bugs.php.net/bug.php?id=68063 >> >> Could you explain a bit more ab

RE: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Zeev Suraski
> -Original Message- > From: Larry Garfield [mailto:la...@garfieldtech.com] > Sent: Wednesday, January 13, 2016 9:46 PM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- > "let's proceed to ideas" > There's an important point we've b

[PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Tom Worster
Hi Stas, Sorry for the follow up but I only noticed this after I woke up this morning. Amusing irony! In this instance, I tried to make a technical argument about language and you picked up the wrong end of the stick and blew up out of proportion because I didn't choose words that make clear me p

RE: [PHP-DEV] [RFC] [Draft] Adopt Code of Conduct

2016-01-14 Thread Zeev Suraski
> -Original Message- > From: Anthony Ferrara [mailto:ircmax...@gmail.com] > Sent: Tuesday, January 12, 2016 12:55 AM > To: David Zuelke > Cc: Stanislav Malyshev ; Pierre Joye > ; Brandon Savage ; > Larry Garfield ; PHP internals > > Subject: Re: [PHP-DEV] [RFC] [Draft] Adopt Code of Condu

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Pierre Joye
On Thu, Jan 14, 2016 at 8:37 PM, Tom Worster wrote: > Hi Stas, > > Sorry for the follow up but I only noticed this after I woke up this > morning. > > Amusing irony! In this instance, I tried to make a technical argument > about language and you picked up the wrong end of the stick and blew up > o

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Tom Worster
On 1/14/16, 9:37 AM, "Pierre Joye" wrote: >I think we get every one point about where we stand, between the >people against a CoC, against a CoC with teeth etc. I wasn't talking about the Code of Conduct. Different topic. >This is getting >nowhere and we are really off topic. > >I would sugg

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Stig Bakken
On Thu, Jan 14, 2016 at 1:18 PM, Zeev Suraski wrote: > > > > -Original Message- > > From: Larry Garfield [mailto:la...@garfieldtech.com] > > Sent: Wednesday, January 13, 2016 9:46 PM > > To: internals@lists.php.net > > Subject: Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -

RE: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread Zeev Suraski
> -Original Message- > From: Tom Worster [mailto:f...@thefsb.org] > Sent: Thursday, January 14, 2016 5:26 PM > To: Pierre Joye > Cc: Stanislav Malyshev ; PHP internals > > Subject: Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- > "let's proceed to ideas" > > On 1/14/16,

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

2016-01-14 Thread Björn Larsson
Den 2016-01-13 kl. 19:48, skrev Thomas Punt: Hi internals! Voting has opened for the inclusion of a digit separator in PHP[1]. Voting ends in one week's time on January 20th. Thanks, Tom [1]: http://wiki.php.net/rfc/number_format_separator Well, if I had

Re: [PHP-DEV] RFC proposal for alternative list syntax

2016-01-14 Thread Julian Rhind
Hi Thanks all for the feedback - I'm posting back to get some "RFC karma" for my newly created wiki account please - so I can post my RFC - username is "julian" Thanks Regards Julian From: Kris Craig Sent: 28 December 2015 18:40 To: Pierre Joye Cc: PHP i

RE: [PHP-DEV] [RFC][VOTE] Number Format Separator

2016-01-14 Thread Thomas Punt
Hi Björn, > Well, if I had a vote it would definetly be +1. A small question > though, why is the voting period only one week (small RFC or)? The RFC is quite simple and short, so I thought a one week voting period would suffice. I'm more than happy to extend this though if people don't think the

Re: [PHP-DEV] [RFC][VOTE] Number Format Separator

2016-01-14 Thread Björn Larsson
Den 2016-01-14 kl. 18:21, skrev Thomas Punt: Hi Björn, Well, if I had a vote it would definetly be +1. A small question though, why is the voting period only one week (small RFC or)? The RFC is quite simple and short, so I thought a one week voting period would suffice. I'm more than happy to

Re: [PHP-DEV] Fixing bug #68063

2016-01-14 Thread Stanislav Malyshev
Hi! > However, previous my fix (Raise warning and return false) was wrong fix. > Therefore, I would like to correct (Provide new session ID and continue) > it in 5.5 also. Does this make sense? Yes, but nit sure if it's for 5.5. It's for Julian to decide, ultimately, but it doesn't look like 5.5

Re: [PHP-DEV] Fixing bug #68063

2016-01-14 Thread Yasuo Ohgaki
Hi Stas, On Fri, Jan 15, 2016 at 4:32 AM, Stanislav Malyshev wrote: > >> However, previous my fix (Raise warning and return false) was wrong fix. >> Therefore, I would like to correct (Provide new session ID and continue) >> it in 5.5 also. Does this make sense? > > Yes, but nit sure if it's for

Re: [PHP-DEV] Fixing bug #68063

2016-01-14 Thread Yasuo Ohgaki
Hi Julien, On Fri, Jan 15, 2016 at 9:10 AM, Yasuo Ohgaki wrote: > > On Fri, Jan 15, 2016 at 4:32 AM, Stanislav Malyshev > wrote: >> >>> However, previous my fix (Raise warning and return false) was wrong fix. >>> Therefore, I would like to correct (Provide new session ID and continue) >>> it in

Re: [PHP-DEV] Re: Internals and Newcomers and the Sidelines -- "let's proceed to ideas"

2016-01-14 Thread David Zuelke
On 14.01.2016, at 13:18, Zeev Suraski wrote: > The way I see it, we don't need to acknowledge having a problem in order to > want to improve. I'm sure that resonates with most developers on this list - > wanting to continuously improve does not mean you're saying that things were > problemati

Re: [PHP-DEV] Re: [RFC] Normalize token_get_all() output (with flag)

2016-01-14 Thread Andrea Faulds
Hi Sara, Sara Golemon wrote: How does this sound? 1. Keep the current RFC basically as is. It's a minor addition to token_get_all() which can be slotted into existing code to improve readability, but offers little advantage beyond that. 2. Make a new extension to prototype this PhpToken class o

Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure

2016-01-14 Thread Stanislav Malyshev
Hi! > I made PR > https://github.com/php/php-src/pull/1721 > > for bug #71038 > https://bugs.php.net/bug.php?id=71038 > > Currently, the patch is written as it should and > breaks compatibility on PHP 5.6. > > To be compatible with PHP 5.6 (PHP 7.0 is OK), > it may ignore read failures returned

Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure

2016-01-14 Thread Yasuo Ohgaki
Hi Stas, On Fri, Jan 15, 2016 at 4:05 PM, Stanislav Malyshev wrote: >> I made PR >> https://github.com/php/php-src/pull/1721 >> >> for bug #71038 >> https://bugs.php.net/bug.php?id=71038 >> >> Currently, the patch is written as it should and >> breaks compatibility on PHP 5.6. >> >> To be compati