Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Jan Ehrhardt
Pierre Joye in php.internals (Fri, 29 May 2015 22:09:46 +0700): >While it really not used (or i did not find any code, >https://github.com/search?utf8=%E2%9C%93&q=imagepstext), we could provide >them using freetype, which works just fine now with t1 fonts. If desired :) You did not find any reposi

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Kalle Sommer Nielsen
Hi Jan 2015-06-21 17:10 GMT+02:00 Jan Ehrhardt : > You did not find any repositories with imagepstext in the title, but > 20487 code results is not nothing: > https://github.com/search?q=imagepstext&type=Code&utf8=%E2%9C%93 Did you look closer to the results yourself? Most of it are example code/

[PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Rasmus Lerdorf
Is it deliberate that we are not providing the parameter types for internal functions via reflection? It seems inconsistent: getParameters()[0]; $param_strlen = (new ReflectionFunction('strlen'))->getParameters()[0]; echo "$param_ustrlen (".$param_ustrlen->hasType().")\n"; echo "$

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Jan Ehrhardt
Kalle Sommer Nielsen in php.internals (Sun, 21 Jun 2015 18:11:24 +0200): >Hi Jan > >2015-06-21 17:10 GMT+02:00 Jan Ehrhardt : >> You did not find any repositories with imagepstext in the title, but >> 20487 code results is not nothing: >> https://github.com/search?q=imagepstext&type=Code&utf8=%E2%9

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Pierre Joye
On Jun 22, 2015 12:23 AM, "Jan Ehrhardt" wrote: > > Kalle Sommer Nielsen in php.internals (Sun, 21 Jun 2015 18:11:24 +0200): > >Hi Jan > > > >2015-06-21 17:10 GMT+02:00 Jan Ehrhardt : > >> You did not find any repositories with imagepstext in the title, but > >> 20487 code results is not nothing:

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Nikita Popov
On Sun, Jun 21, 2015 at 6:26 PM, Rasmus Lerdorf wrote: > Is it deliberate that we are not providing the parameter types for > internal functions via reflection? It seems inconsistent: > > declare(strict_types=1); > function ustrlen(string $str) { } > $param_ustrlen = (new > Refle

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Jan Ehrhardt
Pierre Joye in php.internals (Mon, 22 Jun 2015 00:48:20 +0700): >On Jun 22, 2015 12:23 AM, "Jan Ehrhardt" wrote: >> Yes, I did look at some of the 5115 results for PHP: >> https://github.com/search?l=php&q=imagepstext&type=Code&utf8=%E2%9C%93 >> >> A lot seems like sample code. But it is still a l

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Rasmus Lerdorf
On 06/21/2015 02:44 PM, Nikita Popov wrote: > The difference here is that ustrlen() has an argument type specified in > arginfo, while strlen() triggers an error through > zend_parse_parameters(). We have practically no arginfo-level type > annotations in the standard library. Obviously we can't l

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Kalle Sommer Nielsen
Hi 2015-06-21 20:58 GMT+02:00 Rasmus Lerdorf : > Or we bite the bullet and fix the arginfo everywhere to make it > consistent. It wouldn't be that hard to write a script to generate the > bulk of it. I think fixing arginfo sounds like the right solution, writing a script for it should not be so t

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Rasmus Lerdorf
On 06/21/2015 03:40 PM, Kalle Sommer Nielsen wrote: > Hi > > 2015-06-21 20:58 GMT+02:00 Rasmus Lerdorf : >> Or we bite the bullet and fix the arginfo everywhere to make it >> consistent. It wouldn't be that hard to write a script to generate the >> bulk of it. > > I think fixing arginfo sounds li

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Nikita Popov
On Sun, Jun 21, 2015 at 11:57 PM, Rasmus Lerdorf wrote: > On 06/21/2015 03:40 PM, Kalle Sommer Nielsen wrote: > > Hi > > > > 2015-06-21 20:58 GMT+02:00 Rasmus Lerdorf : > >> Or we bite the bullet and fix the arginfo everywhere to make it > >> consistent. It wouldn't be that hard to write a script

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Stanislav Malyshev
Hi! > The difference here is that ustrlen() has an argument type specified in > arginfo, while strlen() triggers an error through zend_parse_parameters(). > We have practically no arginfo-level type annotations in the standard > library. I think we should start doing this. Of course, some functio

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Stanislav Malyshev
Hi! > Before making more extensive use of arginfo types, I think we should first > do some adjustments to the way they are handled. In particular adding types > means that internal fcalls will take the branch in > http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#3669. As this is hot > code, it

[PHP-DEV] [PROPOSAL] zend_string API changes and additions

2015-06-21 Thread François Laupretre
Hi, I'd like your comments on a PR (https://github.com/php/php-src/pull/1353) I just wrote to propose two changes to the zend_string API. Both are different but, as they apply to the same file, it was easier to merge them the same PR : 1. Suppress the 'persistent' arg from zend_string realloc/ext

Re: [PHP-DEV] hasType() for internal function parameters?

2015-06-21 Thread Rasmus Lerdorf
On 06/21/2015 06:11 PM, Stanislav Malyshev wrote: > Hi! > >> Before making more extensive use of arginfo types, I think we should first >> do some adjustments to the way they are handled. In particular adding types >> means that internal fcalls will take the branch in >> http://lxr.php.net/xref/PH

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Remove T1Lib support (see #69698): NEWS UPGRADING ext/gd/config.m4 ext/gd/config.w32 ext/gd/gd.c ext/gd/php_gd.h

2015-06-21 Thread Pierre Joye
Not even a quote :) I agree to kill it but not in a wild way. As there are usages, a clear migration path should be written. On Jun 22, 2015 1:45 AM, "Jan Ehrhardt" wrote: > Pierre Joye in php.internals (Mon, 22 Jun 2015 00:48:20 +0700): > >On Jun 22, 2015 12:23 AM, "Jan Ehrhardt" wrote: > >> Y