Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Pierre Joye
On Thu, Jan 15, 2015 at 8:56 AM, Dmitry Stogov wrote: > ext/session and ext/json are required by most apps. Right. The question is: Do you see any other we must have before discussing that any further? -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.ph

[PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-15 Thread Joshua Rogers
From: Joshua Rogers --- main/streams/plain_wrapper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c index f52383d..72be0b0 100644 --- a/main/streams/plain_wrapper.c +++ b/main/streams/plain_wrapper.c @@ -669,7 +66

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Dmitry Stogov
I don't know which ones are supported or not. Of course we need some extension to connect to database mysql, mysqli or pdo_mysql. Thanks. Dmitry. On Thu, Jan 15, 2015 at 11:03 AM, Pierre Joye wrote: > On Thu, Jan 15, 2015 at 8:56 AM, Dmitry Stogov wrote: > > ext/session and ext/json are requi

[PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-15 Thread Joshua Rogers
--- main/streams/plain_wrapper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c index f52383d..72be0b0 100644 --- a/main/streams/plain_wrapper.c +++ b/main/streams/plain_wrapper.c @@ -669,7 +669,8 @@ static int php_

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Lester Caine
On 15/01/15 07:26, Pavel Kouřil wrote: > And yesterday I was pointed out one thing: the RFC states "With this > approach, an argument is only accepted if its type is exactly the same > as the parameter.". Does this mean you cannot pass integer to a > function with float argument in the strict mode?

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Pavel Kouřil
On Thu, Jan 15, 2015 at 9:29 AM, Lester Caine wrote: > > One of the nice features of PHP when I started using it all those years > ago was that I did not have to create separate functions different types > did exist in the source data. int/float/num/double and others all needed > separate handling

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Lester Caine
On 15/01/15 08:49, Pavel Kouřil wrote: >> One of the nice features of PHP when I started using it all those years >> > ago was that I did not have to create separate functions different types >> > did exist in the source data. int/float/num/double and others all needed >> > separate handling in c/c

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-15 Thread Xinchen Hui
Hey: On Thu, Jan 15, 2015 at 4:02 PM, Joshua Rogers wrote: > --- > main/streams/plain_wrapper.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c > index f52383d..72be0b0 100644 > --- a/main/streams/plain_wrapp

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Andrea Faulds
Hey Dmitry, > On 15 Jan 2015, at 07:56, Dmitry Stogov wrote: > > ext/session and ext/json are required by most apps. > Actually I stopped attempts to build it when I saw compilation errors in > ext/session. > > Thanks. Dmitry. Oh dear, does ext/session not build? :/ So far I've only built th

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Dmitry Stogov
BTW: why not to wrap big integers into special IS_OBJECT? It would keep everything working out of the box (without BIGINT), and would allow to eliminate more than half of unnecessary changes. In the past we made similar decision for closures. Thanks. Dmitry. On Thu, Jan 15, 2015 at 2:01 PM, Andr

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Andrea Faulds
> On 15 Jan 2015, at 11:01, Andrea Faulds wrote: > > Hey Dmitry, > >> On 15 Jan 2015, at 07:56, Dmitry Stogov wrote: >> >> ext/session and ext/json are required by most apps. >> Actually I stopped attempts to build it when I saw compilation errors in >> ext/session. >> >> Thanks. Dmitry. >

Re: [PHP-DEV] [RFC] Big Integer Support

2015-01-15 Thread Andrea Faulds
Hi Dmitry, > On 15 Jan 2015, at 11:11, Dmitry Stogov wrote: > > BTW: why not to wrap big integers into special IS_OBJECT? > It would keep everything working out of the box (without BIGINT), and would > allow to eliminate more than half of unnecessary changes. > > In the past we made similar de

Re: [PHP-DEV] [PATCH] Check the return value of do_fstat() to avoid error conditions.

2015-01-15 Thread Joshua Rogers
Hi, On 15/01/15 21:49, Xinchen Hui wrote: >do you have a test script to show how to reproduce the error? > > thanks No, I don't. But, if you run `grep -nr do_fstat main/streams/plain_wrapper.c -C3', you can see the result is compared against '0' everywhere else it is used. Thanks, -- -- Josh

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Arvids Godjuks
On 15 Jan 2015, at 0:33, Andrea Faulds : Hi Marcio, > On 14 Jan 2015, at 18:52, Marcio Almada wrote: > > We still have a BC break but now we also have code with **mutant** behavior that might become buggy (do unexpected things) if a `declare` is used. As a language user and a package mainta

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Xinchen Hui
Hey: On Thu, Jan 15, 2015 at 6:42 AM, Andrea Faulds wrote: > Hey Dmitry, > >> On 14 Jan 2015, at 20:40, Dmitry Stogov wrote: >> >> In my opinion, version 0.1 was consistent enough. >> >> handling two different approaches just makes mess... >> >> We have internal function strlen(string $s), and i

RE: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Zeev Suraski
> -Original Message- > From: Andrea Faulds [mailto:a...@ajf.me] > Sent: Thursday, January 15, 2015 12:29 AM > To: Zeev Suraski > Cc: rquadl...@gmail.com; Leigh; PHP Internals List > Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2 > > Hi Zeev, > > > On 14 Jan 2015, at 13:35, Zeev Suraski

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Rowan Collins
Zeev Suraski wrote on 15/01/2015 11:56: PLUS have the ability to radically change how it behaves based on a runtime option. It's so bad that we decided more than a decade ago that we want to refrain from ever introducing such elements to PHP again (e.g. magic_quotes_runtime), and I'm not sure wh

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Stas, > On 14 Jan 2015, at 23:29, Stanislav Malyshev wrote: > > I agree. Being wrong is bad, making a mistake is bad, but having split > personality language and not knowing in which world you are - or even > worse, having to deal with both worlds in the same code and being thrown > back and

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Zeev, > On 15 Jan 2015, at 11:56, Zeev Suraski wrote: > > Andrea, > > I'm not sure what you're basing that assumption on. The incidental > interactions you (or anybody) may have with 'the community', by no way > represent the opinion of the community at large. The vast majority of the > PH

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hey Rowan, > On 15 Jan 2015, at 13:02, Rowan Collins wrote: > > Zeev Suraski wrote on 15/01/2015 11:56: >> PLUS have the ability to radically >> change how it behaves based on a runtime option. It's so bad that we >> decided more than a decade ago that we want to refrain from ever introducing >

RE: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Zeev Suraski
> -Original Message- > From: Andrea Faulds [mailto:a...@ajf.me] > Sent: Thursday, January 15, 2015 4:10 PM > To: Zeev Suraski > Cc: rquadl...@gmail.com; Leigh; PHP Internals List > Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2 > > Hi Zeev, > > Whether or not they are in the majority,

Re: [PHP-DEV] Bugfest

2015-01-15 Thread Pasindu De Silva
Hi Guys What do you think about a folder "bugtests" with tests of all verified bugs. This can allows developers dive into the bug and test quickly I think and also devs fixing others bug might inadvertently fix other bugs. I am currently trying to put together set of bug tests here https://github.

[PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Jan Ehrhardt
Julien Pauli in php.internals (Wed, 14 Jan 2015 18:53:10 +0100): >This will allow more people to help testing both PHP7 (some people may need >some of the top-10 pecl ext to run their apps) and those extensions. Some time ago I had a discussion with Mike Wallner and others about a naming conventio

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Zeev, > On 15 Jan 2015, at 14:32, Zeev Suraski wrote: > >> Whether or not they are in the majority, a very large portion of PHP >> developers would prefer strict typing. In particular, the most vocal ones >> would seem to. There are also a lot of PHP developers who would prefer >> weak typing

Re: [PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Benjamin Eberlei
Not sure how that helps, since you would tag versions anyways using semver, so if there is a master vs next/phpng branch, then they might still result in two tags v1.0 and v2.0 and there is no way to automatically resolve this. On Thu, Jan 15, 2015 at 3:48 PM, Jan Ehrhardt wrote: > Julien Pauli

RE: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Zeev Suraski
> -Original Message- > From: Andrea Faulds [mailto:a...@ajf.me] > Sent: Thursday, January 15, 2015 4:51 PM > To: Zeev Suraski > Cc: rquadl...@gmail.com; Leigh; PHP Internals List > Subject: Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2 > > Hi Zeev, > > > On 15 Jan 2015, at 14:32, Zeev Suraski

Re: [PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Jan Ehrhardt
Benjamin Eberlei in php.internals (Thu, 15 Jan 2015 15:53:43 +0100): >Not sure how that helps, since you would tag versions anyways using semver, >so if there is a master vs next/phpng branch, then they might still result >in two tags v1.0 and v2.0 and there is no way to automatically resolve this.

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 14/01/2015 00:16, Andrea Faulds wrote: Here: https://wiki.php.net/rfc/scalar_type_hints This is a new thread because I’ve made a significant revision to the RFC, so it’d be sensible to separate discussion of the updated RFC from the v0.1 RFC. Reading the thread at this point shows so much

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 15/01/2015 15:10, Zeev Suraski wrote: Except that is not the case for this proposal, which explicitly and deliberately prevents the directive affecting inclusion. The behaviour is impossible to toggle at runtime, unless you’re using some weird extension which lets you edit the flag on the ZEND

Re: [PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Benjamin Eberlei
On Thu, Jan 15, 2015 at 4:11 PM, Jan Ehrhardt wrote: > Benjamin Eberlei in php.internals (Thu, 15 Jan 2015 15:53:43 +0100): > >Not sure how that helps, since you would tag versions anyways using > semver, > >so if there is a master vs next/phpng branch, then they might still result > >in two tags

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Pavel Kouřil
On Thu, Jan 15, 2015 at 4:11 PM, Jordi Boggiano wrote: > > Reading the thread at this point shows so much confusion, it seems half the > people reading the spec misunderstood that the declare() line affects > function calls only and not the API/implementation level. > > As much I think it was a sm

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Zeev, > On 15 Jan 2015, at 15:10, Zeev Suraski wrote: > >> Let’s have a look. From a quick skim over the thread for v0.1: >> >> * In favour of weak types (or the RFC anyway): Adam, Stas, yourself, >> Jordi, >> Pierre, > > You're definitely missing Dmitry (which helped with the RFC) as well

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Niktia Nefedov
On Thu, 15 Jan 2015 14:30:48 +0300, Arvids Godjuks wrote: Hello Andrea! Consider what a mess was register_globals and problems it had, but at least it was a global setting. Declare will work on per file basis, and it will end up even more of a mess. I think PHP development community lea

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Jordi, > On 15 Jan 2015, at 15:11, Jordi Boggiano wrote: > > On 14/01/2015 00:16, Andrea Faulds wrote: >> Here: https://wiki.php.net/rfc/scalar_type_hints >> >> This is a new thread because I’ve made a significant revision to the RFC, so >> it’d be sensible to separate discussion of the upd

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Benjamin Eberlei
On Thu, Jan 15, 2015 at 4:25 PM, Pavel Kouřil wrote: > On Thu, Jan 15, 2015 at 4:11 PM, Jordi Boggiano > wrote: > > > > Reading the thread at this point shows so much confusion, it seems half > the > > people reading the spec misunderstood that the declare() line affects > > function calls only

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Dennis Birkholz
Hello together, I have followed the discussion from the outside (as I am not to vote here) but I am a (not representative) PHP developer. I think the main problem here is that you mix two things up: 1. Scalar type hints for functions 2. Conversion rules >From what I have read, most of you agree

[PHP-DEV] Having issuesto compile cgi_main.c into php 5.6.4

2015-01-15 Thread Marin Perez, Natalia
Hi All, I've been trying to compile the new patch for bug 68618 (http://git.php.net/?p=php-src.git;a=commit;h=f9ad3086693fce680fbe246e4a45aa92edd2ac35 ) into php 5.6.4 . However, I'm getting this error when I try to compile it.. Do you know if there is any dependency I should take care of ?

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Pavel Kouřil
On Thu, Jan 15, 2015 at 4:19 PM, Jordi Boggiano wrote: > > Right now, or with only weak hints, if a library decides to implement strict > typing, they'll skip the scalar hints and check types with something like > the assert lib [1]. A user calling it with random data would *always* get > exceptio

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 15/01/2015 15:25, Pavel Kouřil wrote: The potential issues with this are pretty real, to be honest. Simple things like moving a method from one class to another (let's say to parent or descendant) and getting to another typing context may cause unpredictable behavior if the user forgets to hav

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Pavel, > On 15 Jan 2015, at 15:25, Pavel Kouřil wrote: > > On Thu, Jan 15, 2015 at 4:11 PM, Jordi Boggiano wrote: >> >> Reading the thread at this point shows so much confusion, it seems half the >> people reading the spec misunderstood that the declare() line affects >> function calls only

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 15/01/2015 15:31, Pavel Kouřil wrote: On Thu, Jan 15, 2015 at 4:19 PM, Jordi Boggiano wrote: Right now, or with only weak hints, if a library decides to implement strict typing, they'll skip the scalar hints and check types with something like the assert lib [1]. A user calling it with rand

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 15/01/2015 15:30, Benjamin Eberlei wrote: The potential issues with this are pretty real, to be honest. Simple things like moving a method from one class to another (let's say to parent or descendant) and getting to another typing context may cause unpredictable behavior if the

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Pavel Kouřil
On Thu, Jan 15, 2015 at 4:35 PM, Jordi Boggiano wrote: > > I mean that if someone wants strict typing they won't want to use weak hints > because that would coerce the data before they can verify it and ensure > their code is strictly typed. > > Therefore the best course of action is to have no hi

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Jordi Boggiano
On 15/01/2015 16:01, Pavel Kouřil wrote: On Thu, Jan 15, 2015 at 4:35 PM, Jordi Boggiano wrote: I mean that if someone wants strict typing they won't want to use weak hints because that would coerce the data before they can verify it and ensure their code is strictly typed. Therefore the best

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Michael Wallner
On 15/01/15 15:51, Andrea Faulds wrote: > Let’s have a look. From a quick skim over the thread for v0.1: > > * In favour of weak types (or the RFC anyway): Adam, Stas, yourself, Jordi, > Pierre, Count me in for v0.1. -- Regards, Mike -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrey Andreev
Hi, On Thu, Jan 15, 2015 at 5:31 PM, Pavel Kouřil wrote: > On Thu, Jan 15, 2015 at 4:19 PM, Jordi Boggiano wrote: >> >> Right now, or with only weak hints, if a library decides to implement strict >> typing, they'll skip the scalar hints and check types with something like >> the assert lib [1].

[PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference

2015-01-15 Thread Joshua Rogers
--- ext/phar/zip.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/ext/phar/zip.c b/ext/phar/zip.c index 2a95580..2117b0e 100644 --- a/ext/phar/zip.c +++ b/ext/phar/zip.c @@ -1217,7 +1217,9 @@ int phar_zip_flush(phar_archive_data *phar, char *user_stub, zend_long

[PHP-DEV] RE: Having issuesto compile cgi_main.c into php 5.6.4

2015-01-15 Thread Marin Perez, Natalia
By the way, is there already a package that covers this bug ? (Bug 68618) And I just found out how to recompile with the git version: http://www.phpinternalsbook.com/build_system/building_php.html However, we do need to apply the patch in a number and recompiling php in all of our systems would

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Matteo Beccati
Hi everyone, I am proposing an RFC[1] to remove PHP 4 constructors in PHP 7. If accepted, methods with the same name as their defining class will no longer be recognized as constructors. As noted in the RFC, there are already many situations where we do not recognize these methods as constructor

Re: [PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference

2015-01-15 Thread Michael Wallner
On 15/01/15 17:31, Joshua Rogers wrote: > --- > ext/phar/zip.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/ext/phar/zip.c b/ext/phar/zip.c > index 2a95580..2117b0e 100644 > --- a/ext/phar/zip.c > +++ b/ext/phar/zip.c > @@ -1217,7 +1217,9 @@ int phar_zip_f

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Andrea Faulds
Hey Levi, Upon further thought, I’m not super-enthusiastic about this. As has been pointed out, it’s a pretty serious BC break, whether code can be automatically updated or not. PHP 4 constructors may be obsolete, but an awful lot of code uses them. A better solution, IMO, might be simply to a

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Matthew Leverton
On Tue, Jan 13, 2015 at 6:16 PM, Andrea Faulds wrote: > I’ve made some quite significant changes to my Scalar Type Hints RFC, and > bumped its version to 0.2. > > Here: https://wiki.php.net/rfc/scalar_type_hints > > This is a new thread because I’ve made a significant revision to the RFC, so > i

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hello Mike, > On 15 Jan 2015, at 16:55, Mike Willbanks wrote: > > I actually quite disagree with that statement. I don’t understand. I said "either approach to scalar hints will upset a large portion of the community”. Are you not demonstrating that point, in that you don’t like the strict ap

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Mike Willbanks
Hello Andrea, On Thu, Jan 15, 2015 at 8:09 AM, Andrea Faulds wrote: > Hi Zeev, > > > On 15 Jan 2015, at 11:56, Zeev Suraski wrote: > > > > Andrea, > > > > I'm not sure what you're basing that assumption on. The incidental > > interactions you (or anybody) may have with 'the community', by no w

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Matthew, > On 15 Jan 2015, at 16:59, Matthew Leverton wrote: > > I don't like this at all. I'd prefer raising a new warning type (e.g., > E_AUTOCAST) over this. That error type would cause absolute chaos, unless people decided not to make use of it. Custom error handlers are global and affe

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Mike Willbanks
Hi Andrea, > > > > On 15 Jan 2015, at 16:55, Mike Willbanks wrote: > > > > I actually quite disagree with that statement. > > I don’t understand. I said "either approach to scalar hints will upset a > large portion of the community”. Are you not demonstrating that point, in > that you don’t like

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Mike, > On 15 Jan 2015, at 17:07, Mike Willbanks wrote: > > I may not have described this clearly. If I make a library with a method > that states an int, the declarative syntax now makes me have to take both due > to your earlier comment on that userland would define the condition. This

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Levi Morrison
On Thu, Jan 15, 2015 at 9:55 AM, Andrea Faulds wrote: > Hey Levi, > > Upon further thought, I’m not super-enthusiastic about this. As has been > pointed out, it’s a pretty serious BC break, whether code can be > automatically updated or not. PHP 4 constructors may be obsolete, but an > awful lo

Re: [PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference

2015-01-15 Thread Joshua Rogers
Hi, On 16/01/15 03:41, Michael Wallner wrote: > Looks good. There's another one(2) in /ext/phar/util.c: --snip-- 911if (error) { 912*error = NULL; 913} 914/* seek to start of internal file and read it */ 915if (FAILURE == phar_open_entry_fp(en

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Andrea Faulds
Hey Levi, > On 15 Jan 2015, at 17:16, Levi Morrison wrote: > > On Thu, Jan 15, 2015 at 9:55 AM, Andrea Faulds wrote: >> >> A better solution, IMO, might be simply to add a deprecation notice. This >> would make it obvious during development if you’ve accidentally defined a >> PHP4 constructo

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andi Gutmans
> On Jan 15, 2015, at 6:51 AM, Andrea Faulds wrote: > > > I’m not really sure this is true. I agree that strict types aren’t entirely > in keeping with the “PHP way”. However, there are plenty of people who are > against them not for that reason, but simply because they don’t work well for >

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread S.A.N
Many developers PHP offers dual syntax: 1. Strict function bar(int $num){} 2. Lax function bar((int) $num){} Maybe it makes sense to put this option on the ballot if it passes a vote, it will be possible to put an end to the discus?

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrey Andreev
Hi, On Thu, Jan 15, 2015 at 7:13 PM, Andrea Faulds wrote: > >> Now from that perspective I cannot rely that I am in strict and would have >> to handle the default weak even although I declared in my class that i >> wanted strict mode which only affected the code inside of that file. That's >

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marcio Almada
Hi, I would like to call everyone's attention, specially people contributing directly to this RFC series, to what S.A.N just said: > Many developers PHP offers dual syntax: > > 1. Strict > function bar(int $num){} > > 2. Lax > function bar((int) $num){} > > Maybe it makes sense to put this option

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Andrey, > On 15 Jan 2015, at 19:20, Andrey Andreev wrote: > > Consider this badly designed API: > >declare(strict_typehints=TRUE); > >const MODE_APPEND = 0; >const MODE_TRUNCATE = 1; >const MODE_PREPEND = 2; > >function write_file(string $path, int $mode, string $data)

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
> On 15 Jan 2015, at 19:52, Andrea Faulds wrote: > > Sure, weak typing is much poorer than strict typing for error checking. Does > that mean the user should be prevented from having the choice? > > Are you simply opposed to the idea of weak types in general? Another way to put this: Allow

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Thomas Bley
What about doing both weak and strict with two different syntaxes? public function __construct(string $name, $age as int, $cuteness as float, bool $evil) { string $name // strict $age as int // weak $cuteness as float // weak bool $evil // strict "as" Syntax is taken from SQL92. Regards Thomas

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Mike
Wouldn't this one change render all code in PEAR as broken? Is the gain really worth it? I understand PEAR is basically dead anyways, but for better or worse there is still a boat load of code that is being used from it (much of which lacks decent alternatives), and as other people mentioned s

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marc Bennewitz
Am 14.01.2015 um 23:39 schrieb Andrea Faulds: Hi Marc, On 14 Jan 2015, at 19:01, Marc Bennewitz wrote: 1. Inconsistencies of ZPP and explicit casts In my opinion it should be the same if you call a function in weak type mode and calling a function in strict type mode with explicit cast. B

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marc Bennewitz
Am 15.01.2015 um 20:45 schrieb Marcio Almada: Hi, I would like to call everyone's attention, specially people contributing directly to this RFC series, to what S.A.N just said: Many developers PHP offers dual syntax: 1. Strict function bar(int $num){} 2. Lax function bar((int) $num){} Mayb

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrey Andreev
Hi Andrea, On Thu, Jan 15, 2015 at 9:52 PM, Andrea Faulds wrote: > > Sure, weak typing is much poorer than strict typing for error checking. Does > that mean the user should be prevented from having the choice? > > Are you simply opposed to the idea of weak types in general? > I am opposed to t

Re: [PHP-DEV] [VOTE] Remove deprecated functionality in PHP 7

2015-01-15 Thread Pascal Martin, AFUP
On 02/01/2015 17:04, Nikita Popov wrote: Voting on the removal of deprecated functionality in PHP 7 is now open: https://wiki.php.net/rfc/remove_deprecated_functionality_in_php7#votes As requested, I've split this up in many individual votes, only some particularly trivial function depreca

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Thomas Bley
For me personally, I would use strict hints for private/protected methods and weak hints for public methods. Regards Thomas Thomas Bley wrote on 15.01.2015 21:16: > What about doing both weak and strict with two different syntaxes? > > public function __construct(string $name, $age as int, $c

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Ralf Lang
On 15.01.2015 21:35, Mike wrote: > Wouldn't this one change render all code in PEAR as broken? No. -- Ralf Lang Linux Consultant / Developer Tel.: +49-170-6381563 Mail: l...@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmen

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread S.A.N
The main advantage of the two syntaxes: 1. Strict function bar(int $num){} 2. Weak function bar((int) $num){} Any junior-middle PHP developer, seeing this syntax in the code can understand how it works, without studying the documentation and without your complex conversion tables. Explicit is b

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Thomas Bley
I don't think any junior-middle php developer with understand how "(int)" works. Just make a test and see how many will answer (int)'asd' with 1. Regards Thomas S.A.N wrote on 15.01.2015 22:18: > The main advantage of the two syntaxes: > > 1. Strict > function bar(int $num){} > > 2. Weak > fu

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marcio Almada
S.A.N, > The main advantage of the two syntaxes: > > 1. Strict > function bar(int $num){} > > 2. Weak > function bar((int) $num){} > > Any junior-middle PHP developer, seeing this syntax in the code can > understand how it works, without studying the documentation and without > your complex conver

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Rowan Collins
On 15 January 2015 19:20:27 GMT, Andrey Andreev wrote: >Hi, > >On Thu, Jan 15, 2015 at 7:13 PM, Andrea Faulds wrote: >> >>> Now from that perspective I cannot rely that I am in strict and >would have to handle the default weak even although I declared in my >class that i wanted strict mode which

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Rowan Collins
On 15 January 2015 20:16:54 GMT, Thomas Bley wrote: >What about doing both weak and strict with two different syntaxes? > >public function __construct(string $name, $age as int, $cuteness as >float, bool $evil) { > >string $name // strict >$age as int // weak >$cuteness as float // weak >bool $evi

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Thomas Bley
I think the problem with the current rfc is: test(42); function test(string $a) does test((string)$a); function test(array $a) does not test((array)$a); although casting would be possible. So for consistency we might change the syntax or adapt array/object type hints with casting (BC-break). R

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Christoph Becker
Andrey Andreev wrote: > I like both, I want to use both for different use cases and I don't > see what is it that will be bad about co-existence. > Any library author who wants strictness *will* force it on you, even > if that means writing 3x times more code. Why would a library author want such

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Andrea Faulds
Hi Thomas, > On 15 Jan 2015, at 22:25, Thomas Bley wrote: > > I think the problem with the current rfc is: > > test(42); > function test(string $a) does test((string)$a); > function test(array $a) does not test((array)$a); although casting would be > possible. > > So for consistency we might

Re: [PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Pierre Joye
On Jan 15, 2015 10:24 PM, "Benjamin Eberlei" wrote: > > On Thu, Jan 15, 2015 at 4:11 PM, Jan Ehrhardt wrote: > > > Benjamin Eberlei in php.internals (Thu, 15 Jan 2015 15:53:43 +0100): > > >Not sure how that helps, since you would tag versions anyways using > > semver, > > >so if there is a master

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! > I’m not really sure this is true. I agree that strict types aren’t > entirely in keeping with the “PHP way”. However, there are plenty of > people who are against them not for that reason, but simply because > they don’t work well for them. Plus, I’m not sure strict typing I would say for m

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! >> 1. Strict >> function bar(int $num){} >> >> 2. Lax >> function bar((int) $num){} I would rather have int $num for coercive typing - given that close to 100% of existing typed functions - namely internal functions - mean exactly that and are actually documented with this exact syntax. Yes,

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! > And to hell with the "consistency" argument. Since when did PHP become > *that* concerned about purity and high consistency levels? Call this a The "purity" part should be addressed to strict proponents - it's their purist sensibilities that are offended by converting '23' to 23 ;) As for c

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marcio Almada
Stanislav Malyshev, > I would rather have int $num for coercive typing - given that close to > 100% of existing typed functions - namely internal functions - mean > exactly that and are actually documented with this exact syntax. > [...] > As for strict, maybe it can be int! $num or something like

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! > The hole point (at least for me) for being against `function bar(int > $num){}` to achieve type coercion is that the syntactic equivalent > code `function bar(array $numbers){}` won't do any coercion - (array) > $numbers - because BC break would be too big to handle. > > Having `int|integer

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marcio Almada
> That's how all internal functions work. It looks like you didn't > actually read my argument but just repeated "I want my use case". Sorry, I read all you said and understood it perfectly. > I know you want strict typing. I even proposed the option for it. No, you're wrong. I NEVER EVER said w

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Pierre Joye
On Nov 26, 2014 1:39 AM, "Adam Harvey" wrote: > > On 25 November 2014 at 10:36, Sara Golemon wrote: > > On Tue, Nov 18, 2014 at 3:11 PM, Levi Morrison wrote: > >> https://wiki.php.net/rfc/remove_php4_constructors > >> > > Entirely +1 on removing them in PHP7. > > > > Did we decide on having a 5.

Re: [PHP-DEV] Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Rasmus Lerdorf
On 01/14/2015 06:05 PM, Dan Ackroyd wrote: > On 14 January 2015 at 21:21, Michael Wallner wrote: >> * imagick > > Most of the work was done while it was still called NG: > https://github.com/danack/imagick/tree/phpng . Which means that branch > probably won't work against master as there have bee

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! > detriment of coercive types simply because there is no general > consensus about what "strict" means :) I don't see any place for "consensus" and "non-consensus" here - unless you want to redefine words to have arbitrary meanings so nobody understands you, it is pretty clear what "strict" m

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Marcio Almada
Stanislav Malyshev, >> detriment of coercive types simply because there is no general >> consensus about what "strict" means :) > > I don't see any place for "consensus" and "non-consensus" here - > unless you want to redefine words to have arbitrary meanings so nobody > understands you, it is pre

Re: [PHP-DEV] [RFC] Scalar Type Hints v0.2

2015-01-15 Thread Stanislav Malyshev
Hi! > Even Nikic presented different versions of "strict" proposals on an > old article > > http://nikic.github.io/2012/03/06/Scalar-type-hinting-is-harder-than-you-think.html I don't see "different versions" - I see one version of "strict" which matches my description and which he unequivocally

[PHP-DEV] 回复: [PHP-DEV] Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Wei Dai
Hi, Sorry for the late reply. 在 2015年1月15日 星期四,下午1:21,Rasmus Lerdorf 写道: > On 01/14/2015 07:24 PM, Xinchen Hui wrote: > > On Thu, Jan 15, 2015 at 1:53 AM, Julien Pauli > (mailto:jpa...@php.net)> wrote: > > > I obviously will help porting some of them. > > > > as I remembered, memcached and

Re: [PHP-DEV] Re: Top 10 Pecl extensions PHP7 compatibility

2015-01-15 Thread Pierre Joye
On Jan 16, 2015 7:03 AM, "Pierre Joye" wrote: > > > On Jan 15, 2015 10:24 PM, "Benjamin Eberlei" wrote: > > > > On Thu, Jan 15, 2015 at 4:11 PM, Jan Ehrhardt wrote: > > > > > Benjamin Eberlei in php.internals (Thu, 15 Jan 2015 15:53:43 +0100): > > > >Not sure how that helps, since you would tag

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Adam Harvey
On 15 January 2015 at 17:35, Pierre Joye wrote: > > On Nov 26, 2014 1:39 AM, "Adam Harvey" wrote: >> >> On 25 November 2014 at 10:36, Sara Golemon wrote: >> > On Tue, Nov 18, 2014 at 3:11 PM, Levi Morrison wrote: >> >> https://wiki.php.net/rfc/remove_php4_constructors >> >> >> > Entirely +1 on

Re: [PHP-DEV] [RFC] Remove PHP 4 Constructors

2015-01-15 Thread Pierre Joye
On Fri, Jan 16, 2015 at 8:14 AM, Adam Harvey wrote: > On 15 January 2015 at 17:35, Pierre Joye wrote: >> >> On Nov 26, 2014 1:39 AM, "Adam Harvey" wrote: >>> >>> On 25 November 2014 at 10:36, Sara Golemon wrote: >>> > On Tue, Nov 18, 2014 at 3:11 PM, Levi Morrison wrote: >>> >> https://wiki.ph

Re: [PHP-DEV] [PATCH] Fixed bug #68839 Possible null pointer dereference

2015-01-15 Thread Joshua Rogers
On 16/01/15 03:48, Joshua Rogers wrote: > Should the patch, perhaps be inside the spprintf() function? > That would take care of future problems, too. > > Thoughts? Ok, so, there are many many places where 'error' is not checked against NULL. So I'm going to submit a patch that will fix this in th

Re: [PHP-DEV] [RFC][Vote] Return Types

2015-01-15 Thread Yasuo Ohgaki
Hi Levi, On Wed, Jan 14, 2015 at 6:18 PM, Levi Morrison wrote: > [1]: https://wiki.php.net/rfc/return_types#vote > I read the RFC quickly and could not find closure syntax example. function():array use ($var) {} or function() use ($var): array {} which one will be the syntax? I suppose f

  1   2   >