[PHP-DEV] Re: Fix for #64450

2013-03-22 Thread Anatol Belski
Dmitry, first of all thanks for taking a look :) The issue in a few words - mt_rand reads arguments as long - user pass a float from the userspace - zend_parse_parameters with 'l' casts to long Here's the essential snippet echo mt_rand(0,pow(10,12)); PHP Warning: mt_rand(): max(-727379968) is s

[PHP-DEV] PHP 5.5.0beta1 ZTS broken build

2013-03-22 Thread Remi Collet
While build of 5.5 snapshot works perfectly, beta1 ZTS build is broken In file included from /dev/shm/BUILD/php-5.5.0beta1/ext/tokenizer/tokenizer.c:33:0: /dev/shm/BUILD/php-5.5.0beta1/build-ztscli/Zend/zend_language_parser.h:331:5: error: conflicting types for 'zendparse' In file included from /d

Re: [PHP-DEV] PHP 5.5.0beta1 ZTS broken build

2013-03-22 Thread Pierre Joye
hi, On Fri, Mar 22, 2013 at 10:02 AM, Remi Collet wrote: > While build of 5.5 snapshot works perfectly, beta1 ZTS build is broken > > In file included from > /dev/shm/BUILD/php-5.5.0beta1/ext/tokenizer/tokenizer.c:33:0: > /dev/shm/BUILD/php-5.5.0beta1/build-ztscli/Zend/zend_language_parser.h:331:

[PHP-DEV] Re: Fix for #64450

2013-03-22 Thread Dmitry Stogov
Thanks, now I understood. :) anyway I see a problem. For example on x86_64 double is not always able to keep a long number without precision lost. May be you should receive arguments as zvals and use old or new code depending on input types. BTW: I'm not sure if rand() should be fixed at all. Acc

Re: [PHP-DEV] PHP 5.5.0beta1 ZTS broken build

2013-03-22 Thread Pierre Joye
On Fri, Mar 22, 2013 at 10:06 AM, Pierre Joye wrote: > It seems to be an issue at packaging (bison and co) as as far as I can > tell a checkout works just fine. can you try it too please? By the way, it would be nice if we can follow up this issue at #64461. -- Pierre @pierrejoye -- PHP In

Re: [PHP-DEV] Enable Zend OPCache by default in php.ini-development during beta phase?

2013-03-22 Thread Johannes Schlüter
On Thu, 2013-03-21 at 10:02 -0500, David Soria Parra wrote: > Hi Internals, > > I added the default Zend OPCache settings to php.ini-development and > php.ini-production atm. To have more people testing the opcache I would > like to enable the OPCache in php.ini-development during the beta phase >

Re: [PHP-DEV] Re: Fix for #64450

2013-03-22 Thread Anatol Belski
On Fri, March 22, 2013 10:08, Dmitry Stogov wrote: > Thanks, now I understood. :) > > > anyway I see a problem. For example on x86_64 double is not always able > to keep a long number without precision lost. May be you should receive > arguments as zvals and use old or new code depending on input t

Re: [PHP-DEV] PHP5.5 beta 1 is ready

2013-03-22 Thread Ondřej Surý
Good work everyone, just FYI, there's some non-portable code in Zend OpCache (alpha5 was built just fine), which prevents building of php5 beta1 on non-Linux systems: FreeBSD: https://bugs.php.net/bug.php?id=64490 Hurd i386: https://buildd.debian.org/status/fetch.php?pkg=php5&arch=hurd-i386&ver=5

Re: [PHP-DEV] PHP5.5 beta 1 is ready

2013-03-22 Thread Stas Malyshev
Hi! > just FYI, there's some non-portable code in Zend OpCache (alpha5 was built > just fine), which prevents building of php5 beta1 on non-Linux systems: > > FreeBSD: https://bugs.php.net/bug.php?id=64490 > Hurd i386: > https://buildd.debian.org/status/fetch.php?pkg=php5&arch=hurd-i386&ver=5.5.0

Re: [PHP-DEV] PHP5.5 beta 1 is ready

2013-03-22 Thread Rasmus Lerdorf
On 03/22/2013 02:04 PM, Stas Malyshev wrote: > Hi! > >> just FYI, there's some non-portable code in Zend OpCache (alpha5 was built >> just fine), which prevents building of php5 beta1 on non-Linux systems: >> >> FreeBSD: https://bugs.php.net/bug.php?id=64490 >> Hurd i386: >> https://buildd.debian.