hi Anthony,
On Thu, Jun 28, 2012 at 9:36 PM, Anthony Ferrara wrote:
>> I haven't looked at your patch. But if it has to call another
>> PHP_FuNCTION then it's not good. crypt implementation should be
>> accessible via C.
>
> I've refactored crypt() slightly to expose a PHP_API crypt_execute()
>
Hi internals!
Anthony and me have been looking a lot at the crypt() code recently
and noticed that there are some strange things going on in the buffer
allocations for the sha algorithms.
We did two commits to fix them up a bit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=7e8276ca68fc622124
Additionally, it appears that SHA256/512 are way overallocating the buffer.
For SHA512:
int needed = (sizeof(sha512_salt_prefix) - 1
+ sizeof(sha512_rounds_prefix) + 9 + 1
+ salt_in_len + 1 + 86 + 1);
output = emalloc(needed);
salt[salt_in_len] = '\
Bumping this for a last call RFC.
It will be 2 weeks on Monday since the proposal, and since there's not
been a lot of traffic on the discussion, I'm planning on putting it up
to a vote at that time (unless there are any major objections raised).
So if anyone wants to comment prior to the vote, p
Hello everybody,
It's the first time I write on the internals mailing-list, so let me
introduce myself quickly. I'm a french and canadian CTO, working in Paris.
I lead some PHP projects (mainly the Temma framework and FineFS data
replication system).
I begin to learn PHP's internal engine, backed
On Fri, 2012-06-29 at 16:25 +0200, Amaury Bouchard wrote:
> Back in the real world, we are not cloning objects very often. But, like
> many other syntactic sugars (as the short array syntax), I think it could
> be handy in some circumstances.
Well, arrays are used all over the place. As you said:
2012/6/29 Amaury Bouchard :
> Hello everybody,
>
> It's the first time I write on the internals mailing-list, so let me
> introduce myself quickly. I'm a french and canadian CTO, working in Paris.
> I lead some PHP projects (mainly the Temma framework and FineFS data
> replication system).
> I begi
On 06/29/2012 05:56 AM, Anthony Ferrara wrote:
> Additionally, it appears that SHA256/512 are way overallocating the buffer.
>
> For SHA512:
>
> int needed = (sizeof(sha512_salt_prefix) - 1
> + sizeof(sha512_rounds_prefix) + 9 + 1
> + salt_in_len +
hi,
On Fri, Jun 29, 2012 at 4:19 PM, Anthony Ferrara wrote:
> Bumping this for a last call RFC.
>
> It will be 2 weeks on Monday since the proposal, and since there's not
> been a lot of traffic on the discussion, I'm planning on putting it up
> to a vote at that time (unless there are any major
I also agree with Johannes.
Pierrick
On 29 June 2012 11:01, Patrick ALLAERT wrote:
> 2012/6/29 Amaury Bouchard :
> > Hello everybody,
> >
> > It's the first time I write on the internals mailing-list, so let me
> > introduce myself quickly. I'm a french and canadian CTO, working in
> Paris.
> >
Pierre,
> Quick reminder, it will be -1 from here if it targets 5.4, for all the
> reasons I have been repeatedly explaining.
I've updated the RFC to indicate such (that it's only targeting master (5.5)).
Thanks,
Anthony
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe,
Yes, guys. I totally understand your point. As I said, I had this idea in a
dreamed context (good or bad dream? I don't know).
But still, I think it's intellectually interesting, even if it's not a good
concept for PHP. :-)
Pierrick, I owe you a beer ;-)
Le 29 juin 2012 19:06, "Pierrick Charron"
Hello,
Sorry for the late reply, I was away for a while..
I don't think I have dtrace because I'm on fedora.but i'll research.
If i would want to set a breakpoint after php's initialization process, but
right before the scripts execution, so that after that I can set breakpoints to
emal
No problem when you'll come in Montreal ! If you need any help don't
hesitate.
Pierrick
On 29 June 2012 14:27, Amaury Bouchard wrote:
> Yes, guys. I totally understand your point. As I said, I had this idea in
> a dreamed context (good or bad dream? I don't know).
> But still, I think it's inte
On Fri, 2012-06-29 at 11:47 -0700, Adi Mutu wrote:
> Sorry for the late reply, I was away for a while..
> I don't think I have dtrace because I'm on fedora.but i'll
> research.
As said: Currently only on Solaris, MacOS and BSD. Oracle is porting
DTrace to Oracle Linux. RedHat created Syste
My input is that we should be focusing on features that PHP lacks, or
fixing bugs rather than adding more sugar syntax just for the sake of
adding it.
On Fri, Jun 29, 2012 at 7:47 PM, Pierrick Charron wrote:
> No problem when you'll come in Montreal ! If you need any help don't
> hesitate.
>
> Pi
16 matches
Mail list logo
