Hi!
We would like to announce the first RC of the 5.4.1 version. This is
mainly a bugfix release, including all fixes that did not make the
cut for 5.4.0 and new issues since then. Please test it and notify us of
any problems you may encounter.
The full list of the fixes is as always in the NEWS f
On Fri, 30 Mar 2012 09:04:28 +0200, Stas Malyshev
wrote:
The full list of the fixes is as always in the NEWS file.
I'm afraid it isn't. You did not merge the changes from 5.3 NEWS to 5.4.
I know this is controversial and some people have been committing to both
5.3 and 5.4 NEWS files. H
On Fri, 30 Mar 2012 02:59:29 +0200, Yasuo Ohgaki
wrote:
Since the git work flow in the wiki requires to apply patch to
lowest possible branch, then merge upwards.
This changes old work flow, commit trunk, then merge to
release.
I've committed simple build problem fix to all branches, I thi
hi,
On Fri, Mar 30, 2012 at 8:02 AM, Dirk Haun wrote:
> What's the point of a test that fails (or XFAILs)? Either something is broken
> - then it should be fixed. Or the test makes no sense - then it should be
> removed.
See the archive about the reasons, it has been discussed to death many t
Hi!
> I know this is controversial and some people have been committing to both
> 5.3 and 5.4 NEWS files. However, we have clear guidance for this:
OK, we need to have specific policy on it, because I'm hearing people
having contradictory opinions on that.
> I think it would make more sense to
Hi,
Bug fix can be merged upwards. However,
Are we free to merge feature changes?
Adding new module constant is new feature.
I certainly would like to have it on 5.4 and it's
probably OK for 5.4, but how about 5.3?
So I'm asking procedure before commit.
Before git, we just commit new feature/cha
hi,
On Fri, Mar 30, 2012 at 10:22 AM, Yasuo Ohgaki wrote:
> Bug fix can be merged upwards. However,
> Are we free to merge feature changes?
Generally speaking, no.
> Adding new module constant is new feature.
Not necessary, for example in Curl or openssl, many constants addition
do not chang
On Fri, 2012-03-30 at 17:22 +0900, Yasuo Ohgaki wrote:
> Hi,
>
> Bug fix can be merged upwards. However,
> Are we free to merge feature changes?
>
> Adding new module constant is new feature.
> I certainly would like to have it on 5.4 and it's
> probably OK for 5.4, but how about 5.3?
> So I'm as
Hi
2012/3/30 Pierre Joye :
> hi,
>
> On Fri, Mar 30, 2012 at 10:22 AM, Yasuo Ohgaki wrote:
>
>> Bug fix can be merged upwards. However,
>> Are we free to merge feature changes?
>
>
> Generally speaking, no.
I thought so.
>
>> Adding new module constant is new feature.
>
> Not necessary, for exa
Hello could you add more karma for me on
the following folders :
ext/interbase
ext/pdo_firebird
git push origin
remote: Welcome mariuz.
remote: You have insufficient Karma!
remote: I'm sorry, I cannot allow you to write to
remote: php-src.git/ext/interbase/ibase_service.c
remote: Have a nice
Hi:
On Fri, Mar 30, 2012 at 3:18 AM, marius adrian popa wrote:
> Hello could you add more karma for me on
> the following folders :
> ext/interbase
> ext/pdo_firebird
>
> git push origin
>
> remote: Welcome mariuz.
> remote: You have insufficient Karma!
> remote: I'm sorry, I cannot allow you to
On Fri, Mar 30, 2012 at 12:36 PM, Laruence wrote:
> Hi:
>
> On Fri, Mar 30, 2012 at 3:18 AM, marius adrian popa
> wrote:
> > Hello could you add more karma for me on
> > the following folders :
> > ext/interbase
> > ext/pdo_firebird
> >
> > git push origin
> >
> > remote: Welcome mariuz.
> > rem
hi!
On Fri, Mar 30, 2012 at 12:18 PM, marius adrian popa wrote:
> Hello could you add more karma for me on
> the following folders :
> ext/interbase
You have it already.
> ext/pdo_firebird
done :)
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
--
PHP Int
On 30 March 2012 11:51, Ferenc Kovacs wrote:
> AFAIK mariuz should have karma for the interbase and pdo_firebird exts, see
>
http://svn.php.net/viewvc/SVNROOT/global_avail?view=markup#l176 and
> http://svn.php.net/viewvc/SVNROOT/global_avail?view=markup#l292
> so it is either a bug in the new kar
30 марта 2012 г. 5:55 пользователь Stas Malyshev
написал:
> Hi!
>
>> The difference started from 5.3.9 release when we start to pay *much
>> more* attention to tests.
>> You now can cleanly see failing tests, it's not that huge list, so
>> it's big difference.
>
> Yes, and removing XFAILs would ki
On Fri, Mar 30, 2012 at 8:23 AM, Stas Malyshev wrote:
> Hi!
>
> We would like to announce the first RC of the 5.4.1 version. This will
> be mainly a bugfix version, including all bugfixes that did not make the
> cut for 5.4.0 and new issues since then. Please test it and notify us of
> any problem
On Fri, Mar 30, 2012 at 1:01 PM, Peter Cowburn wrote:
>
>
> On 30 March 2012 11:51, Ferenc Kovacs wrote:
>
>> AFAIK mariuz should have karma for the interbase and pdo_firebird exts,
>> see
>>
> http://svn.php.net/viewvc/SVNROOT/global_avail?view=markup#l176 and
>> http://svn.php.net/viewvc/SVNROO
On 30 March 2012 12:28, Ferenc Kovacs wrote:
>
> nice catch!
>
Thanks. Here's an updated patch since Pierre changed the firebird karma.
Maybe Pierre could apply this? :)
Index: global_avail
===
--- global_avail(revision 32463
On Fri, Mar 30, 2012 at 3:51 AM, Ferenc Kovacs wrote:
>
>
> On Fri, Mar 30, 2012 at 12:36 PM, Laruence wrote:
>>
>> Hi:
>>
>> On Fri, Mar 30, 2012 at 3:18 AM, marius adrian popa
>> wrote:
>> > Hello could you add more karma for me on
>> > the following folders :
>> > ext/interbase
>> > ext/pdo_f
Hi:
Today I make a fix which is only affect 5.3's test . after fix,
I pushed it.
then I do a fake merge(merge -s ours) in 5.4, then when I try to push it..
I got an error:
remote: We cannot figure out what you comitted!
To g...@git.php.net:php-src.git
On 3/29/12 3:00 PM, Alexey Shein wrote:
Hi, internals!
I've got a suggestion about refactoring our tests suite. I'd like to
remove XFAIL institution and mark all failing tests just as FAIL.
XFAIL has a problem that it hides attention from failing tests
depending on not yet fixed bugs (most imp
On 3/30/12 4:20 AM, Alexey Shein wrote:
That's not a noise. See p.1 above. If we don't setup *constant*
notifications, people won't feel pressure.
We do get constant notification of bugs assigned to us. I don't
believe it has any impact on the fix rate.
We need a balance between carrot & s
Hi!
> Does this mean that the 5.4 branch is frozen now and one should ask a
> PM before committing?
No, since we're using git now we have separate release branch for that
(PHP-5.4.1) and RMs be pulling the fixes into it if needed.
Nobody should commit anything to that branch except RMs, of cours
On 3/30/12 12:52 AM, Stas Malyshev wrote:
Hi!
I know this is controversial and some people have been committing to both
5.3 and 5.4 NEWS files. However, we have clear guidance for this:
OK, we need to have specific policy on it, because I'm hearing people
having contradictory opinions on th
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
alex fixed that
Am 30.03.12 15:08, schrieb Laruence:
> Hi: Today I make a fix which is only affect 5.3's test . after
> fix, I pushed it.
>
> then I do a fake merge(merge -s ours) in 5.4, then when I try to
> push it..
>
> I got an error:
>
> re
On 30 March 2012 12:35, Peter Cowburn wrote:
>
> Thanks. Here's an updated patch since Pierre changed the firebird karma.
> Maybe Pierre could apply this? :)
>
Philip has applied the patch, I don't know how often the git server updates
the karma file but you should be able to commit soon Marius.
Hi Stas,
Just FYI.
Following bugs are needed to be fixed before 5.4.1, I think.
https://bugs.php.net/bug.php?id=61526
Which is right, doc or code?
https://bugs.php.net/bug.php?id=61507
This is worse than isset($str[0][0]) issue.
Regards,
--
Yasuo Ohgaki
yohg...@ohgaki.net
--
PHP Internals -
30 марта 2012 г. 22:16 пользователь Christopher Jones
написал:
>
>
> On 3/29/12 3:00 PM, Alexey Shein wrote:
>>
>> Hi, internals!
>>
>> I've got a suggestion about refactoring our tests suite. I'd like to
>> remove XFAIL institution and mark all failing tests just as FAIL.
>> XFAIL has a problem t
28 matches
Mail list logo
