[PHP-DEV] mysqli DBUG_OFF

2011-09-02 Thread Stas Malyshev
Hi! I'm seeing this code in mysqli.c: #ifndef DBUG_OFF REGISTER_LONG_CONSTANT("MYSQLI_DEBUG_TRACE_ENABLED", 0, CONST_CS | CONST_PERSISTENT); #else REGISTER_LONG_CONSTANT("MYSQLI_DEBUG_TRACE_ENABLED", 1, CONST_CS | CONST_PERSISTENT); #endif Is this the right setting? It seems

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-02 Thread Richard Quadling
On 2 September 2011 00:23, Pierre Joye wrote: > It would be nice to get at least a little bit of the context before going in > any kind of arguing. > > For one the failing test happening after my commit was my mistake. It has > nothing to do with the bison versions but me having committed a wrong

RE: [PHP-DEV] PHP 5.3.8 Released!

2011-09-02 Thread Jonathan Bond-Caron
On Wed Aug 24 08:42 AM, Pierre Joye wrote: > Hi Alan, > > the breakage is about is_a with a string as 1st argument, not is_a as > a whole. So yes, it breaks is_a alone is used as validation. > I've been digging more into this: http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_bui

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-09-02 Thread Etienne Kneuss
Hi, On Fri, Sep 2, 2011 at 13:26, Jonathan Bond-Caron wrote: > On Wed Aug 24 08:42 AM, Pierre Joye wrote: > > Hi Alan, > > > > the breakage is about is_a with a string as 1st argument, not is_a as > > a whole. So yes, it breaks is_a alone is used as validation. > > > > I've been digging more int

Re: [PHP-DEV] [VOTE] Weak References

2011-09-02 Thread Nicolas Grekas
How about adding weak maps to this RFC? https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/WeakMap This would be fantastic! Nicolas On Tue, Aug 9, 2011 at 14:55, Lars Schultz wrote: > Am 09.08.2011 14:22, schrieb Arvids Godjuks: > > I have mixed feelings about this proposal

[PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Johannes Schlüter
Hi, when building PHP using (I) ./configure --with-mysql --with-mysqli --with-pdo-mysql you currently get a build using the system default libmysql, usually in /us or such. Alternatively PHP can be built using (II) ./configure --with-mysqli=mysqlnd [...] to build the MySQL extensions using the

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Reindl Harald
please do it we are using mysqlnd on some hundret domains with all sort of php-software since PHP 5.3.3 (the first 5.3 version we used) and thinking back how hard it was to get the fedora-srpm chnaged to build with mysqlnd my opinion is drop the libmysql-support completly you named the main-reaso

Re: [PHP-DEV] 5.4 beta & tests

2011-09-02 Thread Daniel Convissor
Hi Again: On Thu, Sep 01, 2011 at 03:56:57PM -0400, Daniel Convissor wrote: > > http://www.analysisandsolutions.com/php/mysqli.test.failures.tbz > > I didn't modify the tests because they're working for other people. > > Built 5.4 from svn checkout this afternoon using "--with-mysqli=mysqlnd." >

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Sebastian Bergmann
Am 02.09.2011 14:27, schrieb Johannes Schlüter: > I would like to change mysqlnd's config9.m4 file to build PHP using > mysqlnd when being called in form (I). Users would still be able to > enforce libmysql by passing a path, like /usr. PLEASE do it :-) -- Sebastian Bergmann

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 05:27 AM, Johannes Schlüter wrote: > Hi, > > when building PHP using > (I) ./configure --with-mysql --with-mysqli --with-pdo-mysql > you currently get a build using the system default libmysql, usually > in /us or > such. Alternatively PHP can be built using > (II) ./configure --w

Re: [PHP-DEV] PHP 5.3.8 Released!

2011-09-02 Thread Nicolas Grekas
> We already discussed that *in length* the past couple of weeks, the patch > was in fact intentional and we decided not to revert it. > I'm ok with the decision, but what about adding a third argument [, bool $autoload = true ] to is_a() and is_subclass_of(), in order to be consistent with class_

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Mike Willbanks
forgot to include everyone on this response - sorry. when building PHP using >> (I) ./configure --with-mysql --with-mysqli --with-pdo-mysql >> you currently get a build using the system default libmysql, usually >> in /us or >> such. Alternatively PHP can be built using >> (II) ./configure --wit

[PHP-DEV] mysqli tests breaking

2011-09-02 Thread Stas Malyshev
Hi! The situation with mysql tests has improved lately, but I still have the following tests breaking on my system. It would be nice if some of the maintainers would address it as I'm sure it happens to others too. new mysqli() [ext/mysqli/tests/mysqli_connect_oo_warnings.phpt] This one just

Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 19:19, schrieb Stas Malyshev: My environment is Mac OS X, libmysql version 5.1.46 (yes, I know it's old, but that's what is out there in production for many, so we have to support it). Stas, please, always test against the latest and greatest. Otherwise you'll be testing against

Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Anthony Ferrara
> always test against the latest and greatest. Otherwise you'll be > testing against libmysql versions that are not going to see any updates. I would disagree with that statement. Tests should be run against all expected versions of the library. So if 5.1.46 is supported, it should pass the test

Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 11:03 AM, Ulf Wendel wrote: please, always test against the latest and greatest. Otherwise you'll be testing against libmysql versions that are not going to see any updates. 5.1 is still a supported version of Mysql. It is run on many production servers, so I think we must suppo

Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Daniel Convissor
Hi: While I mentioned the following in the "5.4 beta & tests" thread, I'll semi-re-post this here so it doesn't get lost in a thread not specifically about mysql tests. libmysql: http://www.analysisandsolutions.com/php/mysqli.test.failures.libmysql.tbz mysqlnd: http://www.analysisandsolutions.com

Re: [SPAM?]: Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 20:27, schrieb Stas Malyshev: On 9/2/11 11:03 AM, Ulf Wendel wrote: please, always test against the latest and greatest. Otherwise you'll be testing against libmysql versions that are not going to see any updates. 5.1 is still a supported version of Mysql. It is run on many prod

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Christopher Jones
On 09/02/2011 08:32 AM, Rasmus Lerdorf wrote: On 09/02/2011 05:27 AM, Johannes Schlüter wrote: Hi, when building PHP using (I) ./configure --with-mysql --with-mysqli --with-pdo-mysql you currently get a build using the system default libmysql, usually in /us or such. Alternatively PHP can

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 12:17 PM, Christopher Jones wrote: I'm +1 for this. I think the decision& implementation needs to be done before Beta or deferred to trunk. Frankly, I'd be more comfortable with trunk. We have enough trouble with unit tests etc. before the beta, and introducing profound change

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Christopher Jones
On 09/02/2011 12:24 PM, Stas Malyshev wrote: Hi! On 9/2/11 12:17 PM, Christopher Jones wrote: I'm +1 for this. I think the decision& implementation needs to be done before Beta or deferred to trunk. Frankly, I'd be more comfortable with trunk. We have enough trouble with unit tests etc. be

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 21:24, schrieb Stas Malyshev: Hi! On 9/2/11 12:17 PM, Christopher Jones wrote: I'm +1 for this. I think the decision& implementation needs to be done before Beta or deferred to trunk. Frankly, I'd be more comfortable with trunk. We have enough trouble with unit tests etc. before

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-02 Thread Lester Caine
Pierre Joye wrote: Also 1.x is 13 years old, I would very surprised to see anyone still using such an old system with 5.3. It's the version packaged with the current windows build kit ;) -- Lester Caine - G8HFL - Contact - http://lsces.co.uk/wiki/?page=contact L.S.C

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Michael Stowe
+1 and agree that it should be implemented before the beta. On Fri, Sep 2, 2011 at 2:58 PM, Ulf Wendel wrote: > Am 02.09.2011 21:24, schrieb Stas Malyshev: > > Hi! >> >> On 9/2/11 12:17 PM, Christopher Jones wrote: >> >>> I'm +1 for this. I think the decision& implementation needs to be done

Re: [SPAM?]: Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 12:11 PM, Ulf Wendel wrote: This is no more than a friendly request to check against latest and greatest to avoid hitting bugs already fixed in libmysql. Latest GA is 5.1.58, if I'm not mistaken, http://dev.mysql.com/downloads/mysql/5.1.html . You are testing again 5.1.4x. Generall

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Lester Caine
Rasmus Lerdorf wrote: I was actually going to suggest doing this in 5.4 and trunk but didn't get around to writing the email yet. It would still be nice to be able to simply switch off MySQL for those of us who do not have it installed ... It gets annoying when PHP forces the installation of M

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Johannes Schlüter
On Fri, 2011-09-02 at 12:24 -0700, Stas Malyshev wrote: > Hi! > > On 9/2/11 12:17 PM, Christopher Jones wrote: > > I'm +1 for this. I think the decision& implementation needs to be done > > before Beta or deferred to trunk. > > Frankly, I'd be more comfortable with trunk. We have enough trouble

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 1:14 PM, Johannes Schlüter wrote: Looking at the tests we have: Most tests are written with mysqlnd in focus. mysqlnd is what we (Oracle/MySQL) test the most in PHP perspective for quite some time already. By making mysqlnd the default we remove one moving piece out of the test equ

Re: [SPAM?]: Re: [SPAM?]: Re: [PHP-DEV] mysqli tests breaking

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 22:07, schrieb Stas Malyshev: Hi! On 9/2/11 12:11 PM, Ulf Wendel wrote: This is no more than a friendly request to check against latest and greatest to avoid hitting bugs already fixed in libmysql. Latest GA is 5.1.58, if I'm not mistaken, http://dev.mysql.com/downloads/mysql/5.1.

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ferenc Kovacs
2011/9/2 Stas Malyshev : > Hi! > > On 9/2/11 1:14 PM, Johannes Schlüter wrote: >> >> Looking at the tests we have: Most tests are written with mysqlnd in >> focus. mysqlnd is what we (Oracle/MySQL) test the most in PHP >> perspective for quite some time already. By making mysqlnd the default >> we

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 1:41 PM, Ferenc Kovacs wrote: I think you missed the referenced [1]: [1] Yes, we will still allow building with libmysql and we will fix bugs reported there and we will verify it works but focus on mysqlnd, as we're actually handling it already I did not miss it - I do not see w

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 22:17, schrieb Lester Caine: Rasmus Lerdorf wrote: I was actually going to suggest doing this in 5.4 and trunk but didn't get around to writing the email yet. It would still be nice to be able to simply switch off MySQL for those of us who do not have it installed ... It gets ann

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ferenc Kovacs
On Fri, Sep 2, 2011 at 10:44 PM, Stas Malyshev wrote: > Hi! > > On 9/2/11 1:41 PM, Ferenc Kovacs wrote: >> >> I think you missed the referenced [1]: >> >> [1] Yes, we will still allow building with libmysql and we will fix bugs >> reported there and we will verify it works but focus on mysqlnd, as

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Johannes Schlüter
On Fri, 2011-09-02 at 22:48 +0200, Ferenc Kovacs wrote: > On Fri, Sep 2, 2011 at 10:44 PM, Stas Malyshev wrote: > > Hi! > > > > On 9/2/11 1:41 PM, Ferenc Kovacs wrote: > >> > >> I think you missed the referenced [1]: > >> > >> [1] Yes, we will still allow building with libmysql and we will fix bug

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 22:57, schrieb Johannes Schlüter: On Fri, 2011-09-02 at 22:48 +0200, Ferenc Kovacs wrote: On Fri, Sep 2, 2011 at 10:44 PM, Stas Malyshev wrote: Hi! On 9/2/11 1:41 PM, Ferenc Kovacs wrote: I think you missed the referenced [1]: [1] Yes, we will still allow building with libmys

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 1:57 PM, Johannes Schlüter wrote: maybe supporting IE6 would be a good metaphor: you could say that you support every browser equally, or you could say that you write your stuff for the modern browsers and tests it against IE6 and fix where necessary. Johannes, is this what you had

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 23:20, schrieb Stas Malyshev: Hi! On 9/2/11 1:57 PM, Johannes Schlüter wrote: maybe supporting IE6 would be a good metaphor: you could say that you support every browser equally, or you could say that you write your stuff for the modern browsers and tests it against IE6 and fix wh

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 2:12 PM, Ulf Wendel wrote: I think, such a statement is quite a big step towards your test concerns, Stas. Ultimately, I still don't get what you (Stas) are after with the test discussion. Have I missed any of your worries? My concerns is first and foremost to have unit tests pas

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Lester Caine
Ulf Wendel wrote: Am 02.09.2011 22:17, schrieb Lester Caine: Rasmus Lerdorf wrote: I was actually going to suggest doing this in 5.4 and trunk but didn't get around to writing the email yet. It would still be nice to be able to simply switch off MySQL for those of us who do not have it instal

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Ulf Wendel
Am 02.09.2011 23:30, schrieb Stas Malyshev: Hi! On 9/2/11 2:12 PM, Ulf Wendel wrote: I think, such a statement is quite a big step towards your test concerns, Stas. Ultimately, I still don't get what you (Stas) are after with the test discussion. Have I missed any of your worries? My concerns

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-02 Thread Pierre Joye
no, read the mails pls... On Fri, Sep 2, 2011 at 10:02 PM, Lester Caine wrote: > Pierre Joye wrote: >> >> Also 1.x is 13 years old, I would very surprised to see anyone still using >> such an old system with 5.3. > > It's the version packaged with the current windows build kit ;) > > -- > Lester

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Pierre Joye
2011/9/2 Stas Malyshev : > Hi! > > On 9/2/11 1:14 PM, Johannes Schlüter wrote: >> >> Looking at the tests we have: Most tests are written with mysqlnd in >> focus. mysqlnd is what we (Oracle/MySQL) test the most in PHP >> perspective for quite some time already. By making mysqlnd the default >> we

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 2:51 PM, Ulf Wendel wrote: if you are really concerned about tests, aren't you a bit late, are all the 5.3 releases to be considered instable. I mean, they use the same The fact that 5.3 had so many failing tests is nothing good, but we can't fix the past. We can try to make it

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-02 Thread Lester Caine
Pierre Joye wrote: no, read the mails pls... >> Also 1.x is 13 years old, I would very surprised to see anyone still using >> such an old system with 5.3. > > It's the version packaged with the current windows build kit;) ? http://windows.php.net/downloads/php-sdk/php-sdk-binary-tools-20

Re: [PHP-DEV] Re: drop bison 1.x?

2011-09-02 Thread Pierre Joye
It uses now bison 2.4, you can replace it with the gnu win32 version by deleting the old one and put the bison zip archive in php-sdk\ (share and bin). The SDKs file are updated on release only, that's why it is still 1.x there. On Sat, Sep 3, 2011 at 12:20 AM, Lester Caine wrote: > Pierre Joye w

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 12:24 PM, Stas Malyshev wrote: > Hi! > > On 9/2/11 12:17 PM, Christopher Jones wrote: >> I'm +1 for this. I think the decision& implementation needs to be done >> before Beta or deferred to trunk. > > Frankly, I'd be more comfortable with trunk. We have enough trouble with > unit

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 01:17 PM, Lester Caine wrote: > Rasmus Lerdorf wrote: >> I was actually going to suggest doing this in 5.4 and trunk but didn't >> get around to writing the email yet. > > It would still be nice to be able to simply switch off MySQL for those > of us who do not have it installed ...

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 4:45 PM, Rasmus Lerdorf wrote: One of the goals before the beta is to get to 0 failed tests for a common build. Unless you simply skip all the failing libmysql tests, that's going to be hard to do unless we move the default to a more robust library. That doesn't mean we shouldn't f

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 05:56 PM, Stas Malyshev wrote: > Hi! > > On 9/2/11 4:45 PM, Rasmus Lerdorf wrote: >> One of the goals before the beta is to get to 0 failed tests for a >> common build. Unless you simply skip all the failing libmysql tests, >> that's going to be hard to do unless we move the default

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 05:56 PM, Stas Malyshev wrote: > Hi! > > On 9/2/11 4:45 PM, Rasmus Lerdorf wrote: >> One of the goals before the beta is to get to 0 failed tests for a >> common build. Unless you simply skip all the failing libmysql tests, >> that's going to be hard to do unless we move the default

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Stas Malyshev
Hi! On 9/2/11 6:02 PM, Rasmus Lerdorf wrote: Well, we are not trying to get to 0 failed tests in all permutations of all extensions on all platforms. We are trying to get to 0 failed tests on a common-case build using defaults and common extensions. Given that, changing a default has an impact o

[PHP-DEV] ext/pcre/tests/006.phpt

2011-09-02 Thread Ferenc Kovacs
Hi, I started debugging why ext/pcre/tests/006.phpt fails, I've pinpointed the guilty commit: http://svn.php.net/viewvc?view=revision&revision=311323 it seems that the behavior was depending on the backtrack limit, but I'm not sure what to do with the test. should I simply delete? or can we change

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Reindl Harald
Am 03.09.2011 03:08, schrieb Stas Malyshev: > Hi! > > On 9/2/11 6:02 PM, Rasmus Lerdorf wrote: >> Well, we are not trying to get to 0 failed tests in all permutations of >> all extensions on all platforms. We are trying to get to 0 failed tests >> on a common-case build using defaults and common

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Daniel Convissor
Hi Folks: On Fri, Sep 02, 2011 at 06:08:59PM -0700, Stas Malyshev wrote: > we'd do better skipping out problematic tests (which > I also think is wrong, especially if these tests discover API > incompatibility which shouldn't even exist between mysqlnd and > libmysql) than just ignore the failures

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Rasmus Lerdorf
On 09/02/2011 06:08 PM, Stas Malyshev wrote: > Hi! > > On 9/2/11 6:02 PM, Rasmus Lerdorf wrote: >> Well, we are not trying to get to 0 failed tests in all permutations of >> all extensions on all platforms. We are trying to get to 0 failed tests >> on a common-case build using defaults and common

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Lester Caine
Rasmus Lerdorf wrote: On 09/02/2011 01:17 PM, Lester Caine wrote: > Rasmus Lerdorf wrote: >> I was actually going to suggest doing this in 5.4 and trunk but didn't >> get around to writing the email yet. > > It would still be nice to be able to simply switch off MySQL for those > of us wh

Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4

2011-09-02 Thread Lester Caine
Stas Malyshev wrote: libmysql *is* the common case build and the one most people would be running in production, at least as far as I see around. In the words of wikipedia - provide proof. If this is the case then why is mysqlnd loaded by default? Even if we do not have MySQL installed. -- Le