Hey Matt,
Thanks for posting, sorry for not having a chance to reply to this sooner.
Maybe couple things from the patch,
+/* To save initial string length after scanning to first variable,
CG(doc_comment_len) can be reused */
+#define double_quotes_scanned_len CG(doc_comment_len)
+
(mino
Hi Matt,
I wasn't able to look into all details of the patch, but in general I
like it, as it fixes bugs and makes scanner smaller. I think you can
commit it.
Although this patch doesn't fix the EOF handling related to mmap().
Thanks. Dmitry.
Matt Wilmas wrote:
Hi guys,
- Original Mes
PHP 6 Bug Database summary - http://bugs.php.net/
Num Status Summary (75 total -- which includes 34 feature requests)
===[Apache related]===
47061 Open User not logged under Apache
===[A
PHP 5 Bug Database summary - http://bugs.php.net/
Num Status Summary (1327 total -- which includes 862 feature requests)
===[*XML functions]===
48095 Verified Load RDF Format Error
===[Apach
Hi,
On Mon, May 4, 2009 at 9:36 AM, shire wrote:
> Regarding the ZEND_MMAP_AHEAD issue and the temp. fix that Dmitry put in we
> need to find a solution to that, perhaps I can play with that this week too
> as I think I'm seeing some related issues in my testing of 5.3. Essentially
> we abuse ZEN
On 04.05.2009, at 00:59, Pierre Joye wrote:
hi Lukas,
The re3c bug (8k bug) for one.
yeah .. well it seems we will not have a fix for this (and a release
today). however johannes and I both agree that testers need to get
their hands on a more recent version of our code, since RC1 was
Arnaud Le Blanc wrote:
Hi,
On Mon, May 4, 2009 at 9:36 AM, shire wrote:
Regarding the ZEND_MMAP_AHEAD issue and the temp. fix that Dmitry put in we
need to find a solution to that, perhaps I can play with that this week too
as I think I'm seeing some related issues in my testing of 5.3. Essent
On Mon, May 4, 2009 at 5:51 PM, shire wrote:
> Arnaud Le Blanc wrote:
>>
>> Hi,
>> On Mon, May 4, 2009 at 9:36 AM, shire wrote:
>>>
>>> Regarding the ZEND_MMAP_AHEAD issue and the temp. fix that Dmitry put in
>>> we
>>> need to find a solution to that, perhaps I can play with that this week
>>> t
Hi,
Would it not easier and better to have mysqlnd as default backend for
the mysql extensions (pdo, mysqli and mysql) when the configure option
are used without value? I can already imagine the maintenance pains
and the debugging nightmare for our users while working with a buggy
libmysql instead
Hi Brian,
- Original Message -
From: "shire"
Sent: Monday, May 04, 2009
Hey Matt,
Thanks for posting, sorry for not having a chance to reply to this sooner.
Maybe couple things from the patch,
+/* To save initial string length after scanning to first variable,
CG(doc_comment_len) c
Hi Dmitry,
- Original Message -
From: "Dmitry Stogov"
Sent: Monday, May 04, 2009
Hi Matt,
I wasn't able to look into all details of the patch, but in general I like
it, as it fixes bugs and makes scanner smaller. I think you can commit it.
OK, you mean before the freeze for RC2...?
Pierre Joye kirjoitti:
Hi,
Would it not easier and better to have mysqlnd as default backend for
the mysql extensions (pdo, mysqli and mysql) when the configure option
are used without value? I can already imagine the maintenance pains
and the debugging nightmare for our users while working with
Hey Matt,
Matt Wilmas wrote:
+/* To save initial string length after scanning to first variable,
CG(doc_comment_len) can be reused */
+#define double_quotes_scanned_len CG(doc_comment_len)
+
(minor) Maybe we should rename this var if we're going to use it for
other
purposes, this doesn't rea
On 04.05.2009, at 20:31, Pierre Joye wrote:
Hi,
Would it not easier and better to have mysqlnd as default backend for
the mysql extensions (pdo, mysqli and mysql) when the configure option
are used without value? I can already imagine the maintenance pains
and the debugging nightmare for our u
Hi Brian,
- Original Message -
From: "shire"
Sent: Monday, May 04, 2009
Hey Matt,
Matt Wilmas wrote:
+/* To save initial string length after scanning to first variable,
CG(doc_comment_len) can be reused */
+#define double_quotes_scanned_len CG(doc_comment_len)
+
(minor) Maybe we s
Matt Wilmas wrote:
Hi Brian,
- Original Message -
From: "shire"
Sent: Monday, May 04, 2009
Hey Matt,
Matt Wilmas wrote:
+/* To save initial string length after scanning to first variable,
CG(doc_comment_len) can be reused */
+#define double_quotes_scanned_len CG(doc_comment_len)
+
Matt Wilmas wrote:
Gotcha. If something changes, YYFILL -- or something to handle what
needs to be done -- could just be added to the manual parts as
necessary, right?
Sorry forget to reply on this one, but yeah we'd have to do a manual call to
YYFILL or a check or whatever we come up with w
Hi Brian,
- Original Message -
From: "shire"
Sent: Monday, May 04, 2009
Matt Wilmas wrote:
[...]
How about this?
#define SET_DOUBLE_QUOTES_SCANNED_LENGTH(len) CG(doc_comment_len) = (len)
#define GET_DOUBLE_QUOTES_SCANNED_LENGTH() CG(doc_comment_len)
Sure, works for me ;-)
Cool. :
This commit http://news.php.net/php.cvs/57541 broke about every test which
triggers thes deprecation messages.
--Jani
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
2009/5/5 Jani Taskinen :
> This commit http://news.php.net/php.cvs/57541 broke about every test which
> triggers thes deprecation messages.
Care to elaborate? I've fixed those tests I could see failing for me
in the log from run-tests, sure some may have gone through as not
every test runs on Wind
20 matches
Mail list logo
