RE: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Dmitry Stogov
Hi Sara, > -Original Message- > From: Sara Golemon [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 17, 2007 11:36 PM > To: Dmitry Stogov > Cc: internals@lists.php.net; Andrei Zmievski; Andi Gutmans > Subject: Re: [PHP-DEV] Giving Globals the CV treatment [WAS: > Runtime JIT Proposal

Re: [PHP-DEV] Comments on PHP security

2007-01-18 Thread Alain Williams
On Wed, Jan 17, 2007 at 11:18:50AM -0800, Stanislav Malyshev wrote: > >Which functions am I forgetting? > > All using php_stream_open*. I see 38 files in the php source tree using > this function. You probably would have to go to each of them and change > each instance to support your flag. That

Re: [PHP-DEV] Comments on PHP security

2007-01-18 Thread Stanislav Malyshev
I am with Arnold on this one. Implement a patch that fixes the source of most of the problems, tidy the rest at leisure. Better to get an effective fix quickly than wait forever for perfection. Security solution can't plug 90% of holes and then leave the rest for leisure... Effective fix means

Re: [PHP-DEV] Comments on PHP security

2007-01-18 Thread Alain Williams
On Thu, Jan 18, 2007 at 01:13:51AM -0800, Stanislav Malyshev wrote: > >I am with Arnold on this one. Implement a patch that fixes the source of > >most of > >the problems, tidy the rest at leisure. Better to get an effective fix > >quickly > >than wait forever for perfection. > > Security soluti

[PHP-DEV] Problems on PHP5 object instantiation

2007-01-18 Thread Jingcheng Zhang
Hi, I'm now trying OOP in PHP5, and enjoy it very much. However, as we know PHP5 does not allow compile-time instantiation, so when I try this script: it ends up with a parse error, while in Java it works naturally. I wonder whether there are some difficulties on implementing this feature, o

Re: [PHP-DEV] Comments on PHP security

2007-01-18 Thread Arnold Daniels
I vote 1 as well. The problem only occurs if the function is used insecurely by the developer. There are a few functions which are implemented insecurely a lot. Since these holes are always the same, hackers will try to use this. So fixing 90% of the problems would not leave the hacker with enough

Re: [PHP-DEV] Problems on PHP5 object instantiation

2007-01-18 Thread Antony Dovgal
On 01/18/2007 05:06 PM, Jingcheng Zhang wrote: Hi, I'm now trying OOP in PHP5, and enjoy it very much. However, as we know PHP5 does not allow compile-time instantiation, so when I try this script: Class properties are initialized in compile time, therefore they cannot be initialized wit

[PHP-DEV] CVS Account Request: cbaughman

2007-01-18 Thread Christopher Baughman
I would like to help maintain documentation, I have noticed many unanswered bugs, and have time to contribute to a project I have come to enjoy. I would also like to possibly help with developing the runtime. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http:/

Re: [PHP-DEV] CVS Account Request: cbaughman

2007-01-18 Thread Antony Dovgal
On 01/18/2007 06:23 PM, Christopher Baughman wrote: I would like to help maintain documentation, I have noticed many unanswered bugs, You don't need a CVS account to start answering them =) and have time to contribute to a project I have come to enjoy. I would also like to possibly help with d

[PHP-DEV] CVS Account Request: tsuruoka

2007-01-18 Thread TSURUOKA Naoya
commit Crypt_DSA(http://pear.php.net/pepr/pepr-proposal-show.php?id=467) to cvs.php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] CVS Account Request: cbaughman

2007-01-18 Thread Sean Coates
Antony Dovgal wrote: > On 01/18/2007 06:23 PM, Christopher Baughman wrote: >> I would like to help maintain documentation, I have noticed many >> unanswered bugs, > > You don't need a CVS account to start answering them =) I think he meant answer-by-patching. In any case, feel free to send patch

Re: [PHP-DEV] allow_url_fopen / allow_url_include and fine grained control

2007-01-18 Thread David Zülke
Sara, I assume this would also mean all userland stream wrappers become is_url=1? Anyway, +1. David Am 17.01.2007 um 02:07 schrieb Sara Golemon: allow_url_include has been bashed lately for being "not good enough", and there is a kernel of truth to that, though where the ultimate bla

Re: [PHP-DEV] allow_url_fopen / allow_url_include and fine grained control

2007-01-18 Thread Sara Golemon
I assume this would also mean all userland stream wrappers become is_url=1? Anyway, +1. This patch, by itself, doesn't affect the is_urlness of userspace wrappers. Whether or not we change their designation is up to a separate concensus (I'm in favor of it for the record). Funnily enough th

Re: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Sara Golemon
Could you also run Zend/bench.php to check that patch doesn't slowdown local fetches. I think the patch can be commited into HEAD (not into PHP_5_2), but I would prefer collect all performance patches and commit them into PHP_5_3 and HEAD together. without with simple

Re: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Ilia Alshanetsky
The optimizer already does most of those things, so I think things like that are best left there rather then being done in the core. On 18-Jan-07, at 4:34 PM, Sara Golemon wrote: Could you also run Zend/bench.php to check that patch doesn't slowdown local fetches. I think the patch can be

RE: [PHP-DEV] Comments on PHP security

2007-01-18 Thread Andi Gutmans
I haven't seen the patch yet but my concern would be with resources which have already been opened. Unless you guys clean that up in between requests it can be very dangerous as I doubt Linux re-verify's permissions when those are accessed. In any case, I'd be happy to review and might be complet

[PHP-DEV] PHP 5.2.1RC3 Released

2007-01-18 Thread Ilia Alshanetsky
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The 2nd release candidate for PHP 5.2.1 is now available for download. The tarballs can be found here: http://downloads.php.net/ilia/php-5.2.1RC3.tar.bz2 (d3889eda8c3471ce7cf2adb35a4de736) http://downloads.php.net/ilia/php-5.2.1RC3.tar.gz (c5b

Re: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Sara Golemon
[EMAIL PROTECTED] wrote: The optimizer already does most of those things, so I think things like that are best left there rather then being done in the core. How exactly does the (by "the" I presume you mean "your") optimizer manage to turn $_POST['foo'] into a single CV based DIM fetch? The

Re: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Ilia Alshanetsky
On 18-Jan-07, at 9:12 PM, Sara Golemon wrote: Or do you mean that they turn: ZEND_FETCH_R $0 'GLOBALS' (global) ZEND_FETCH_DIM_R $1 $0 'foo' Into: ZEND_FETCH_R $1 'foo' (global) Yup. And: ZEND_BEGIN_SILENCE ZEND_FETCH_R $0 'foo' (local) ZEND_FETCH_DIM_R $1 $0 'bar' ZEND_END_SILENCE Into: Z

RE: [PHP-DEV] Giving Globals the CV treatment [WAS: Runtime JIT Proposals]

2007-01-18 Thread Dmitry Stogov
1% is a measure mistake, so patch is OK. Dmitry. > -Original Message- > From: Sara Golemon [mailto:[EMAIL PROTECTED] > Sent: Friday, January 19, 2007 12:35 AM > To: Dmitry Stogov > Cc: internals@lists.php.net; 'Andrei Zmievski'; 'Andi Gutmans' > Subject: Re: [PHP-DEV] Giving Globals the