[PHP-DEV] CVS Account Request: videinfra

2006-12-13 Thread Roman Roan
Maintainer of Pear/Validate/Validate_LV package Reference: Amir Mohammad -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] [PATCH] Some small optimizations

2006-12-13 Thread Matt Wilmas
Hi, Here are patches to use Brian Shire's optimizations (applied by Ilia to 5.2 the other day) in a couple more places, and for HEAD. In Unicode mode, concat_function() is up to 20%+ faster! (Probably because zend_make_unicode_zval() calls TSRMLS_FETCH(); so not so much with non-ZTS I guess.

Re: [PHP-DEV] [PATCH] New, optimized is_numeric_string, and other number stuff

2006-12-13 Thread Ilia Alshanetsky
Given where we are in the release process i think it is a perfect time to try this patch. If it does not work out we have at least two RCs to revert it on, nothing would change by having us delay this until 5.2.2, expect a slightly slower 5.2.1. I've done a detailed review of the patch yest

Re: [PHP-DEV] [PATCH] Some small optimizations

2006-12-13 Thread Ilia Alshanetsky
Matt, The ext/* patches were applied to 5.2, I'll commit the Zend/ ones once we have an agreement on the previous patch. On 13-Dec-06, at 8:22 AM, Matt Wilmas wrote: Hi, Here are patches to use Brian Shire's optimizations (applied by Ilia to 5.2 the other day) in a couple more places, a

Re: [PHP-DEV] patch: remove unneeded strlen() check from php_addcslashes

2006-12-13 Thread Ilia Alshanetsky
This code is a fallback in instances where length is not know, which is something that may happen. Given that this is an API function I don't think we can make this change as it may break out-of-php code that relies on this functionality. I really don't think you'll see any visible gain by

Re: [PHP-DEV] patch: remove unneeded strlen() check from php_addcslashes

2006-12-13 Thread Ilia Alshanetsky
Nevermind the previous e-mail, I see that strlen() is already done inside safe_emalloc(), patch was applied, thanks. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] New, optimized is_numeric_string, and other number stuff

2006-12-13 Thread Matt Wilmas
Hi Ilia, I was kinda thinking the same thing, about having 2 RCs and such to see if any problems were found. Though I try to be very, very careful not to screw things up. ;-) Just wanted to let you know, I made a minor update to the patch since you first saw it yesterday. Realized part of the i

Re: [PHP-DEV] [PATCH] Some small optimizations

2006-12-13 Thread Ilia Alshanetsky
On 13-Dec-06, at 11:54 AM, Andrei Zmievski wrote: Which previous patch? From Matt? The one for is_numeric_string() Ilia Alshanetsky -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Default INI values for deprecated directives

2006-12-13 Thread Hannes Magnusson
Hi all I just noticed that we have magic_quotes_gpc, register_long_arrays and allow_call_time_pass_reference enabled by default (php.ini-dist/no ini). All three have been removed in HEAD (magic_quotes_gpc and register_long_arrays even raise E_CORE_ERROR) so I was wondering if it isn't time to di

[PHP-DEV] Segmentation Fault

2006-12-13 Thread Richard Morris
Hello all, I was told this might be a better list to ask this question... I was experimenting with the imap_* library functions trying to see if I could get a PHP script to access a folder on our IMAP server and I ran into a problem. I was trying to get a simple script to work which simply o

Re: [PHP-DEV] [PATCH] Some small optimizations

2006-12-13 Thread Andrei Zmievski
Which previous patch? From Matt? -Andrei On Dec 13, 2006, at 7:33 AM, Ilia Alshanetsky wrote: Matt, The ext/* patches were applied to 5.2, I'll commit the Zend/ ones once we have an agreement on the previous patch. On 13-Dec-06, at 8:22 AM, Matt Wilmas wrote: Hi, Here are patches to us

[PHP-DEV] CVS Account Request: saltybeagle

2006-12-13 Thread Brett Bieber
PEAR package... http://pear.php.net/pepr/pepr-proposal-show.php?id=461 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] mail() logging for PHP

2006-12-13 Thread Ilia Alshanetsky
Is there any interest in adding support for logging of mail() calls and/or adding options that allow identification of who sent the e-mail. I've wrote a quick patch that enables this functionality via two ini settings controllable via php.ini or per-virtual host. The first option, mail.add_

Re: [PHP-DEV] mail() logging for PHP

2006-12-13 Thread Stut
Ilia Alshanetsky wrote: Is there any interest in adding support for logging of mail() calls and/or adding options that allow identification of who sent the e-mail. I've wrote a quick patch that enables this functionality via two ini settings controllable via php.ini or per-virtual host. The

Re: [PHP-DEV] mail() logging for PHP

2006-12-13 Thread Ilia Alshanetsky
On 13-Dec-06, at 5:12 PM, Stut wrote: Ilia Alshanetsky wrote: Is there any interest in adding support for logging of mail() calls and/or adding options that allow identification of who sent the e-mail. I've wrote a quick patch that enables this functionality via two ini settings controlla

Re: [PHP-DEV] mail() logging for PHP

2006-12-13 Thread Stut
Ilia Alshanetsky wrote: On 13-Dec-06, at 5:12 PM, Stut wrote: Ilia Alshanetsky wrote: Is there any interest in adding support for logging of mail() calls and/or adding options that allow identification of who sent the e-mail. I've wrote a quick patch that enables this functionality via two in

Re: [PHP-DEV] mail() logging for PHP

2006-12-13 Thread Ilia Alshanetsky
On 13-Dec-06, at 5:53 PM, Stut wrote: I'm thinking about this from an ISP point of view... we get a lot of abuse reports because people have poorly written form handlers. It would be great if we could have PHP insert the full URL, domain name included, in the mail headers for anything it

[PHP-DEV] [PATCH] 1 small optimization and 1 cleanup

2006-12-13 Thread Ron Korving
Hi, Below are 2 patches for the latest 5.2. The first patch rewrites pcre_get_compiled_regex_ex() in ext/pcre/php_pcre.c from line 417, saving up to 3 comparison statements (?:). The second patch removes a pointless statement (setting a local variable right before a return statement) from json_det

Re: [PHP-DEV][RFC] Enable authorizer-feature in PDO_SQLITE

2006-12-13 Thread Wez Furlong
Hi Mario, Sorry that I didn't get back to you--I often get too busy to follow up on PHP related mail so you need to poke. I'm currently doing some work on PDO and so I'll look at integrating your patch this week; if I don't spot any problems, I'll commit it, otherwise I'll get back to you to dis

RE: [PHP-DEV] mail() logging for PHP

2006-12-13 Thread Mike Robinson
Ilia Alshanetsky writes: > Is there any interest in adding support for logging of mail() > calls and/or adding options that allow identification of who > sent the e-mail. > > I've wrote a quick patch that enables this functionality via > two ini settings controllable via php.ini or per-virtual

[PHP-DEV] Re: CVS Account Request: saltybeagle

2006-12-13 Thread Gregory Beaver
Brett Bieber wrote: > PEAR package... http://pear.php.net/pepr/pepr-proposal-show.php?id=461 verified, this is to maintain the newly accepted Services_W3C_HTMLValidator. Brett should be given karma for pear/Services_W3C_HTMLValidator Thanks, Greg -- PHP Internals - PHP Runtime Development Mai