At 11:10 22/09/2006, Derick Rethans wrote:
On Thu, 21 Sep 2006, Michael Wallner wrote:
> [ ] (+1) please remove that redundant strictness again
> [X] (-1) leave as it is, we need strict OO implementation
> [ ] ( 0) what the hell are you talking about?
It's not necessarily a *strict* OO implemen
In this case, wouldn't E_NOTICE make more sense? E_STRICT kind of indicates
that certain behaviour is deprecated, right?
- Ron
"Zeev Suraski" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> At 11:10 22/09/2006, Derick Rethans wrote:
> >On Thu, 21 Sep 2006, Michael Wallner wrote:
>
Here is a patch for
// $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $
//
// Net_URL Class
Misspelled variable in function Net_URL::setProtocol()
418c418
< $this->port = is_null($port) ?
$this->getStandardPort($protocal) : $port;
---
> $this->port = is_null($port)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hey Alexei,
Thanks you for your patch! I committed it.
For future reference however, these patches should go into
the bug system[1] and there is a dedicated PEAR development
related list[2].
Best,
Jan
- --
[1] http://pear.php.net/bugs/search.php?cmd
Please send this to an PEAR list or report a bug at pear.php.net,
internals is the wrong place for this.
And as a related note: diff -u is way better readable and preferred.
johannes
Alexei wrote:
Here is a patch for
// $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $
//
// Net_URL Class
Thanks Jan
Sorry guys, description of how to submit patches was a bit confusing on
pear website.
Alexei
Jan Lehnardt wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hey Alexei,
Thanks you for your patch! I committed it.
For future reference however, these patches should go into
the bu
