Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Andi Gutmans
As we are not planning to release a new version within the next couple of weeks, I suggest before jumping to conclusions we take a look at it. If you really need to comment out that line in the meanwhile that's OK with me. Andi At 09:50 PM 5/31/2006, Steph Fox wrote: Yes, it would, given the r

RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Dmitry Stogov
I agree. I'll try to make it work from inside zend_shudown() but probably it will requre modification of EVERY extension that uses module_globals in any case. Thanks. Dmitry. > -Original Message- > From: Steph Fox [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 01, 2006 8:48 AM > To: Dm

RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Dmitry Stogov
Hi Stepth, I reproduced crash of php-gtk on linix with php-zts. I mean running "php -v" then php.ini contains "extension=gtk2.so". The crash occurs only then php compiled with --enable-debug. The reason of the crash is a bug in ZE that is activated by memory leaks in php-gtk. In case of "php -v"

RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Dmitry Stogov
Patch was cutted. Dmitry. > -Original Message- > From: Dmitry Stogov [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 01, 2006 3:05 PM > To: 'Andi Gutmans'; 'Steph Fox'; 'Frank M. Kromann' > Cc: 'internals'; 'Antony Dovgal'; 'Xuefer' > Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI S

[PHP-DEV] CVS Account Request: giggen

2006-06-01 Thread mr.pakorn.su-th
i interest create my PHP project. and ... -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] CVS Account Request: nrf

2006-06-01 Thread Nathan Fredrickson
To assist Lukas Smith maintaining the PEAR MDB2 package. In particular, Lukas has asked me to maintain the MDB2_pgsql and MDB2_mssql drivers. Thank you. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: CVS Account Request: nrf

2006-06-01 Thread Lukas Smith
Nathan Fredrickson wrote: To assist Lukas Smith maintaining the PEAR MDB2 package. In particular, Lukas has asked me to maintain the MDB2_pgsql and MDB2_mssql drivers. Thank you. Yes he needs CVS karma for pear/MDB2 And he also needs developer rights for the MDB2_Driver_pgsql and MDB2_Driv

[PHP-DEV] Re: CVS Account Request: nrf

2006-06-01 Thread Pierre
On Thu, 1 Jun 2006 07:31:29 -0700 [EMAIL PROTECTED] ("Nathan Fredrickson") wrote: > To assist Lukas Smith maintaining the PEAR MDB2 package. In > particular, Lukas has asked me to maintain the MDB2_pgsql and > MDB2_mssql drivers. Thank you. You already have an account. -- Pierre -- PHP Inter

[PHP-DEV] Question regarding extension function entries.

2006-06-01 Thread Matt Sicker
According to all documentation I've found, a zend_function_entry[] array should be ended with { NULL, NULL, NULL }, but I've noticed that _zend_function_entry now has five parts; differences: -unsigned char *func_arg_types; +struct _zend_arg_info *arg_info; +zend_uint num_args; +zend_uint flags;

[PHP-DEV] Re: Question regarding extension function entries.

2006-06-01 Thread Sara Golemon
According to all documentation I've found, a zend_function_entry[] array should be ended with { NULL, NULL, NULL }, but I've noticed that _zend_function_entry now has five parts; Your analysis is correct, however(functionally speaking) the only attribute that NEEDs to be explicitly set NULL is f

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
We were hoping to release ours... - Original Message - From: "Andi Gutmans" <[EMAIL PROTECTED]> To: "Steph Fox" <[EMAIL PROTECTED]>; "Frank M. Kromann" <[EMAIL PROTECTED]> Cc: "'internals'" ; "'Antony Dovgal'" <[EMAIL PROTECTED]>; "Dmitry Stogov" <[EMAIL PROTECTED]>; "'Xuefer'" <[EMAI

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
Wrong crash. Mine doesn't happen in debug mode. - Original Message - From: "Dmitry Stogov" <[EMAIL PROTECTED]> To: "'Andi Gutmans'" <[EMAIL PROTECTED]>; "'Steph Fox'" <[EMAIL PROTECTED]>; "'Frank M. Kromann'" <[EMAIL PROTECTED]> Cc: "'internals'" ; "'Antony Dovgal'" <[EMAIL PROTECTED]

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
I already wasted several hours on that :) I agree that making it work from inside zend_shutdown would be the smart approach, but don't see why you think it will need any extension mods (although it might need minor TSRM mods to flag 'done' table entries in all cases). The sane thing would be t

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
ts_free_id() would be a correct workaround if it came from zend_shutdown(). How's it right to suddenly force EVERY extension author to add it to their code individually? This was only reqiured in extensions registering custom dtor's like tidy and printer. Unfortunately that's not true. It's

[PHP-DEV] Re: CVS Account Request: nrf

2006-06-01 Thread Pierre
On Thu, 1 Jun 2006 15:49:46 +0200 [EMAIL PROTECTED] (Pierre) wrote: > On Thu, 1 Jun 2006 07:31:29 -0700 > [EMAIL PROTECTED] ("Nathan Fredrickson") wrote: > > > To assist Lukas Smith maintaining the PEAR MDB2 package. In > > particular, Lukas has asked me to maintain the MDB2_pgsql and > > MDB2_m

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
Silencing the shutdown memory manager doesn't help 'my' bug, although it probably fixes yours :) You'd need to be on win32 to see the crash that was introduced by forcing the DL_UNLOAD call for win32 unless you want to 'fake it' by adding ZTS to that 'if' list in the module_destructor. T

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Richard Lynch
On Thu, June 1, 2006 12:21 am, Frank M. Kromann wrote: >> Fine, but breaking working code while you're trying to understand >> what's > >> happening is far from beneficial to our users. Can't we at least #0 >> it? > > There is no need to break code. The shutdown function was commented > out > for a

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
Hi Dmitry, Have some diagnostics: 1) zend_shutdown() is called before anything in TSRM. It invokes zend_hash_graceful_reverse_destroy(&module_registry); 2) module_destructor() is invoked via the hash-destroyer (being part of the module_registry hash constructor). This performs the MSHUTDOWN

RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Dmitry Stogov
I am working in this way, but this willnot help you with php-gtk for php-5.1 Dmitry. > -Original Message- > From: Steph Fox [mailto:[EMAIL PROTECTED] > Sent: Thursday, June 01, 2006 9:19 PM > To: Dmitry Stogov; 'Xuefer'; 'Andi Gutmans' > Cc: 'internals'; 'Antony Dovgal' > Subject: Re: [P

Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI

2006-06-01 Thread Steph Fox
Did you see my patch? - Original Message - From: "Dmitry Stogov" <[EMAIL PROTECTED]> To: "'Steph Fox'" <[EMAIL PROTECTED]>; "'Xuefer'" <[EMAIL PROTECTED]>; "'Andi Gutmans'" <[EMAIL PROTECTED]> Cc: "'internals'" ; "'Antony Dovgal'" <[EMAIL PROTECTED]> Sent: Friday, June 02, 2006 8:11 A

[PHP-DEV] [PATCH] the most bizarre thing...

2006-06-01 Thread Steph Fox
Dmitry, have you _any_ idea why this might fix my CG table-freeing crash? It still gets past the != check, so presumably it still does the same destroy-and-free - but it works now?! - Steph Index: Zend/zend.c === RCS file: /repo