Re: [PHP-DEV] cvs: php-src / NEWS /ext/pcre php_pcre.c php_pcre.h /main SAPI.c /win32 sendmail.c

2005-03-19 Thread Andrey Hristov
Hi Andrei, I think it is hard to distinguisn between a NULL (I don't want this function to count) and NULL (well, my variable is not initialized but this is the PHP way of coding). Do you have an idea? Andrey Andrei Zmievski wrote: I guess it's fine. I would make sure, though, that you can pass N

[PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Jani Taskinen
Compile fails now with ext/pgsql after your commits: /usr/src/php5/ext/pgsql/pgsql.c: In function `zm_startup_pgsql': /usr/src/php5/ext/pgsql/pgsql.c:494: error: `PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:494: error: (Each undeclared ide

[PHP-DEV] Serialization question

2005-03-19 Thread l0t3k
a quick question about the new serialization callbacks. is it necessary only to serialize the state specific to the given object, or do we also have to explicitly serialize the properties hash ? Assuming my classes are set up as below, will the serialization mechanism take care of subclasses for

Re: [PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Christopher Kings-Lynne
Sorry, just woke up... Compile fails now with ext/pgsql after your commits: /usr/src/php5/ext/pgsql/pgsql.c: In function `zm_startup_pgsql': /usr/src/php5/ext/pgsql/pgsql.c:494: error: `PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:494: erro

Re: [PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Jani Taskinen
On Sun, 20 Mar 2005, Christopher Kings-Lynne wrote: /usr/src/php5/ext/pgsql/pgsql.c:3488: error: `PG_DIAG_INTERNAL_POSITION' undeclared (first use in this function) /usr/src/php5/ext/pgsql/pgsql.c:3488: error: `PG_DIAG_INTERNAL_QUERY' Is that all the failure messages? I cannot understand why 2 o

Re: [PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Christopher Kings-Lynne
No. Here's the whole section from it: #define PG_DIAG_SEVERITY'S' #define PG_DIAG_SQLSTATE'C' #define PG_DIAG_MESSAGE_PRIMARY 'M' #define PG_DIAG_MESSAGE_DETAIL 'D' #define PG_DIAG_MESSAGE_HINT'H' #define PG_DI

Re: [PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Christopher Kings-Lynne
OK, fixed. Please test it. I'll be out for an hour or two... Christopher Kings-Lynne wrote: No. Here's the whole section from it: #define PG_DIAG_SEVERITY'S' #define PG_DIAG_SQLSTATE'C' #define PG_DIAG_MESSAGE_PRIMARY 'M' #define PG_DIAG_

Re: [PHP-DEV] ext/pgsql build broken

2005-03-19 Thread Jani Taskinen
Yeah, compiles now. I fixed a small error in your fix though. :) --Jani On Sun, 20 Mar 2005, Christopher Kings-Lynne wrote: OK, fixed. Please test it. I'll be out for an hour or two... Christopher Kings-Lynne wrote: No. Here's the whole section from it: #define PG_DIAG_SEVERITY