Re: [PHP-DEV] [PATCH] fixes #26194

2003-11-22 Thread Moriyoshi Koizumi
On 2003/11/22, at 14:08, Frank M. Kromann wrote: Take a look at iconv.h line 80 #define iconv libiconv This line is the problem I'll change the php_iconv.h file to include. You must be right. Seems I overlooked that stuff totally though I recognised the evil #define is there. I'll commit a patch

[PHP-DEV] [PATCH] com_handlers.c

2003-11-22 Thread Sebastian Bergmann
The attached patch fixes a couple of warnings in php5/ext/com_dotnet/com_handlers.c by synchronizing with a recent change in the zend_object_handlers structure. -- Sebastian Bergmann http://sebastian-bergmann.de/ http://phpOpenTracker.de/ Das Buch zu PHP 5: http://professi

RE: [PHP-DEV] [PATCH] fixes #26194

2003-11-22 Thread Steph
erm, I did ... but that line wasn't the thing that broke this. (ZEND_FENTRY was.) > -Original Message- > From: Frank M. Kromann [mailto:[EMAIL PROTECTED] > Sent: 22 November 2003 05:09 > To: Moriyoshi Koizumi > Cc: Steph; internals; Derick Rethans > Subject: Re: [PHP-DEV] [PATCH] fixes

[PHP-DEV] older snaps / get_object_vars

2003-11-22 Thread John Huntjens
Hello group, Did something really stupid today: deleted my snap from nov 12 while downloading todays snap. Todays snap has a really stupid bug in it: $this->dom = new domDocument(); $t = get_object_vars($this); print_r($this); get_object_vars seems destroying references to other objects. So:

Re: [PHP-DEV] SimpleXML XPath Namespace Support

2003-11-22 Thread Rob Richards
From: Adam Maccabee Trachtenberg > http://www.trachtenberg.com/patches/simplexml_xpath_ns_patch.txt > > Can someone with SimpleXML karma please review and apply. See Bug > #26159 for more information. The question I have is in simplexml_ce_register_ns. As nsmap has no specific scope, shouldnt all

Re: [PHP-DEV] Re: ZTS issues

2003-11-22 Thread Rob Richards
From: Michael Sisolak > That explination makes a lot of sense. I'm +1 on having a ZTS/non-ZTS > common free for BG(url_adapt_state_ex).tags in basic_globals_dtor(). Here's the updated patch for that stuff http://www.ctindustries.net/patches/zts-php5-20031120.diff.txt Also fixes an issue last pat

Re: [PHP-DEV] older snaps / get_object_vars

2003-11-22 Thread Magnus Määttä
Hi John On Saturday 22 November 2003 14.49, John Huntjens wrote: > Hello group, > > Did something really stupid today: deleted my snap from nov 12 while > downloading todays snap. > > Todays snap has a really stupid bug in it: > > $this->dom = new domDocument(); > $t = get_object_vars($this); > p

Re: [PHP-DEV] SimpleXML XPath Namespace Support

2003-11-22 Thread Adam Maccabee Trachtenberg
On Sat, 22 Nov 2003, Rob Richards wrote: > The question I have is in simplexml_ce_register_ns. As nsmap has no specific > scope, shouldnt all the entries be registered in the xpath context, which > would then need to happen in simplexml_ce_xpath_search? That's why I create a new xmlXPathNewContex

Re: [PHP-DEV] Using do_alloca() instead of emalloc()

2003-11-22 Thread Marcus Boerger
Hello Andi, Thursday, November 20, 2003, 10:48:57 AM, you wrote: > Hey, > I've been taking a look at the __autoload problem. During that time I saw > that lots of places in the code (especially reflection API) use > zend_str_tolower_dup(). > In most of these cases it would be much more efficie

Re: [PHP-DEV] SimpleXML XPath Namespace Support

2003-11-22 Thread Rob Richards
From: Adam Maccabee Trachtenberg > That's why I create a new xmlXPathNewContext inside simplexml_ce_register_ns. > > + if (!sxe->xpath) { > + sxe->xpath = xmlXPathNewContext((xmlDocPtr) sxe->document->ptr); > + } But xpath isn't shared across the objects, so calling simplexml_ce_register_n

[PHP-DEV] Goodbye

2003-11-22 Thread Jason Greene
Everyone, As you have noticed, I have not been active for quite a long time now. Though I have tried on and off again, I just no longer have the time. Please remove my cvs account and php.net email address. I may, in the future, have time to work on a small patch, but I can always just email

[PHP-DEV] [PATCH] Streams "file://" bug

2003-11-22 Thread Cristiano Duarte
Hi all, The current implementation of file:// support under main/streams/strems.c has a little bug. Maybe it's my gcc 3.2.2 compiler... I don't know... Anyway, the attached patch fixes it. Best Regards, Cristiano Duarte ? php-src/ZendEngine1 Index: php-src/main/streams/streams.c ===

[PHP-DEV] Re: [PATCH] Streams "file://" bug

2003-11-22 Thread Sara Golemon
> The current implementation of file:// support under > main/streams/strems.c has a little bug. > Maybe it's my gcc 3.2.2 compiler... I don't know... > Anyway, the attached patch fixes it. > Predecremet vs. postdecrement would make no difference in that context. It's very likely your compiler. Wh