Re: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread Nuno Lopes
Off the shelf garbage collectors such as BDW would be inappropriate because we use some weird kinds of "pointers" (such as object handles) stored in weird kinds of ways (such as a zend_hash object). I think it would be pretty inefficient, since those implementations just scan the stack, registers

Re: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread David Wang
> currently you only have one statement in each of those functions.. > anyway it's not critical to have static inline functions. I will need to have them (multiple statements) for the cycle collection code, and I don't think there are many situations involving changing the way reference counting i

Re: Re: [PHP-DEV] Patch for macros for tracking refcount and is_ref

2007-09-04 Thread Nuno Lopes
About the patch, the zval_*_p() functions don't really need to exist.. they can be macros as well. As I said, if those were macros, it would be very difficult to squeeze more than one statement into them. Having multiple statements in Z_DELREF_P will also break that code. It seems to me inline