Re: Re: [PHP-DEV] Fixing string offsets of strings.

2011-12-17 Thread Alan Knowles
I think I got what you where after - not to clear on the $s['offset'] should result in empty or 'o' This is the latest relivant patch https://bugs.php.net/patch-display.php?bug_id=60362&patch=fix_disabling_bad_string_offsets&revision=latest In that patch $s['offset'] would return an empty str

Re: Re: Re: [PHP-DEV] Fixing string offsets of strings.

2011-12-06 Thread Alan Knowles
I need to check b) will work with dereferencing and isset - but yes, I think it will probably be the best way to go for now. the NOTICE is probably just a missing 'E_' so it should be E_NOTICE - I had a typo there at one point. Regards Alan --- On 07/Dec/2011, Daniel Convissor wrote: > Hi Al

Re: Re: [PHP-DEV] Fixing string offsets of strings.

2011-12-06 Thread Daniel Convissor
Hi Alan: > b) fix isset, and return first character > ISSET: return false (no warning) > READ: warning + return first character (similar to current behavior > except dereferenced strings) > > c) fix isset, and return empty strings > ISSET: return false (no warning) > READ: warning + return empty

Re: Re: [PHP-DEV] Fixing string offsets of strings.

2011-12-05 Thread Alan Knowles
> Thanks so much for the patch. Looking at the source I noticed some > small things (care to build a bike shed with me? :). > > Many of the test EXPECT's have %d changed to hard coded line numbers and > others have %s changed to hard coded file names. In some of them, > that's all that changed