Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-11 Thread Gustavo Lopes
Em 2012-10-10 15:52, Tjerk Meesters escreveu: Sent from my iPhone On 10 Oct, 2012, at 6:39 PM, Nicolai Scheer wrote: Hi again! Thanks for your help an comments on the issue. cataphract commented on the stream_get_line behaviour (returning false when used on an empty file) on the bug rep

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-10 Thread Tjerk Meesters
Sent from my iPhone On 10 Oct, 2012, at 6:39 PM, Nicolai Scheer wrote: > Hi again! > > Thanks for your help an comments on the issue. > > cataphract commented on the stream_get_line behaviour (returning false > when used on an empty file) on the bug report page. > I do agree that reading on

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-10 Thread Nicolai Scheer
Hi again! Thanks for your help an comments on the issue. cataphract commented on the stream_get_line behaviour (returning false when used on an empty file) on the bug report page. I do agree that reading on an empty file can be considered an error thus returning false, because there's nothing to

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-09 Thread Sherif Ramadan
On Tue, Oct 9, 2012 at 5:10 AM, Tjerk Anne Meesters wrote: > Hi, > > I've managed to pinpoint the issue inside the code itself and attached a > patch for 5.4.4 (I can make one for trunk as well, but at the time of > writing I worked with what I had). > > The bug manifests itself when delimiter siz

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-09 Thread Tjerk Anne Meesters
Hi, I've managed to pinpoint the issue inside the code itself and attached a patch for 5.4.4 (I can make one for trunk as well, but at the time of writing I worked with what I had). The bug manifests itself when delimiter size > 1 AND the file pointer falls in between a delimiter after filling th

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-09 Thread Sherif Ramadan
On Tue, Oct 9, 2012 at 12:59 AM, Tjerk Anne Meesters wrote: > On Tue, Oct 9, 2012 at 12:14 AM, Nicolai Scheer wrote: > >> Hi! >> >> We switched from php 5.3.10 to 5.3.17 this weekend and stumbled upon a >> behaviour of stream_get_line that is most likely a bug and breaks a >> lot of our file proce

Re: [PHP-DEV] stream_get_line behaviour Bug #63240

2012-10-08 Thread Tjerk Anne Meesters
On Tue, Oct 9, 2012 at 12:14 AM, Nicolai Scheer wrote: > Hi! > > We switched from php 5.3.10 to 5.3.17 this weekend and stumbled upon a > behaviour of stream_get_line that is most likely a bug and breaks a > lot of our file processing code. > > The issue seems to have been introduced from 5.3.10 t