Re: [PHP-DEV] sendmail check

2003-10-11 Thread Sascha Schumann
Ilia, please ensure that the patch is either backed out from or completely brought up to production quality for the PHP_4_3 tree, so that the old php.ini-dist recommendation works again. ; For Unix only. You may supply arguments as well (default: "sendmail -t -i"). Th

Re: [PHP-DEV] sendmail check

2003-10-10 Thread Ilia Alshanetsky
I'll revise the patch to allow for older configurations to work. I find it somewhat strange that you do not see a problem with allowing a function not intended for command execution to act as such. For the record not only safe_mode is affected, people who rely on disable_functions INI directive

Re: [PHP-DEV] sendmail check

2003-10-10 Thread Sascha Schumann
I don't buy the security line you are trying to tuck onto your non-silent termination patch. If you are concerned about safe mode, fine, enable the patch for safe mode only. Having a warning in the case that the shell execution failed (it returns a non-zero error code, right?)