Re: [PHP-DEV] pdo_dblib pull requests

2016-02-10 Thread Adam Baratz
> > I think the best way would be to try and provide tests (part of the PR) > and test environment for this change. > > If the latter can't be provided, maybe instructions how to create one (as > you guys probably have far more experience then us). I'll certainly provide tests. Maybe this vagrant

Re: [PHP-DEV] pdo_dblib pull requests

2016-02-06 Thread Lior Kaplan
Hi Adam, First, thanks for contributing. I think the best way would be to try and provide tests (part of the PR) and test environment for this change. If the latter can't be provided, maybe instructions how to create one (as you guys probably have far more experience then us). Kaplan ___