Re: [PHP-DEV] parsing break and continue statements

2011-08-03 Thread Jan Dolecek
I guess to get a clear error message, because this is a BC change. Many people would wonder why working scripts are causing parse errors after upgrade of php. Makes sense to have error messages as clear as possible ;) Jan Dolecek juzna...@gmail.com 2011/7/29 Kiyoto Tamura : > Hi Johannes, > > T

Re: [PHP-DEV] parsing break and continue statements

2011-07-28 Thread Kiyoto Tamura
Hi Johannes, Thanks for your reply :) What I meant was that why does the parser still accept any expression after T_BREAK/CONTINUE and defer the error check to zend_do_brk_cont? Isn't it clearer to only accept if the expression following T_BREAK/CONTINUE is a positive integer (if there is any expr

Re: [PHP-DEV] parsing break and continue statements

2011-07-28 Thread Johannes Schlüter
On Thu, 2011-07-28 at 16:10 -0700, Kiyoto Tamura wrote: > Hi, > > I am new to the PHP internals, and I was just looking through the code > related to parsing break/continue statements. It looks that as of PHP > 5.4, Zend/zend_language_parser.y accepts both "T_BREAK expr" and > "T_CONTINUE expr" an