Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Andi Gutmans
Just make sure that zval's which are isolated with convert_to_string_ex() are only used as read-only. At 09:41 PM 3/18/2005 +0300, Alexander Valyalkin wrote: I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt which imporves performance of implode() function in PHP4, but nobo

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Moriyoshi Koizumi
On 2005/03/19, at 6:14, Derick Rethans wrote: On Sat, 19 Mar 2005, Moriyoshi Koizumi wrote: We already have an optimisation in the 5.x branches. I think it is appliable to the 4.3 branch. 4.3 is only for bugfixes! It didn't mean that the fix should be in the 4.3. What was it that excited you so mu

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Derick Rethans
On Sat, 19 Mar 2005, Moriyoshi Koizumi wrote: > $arrays = array(array(), array(), array()); > var_dump(implode('', $arrays)); > var_dump($arrays); > ?> > > We already have an optimisation in the 5.x branches. > I think it is appliable to the 4.3 branch. 4.3 is only for bugfixes! Derick -- De

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Moriyoshi Koizumi
On 2005/03/19, at 3:41, Alexander Valyalkin wrote: I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt which imporves performance of implode() function in PHP4, but nobody doesn't commit it yet. Can anybody explain the reason? Because convert_to_string_ex() modifies the conte