Re: [PHP-DEV] few questions about op_array

2015-10-23 Thread Lin Yo-An
Hi Hui, On Fri, Oct 23, 2015 at 8:27 PM, Xinchen Hui wrote: > Hey Lin: > > On Fri, Oct 23, 2015 at 3:31 PM, Lin Yo-An > wrote: > >> Hi Dmitry, >> >> >> I changed and tested it, and it looks like it gains some improvements. >> how do you compare the benchmark result? is there a tool doing it? >>

Re: [PHP-DEV] few questions about op_array

2015-10-23 Thread Xinchen Hui
Hey Lin: On Fri, Oct 23, 2015 at 3:31 PM, Lin Yo-An wrote: > Hi Dmitry, > > > I changed and tested it, and it looks like it gains some improvements. how > do you compare the benchmark result? is there a tool doing it? > > I currently do: > > ./sapi/cli/php Zend/bench.php > > The result: > > http

Re: [PHP-DEV] few questions about op_array

2015-10-23 Thread Lin Yo-An
Hi Dmitry, I changed and tested it, and it looks like it gains some improvements. how do you compare the benchmark result? is there a tool doing it? I currently do: ./sapi/cli/php Zend/bench.php The result: https://gist.github.com/4bbc33b7b5dcedc6bd66 On Fri, Oct 23, 2015 at 12:39 AM, Dmit

Re: [PHP-DEV] few questions about op_array

2015-10-22 Thread Dmitry Stogov
On Oct 22, 2015 3:45 PM, "Lin Yo-An" wrote: > > Hi all, > > > I am looking into zend op_array structure, and few questions raised in my mind: > > 1. Why op_array->refcount uses *uint32 instead of uint32, is there a reason? if we can replace it with uint32, then we might save one emalloc call for m