Re: [PHP-DEV] ext/mbstring dependencies

2010-12-06 Thread Dmitry Stogov
On 12/06/2010 08:38 PM, Moriyoshi Koizumi wrote: Hi, The patch almost looks good to me, but we should be more careful about introducing a set of hook points into the API. I think it'd be great if the multipart parser portion was rewritten so that it would only call the Zend multibyte API's desp

Re: [PHP-DEV] ext/mbstring dependencies

2010-12-06 Thread Moriyoshi Koizumi
Hi, The patch almost looks good to me, but we should be more careful about introducing a set of hook points into the API. I think it'd be great if the multipart parser portion was rewritten so that it would only call the Zend multibyte API's despite a slight performance drawback. Regards, Moriyo

Re: [PHP-DEV] ext/mbstring dependencies

2010-12-06 Thread Dmitry Stogov
Thanks. Already removed it. Dmitry. On 12/06/2010 01:21 PM, Hannes Magnússon wrote: On Mon, Dec 6, 2010 at 09:31, Dmitry Stogov wrote: Hi, The proposed patch completely removes ext/mbstring compile-time dependencies. As result the same php binaries may be used for Asian and European language

Re: [PHP-DEV] ext/mbstring dependencies

2010-12-06 Thread Hannes Magnússon
On Mon, Dec 6, 2010 at 09:31, Dmitry Stogov wrote: > Hi, > > The proposed patch completely removes ext/mbstring compile-time > dependencies. As result the same php binaries may be used for Asian and > European languages without performance degradation. ext/mbstring now may be > compiled as a DSO.