Re: [PHP-DEV] dl() shutdown bug fix

2005-03-06 Thread Zeev Suraski
The patch looks good. The only thing I'd add is getting rid of the code that became redundant, for clarity (the switch() is not needed in module_registry_cleanup(), and the switch() in module_registry_unload_temp() can be an if()). Did you intend to also commit it to the 5.0 branch or only 5.

Re: [PHP-DEV] dl() shutdown bug fix

2005-03-06 Thread Matthew Charles Kavanagh
Jacques Marneweck wrote: I think the mailling lists strip attachments? Attaching a file to this message to test the theory. For the list of people who've put work into PHP, please see http://www.php.net/credits.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: htt

Re: [PHP-DEV] dl() shutdown bug fix

2005-03-06 Thread Jacques Marneweck
Wez Furlong wrote: Hi Wez, The diff is not attached. I think the mailling lists strip attachments? Regards --jm It is/was attached to the mail I sent out; maybe gmail isn't so smart with text attachments. I've attached it to this mail, so you should get it this time. --Wez. On Sun, 06 Mar 2005 08:

Re: [PHP-DEV] dl() shutdown bug fix

2005-03-06 Thread Wez Furlong
It is/was attached to the mail I sent out; maybe gmail isn't so smart with text attachments. I've attached it to this mail, so you should get it this time. --Wez. On Sun, 06 Mar 2005 08:41:53 +0200, Zeev Suraski <[EMAIL PROTECTED]> wrote: > At 08:18 06/03/2005, Wez Furlong wrote: > >Any objecti

Re: [PHP-DEV] dl() shutdown bug fix

2005-03-05 Thread Zeev Suraski
At 08:18 06/03/2005, Wez Furlong wrote: Any objections to me applying this fix for the unload-module-before-calling-object-dtors bug that I periodically whine about? Is the diff available anywhere? Zeev -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.ne