Hi!
For fixing the TLA / Zone Type 2 bugs, focus on the following tests:
bug55253.phpt
rfc-datetime_and_daylight_saving_time-type2.phpt
Those are exactly the two xfails fixed by my patch.
DateTime_*-type2-type2.phpt
These aren't fixed but it may be related to the f
On Mon, 21 Nov 2011, Stas Malyshev wrote:
> > That is incorrect, not every timezone DST change is 60 minutes.
>
> The I would guess this code in do_adjust_timezone() also wrong:
>
> case TIMELIB_ZONETYPE_ABBR: {
> timelib_sll tmp;
>
> tz
Hi!
That is incorrect, not every timezone DST change is 60 minutes.
The I would guess this code in do_adjust_timezone() also wrong:
case TIMELIB_ZONETYPE_ABBR: {
timelib_sll tmp;
tz->is_localtime = 1;
tmp
On Sun, 20 Nov 2011, Stas Malyshev wrote:
> We're in RC now, and I'm very concerned about the status of DateTime
> functionality (see bugs 60236, 60237 and XFAILs) - I've reported these
> problems in June, but not much happened since then. I'm trying to
> figure out what's going on there, but I
On Sun, 20 Nov 2011, Stas Malyshev wrote:
> If it is the former, the patch seems to be pretty simple:
>
> --- lib/unixtime2tm.c (revision 319533)
> +++ lib/unixtime2tm.c (working copy)
> @@ -146,7 +146,7 @@
> int z = tm->z;
> signed int dst = tm->dst;
>
Hi Stas:
> We're in RC now, and I'm very concerned about the status of DateTime
> functionality (see bugs 60236, 60237 and XFAILs)
60237 is a duplicate of https://bugs.php.net/bug.php?id=55253. I just
marked it as such. I suspect the remaining two bugs are related to the
same underlying problem
