Re: [PHP-DEV] bug 54547

2012-06-27 Thread Oishi Kazuo
> So that next time this code changes any breakage is obvious. Next time? I had reported breakage for PHP 5.4.4 RC, but it "wont fix" and PHP 5.4.4 was released. https://bugs.php.net/bug.php?id=62097 I think the breakage exists in current version (PHP 5.4.4). > Any test you create for PHP 5.4

Re: [PHP-DEV] bug 54547

2012-06-27 Thread Christopher Jones
On 06/26/2012 09:06 PM, OISHI Kazuo wrote: Does this need an architecture specific SKIPIF? See the mention of PHP_INT_SIZE on http://qa.php.net/write-test.php Like this? === --SKIPIF-- ==

Re: [PHP-DEV] bug 54547

2012-06-26 Thread OISHI Kazuo
> Does this need an architecture specific SKIPIF? See the mention of > PHP_INT_SIZE on http://qa.php.net/write-test.php Like this? === --SKIPIF-- === I'm afraid I may miss yo

Re: [PHP-DEV] bug 54547

2012-06-26 Thread Christopher Jones
On 06/22/2012 12:08 AM, OISHI Kazuo wrote: Hi, In addition to == operator, >, <, >=, and <= operators are influenced. And, hexdecimal format for big number is now case-sensitive. http://www.mail-archive.com/internals@lists.php.net/msg58789.html Can you add some phpt tests for all the cas

Re: [PHP-DEV] bug 54547

2012-06-22 Thread OISHI Kazuo
Hi, >> In addition to == operator, >, <, >=, and <= operators are influenced. >> >> And, hexdecimal format for big number is now case-sensitive. >> >> http://www.mail-archive.com/internals@lists.php.net/msg58789.html > > Can you add some phpt tests for all the cases you've raised? This is the php

Re: [PHP-DEV] bug 54547

2012-06-21 Thread Christopher Jones
On 06/14/2012 10:42 PM, OISHI Kazuo wrote: I know this was discussed a number of times here, but just to bring it to a conclusion - I intend to apply patch in the bug report - which removes conversion for strings that do not convert to integers - to 5.4. If anybody sees anything that breaks bec

Re: [PHP-DEV] bug 54547

2012-06-14 Thread OISHI Kazuo
>> I know this was discussed a number of times here, but just to bring it >> to a conclusion - I intend to apply patch in the bug report - which >> removes conversion for strings that do not convert to integers - to 5.4. >> If anybody sees anything that breaks because of this please tell. > > "1234

Re: [PHP-DEV] bug 54547

2012-06-14 Thread Tjerk Anne Meesters
On Fri, Jun 15, 2012 at 8:56 AM, Hartmut Holzgraefe wrote: > Too late to raise this now anyway, but ... > > On 13.05.2012 04:39, Stas Malyshev wrote: >> I know this was discussed a number of times here, but just to bring it >> to a conclusion - I intend to apply patch in the bug report - which >>

Re: [PHP-DEV] bug 54547

2012-06-14 Thread Hartmut Holzgraefe
Too late to raise this now anyway, but ... On 13.05.2012 04:39, Stas Malyshev wrote: > I know this was discussed a number of times here, but just to bring it > to a conclusion - I intend to apply patch in the bug report - which > removes conversion for strings that do not convert to integers - to

Re: [PHP-DEV] bug 54547

2012-05-13 Thread Stas Malyshev
Hi! > So the float comparison behavior under ~B (what's in the patch) may seem > more desirable because it preserves the numerical comparison when possible > (and we don't have to add leading whitespace and zeros to the mix, > strcmp("9, "11") returns 1). Until you realize it's alternating b

Re: [PHP-DEV] bug 54547

2012-05-13 Thread Gustavo Lopes
On Sun, 13 May 2012 04:39:33 +0200, Stas Malyshev wrote: I know this was discussed a number of times here, but just to bring it to a conclusion - I intend to apply patch in the bug report - which removes conversion for strings that do not convert to integers - to 5.4. If anybody sees anything