Re: [PHP-DEV] Yet another fix for max_input_vars

2012-01-06 Thread Nikita Popov
On Fri, Jan 6, 2012 at 8:42 AM, Laruence wrote: > Hi: >    so here is the problem, the number index collision can be fixed by > this idea (increase table size with a random delta). > >    now we need add the random number into DJB hash, and I am not good at math, > >    so Calling for help,  and t

Re: [PHP-DEV] Yet another fix for max_input_vars

2012-01-05 Thread Laruence
Hi: so here is the problem, the number index collision can be fixed by this idea (increase table size with a random delta). now we need add the random number into DJB hash, and I am not good at math, so Calling for help, and the random number will be stored in a process global variab

Re: [PHP-DEV] Yet another fix for max_input_vars

2012-01-05 Thread Laruence
Hi, thanks to sesser, he point out that this won't work for string keys, so, I guess, we should change the hash logic in the mean time.. I will keep trying. thanks On Thu, Jan 5, 2012 at 9:12 PM, Etienne Kneuss wrote: > Hi, > > On Thu, Jan 5, 2012 at 13:05, Nikita Popov wrote: >> On Thu, Jan

Re: [PHP-DEV] Yet another fix for max_input_vars

2012-01-05 Thread Etienne Kneuss
Hi, On Thu, Jan 5, 2012 at 13:05, Nikita Popov wrote: > On Thu, Jan 5, 2012 at 9:53 AM, Laruence wrote: >> Hi: >>    the origin thread is too long, so I open a new thread for this. >> >>    I have made another patch try to fix this issue. >> >>    the key point is, randomizing the table size(tab

Re: [PHP-DEV] Yet another fix for max_input_vars

2012-01-05 Thread Nikita Popov
On Thu, Jan 5, 2012 at 9:53 AM, Laruence wrote: > Hi: >    the origin thread is too long, so I open a new thread for this. > >    I have made another patch try to fix this issue. > >    the key point is, randomizing the table size(tableMask). > >    instead of double the the table size in zend_has