Re: [PHP-DEV] writing .phpt tests against IS_INDIRECT values

2016-04-20 Thread Nikita Popov
On Wed, Apr 20, 2016 at 5:08 PM, Adam Baratz wrote: > I'm contributing to an extension -- > https://github.com/jbboehr/php-mustache > -- and part of that has been little fixes for PHP7. I posted a PR to fix > how it was handling zvals that came in as IS_INDIRECT. The maintainer asked > if I could

Re: [PHP-DEV] Writing PHPT tests

2008-02-03 Thread zoe
Rob Nicholson wrote: Hi Zoe, I notice also that the testcase generator and the testcases we have been committing differ slightly from the conventions listed at: http://qa.php.net/write-test.php . This was based on feedback we received so I think that http://qa.php.net/write-test.php should b

Re: [PHP-DEV] Writing PHPT tests

2008-02-03 Thread zoe
Jani Taskinen wrote: You simply ignored my email or never got it? The correct place for such scripts is not in the "root" but in scripts/dev/ --Jani Jani - of course I wouldn't ignore a mail from you :-) - I didn't see it. I talked a bit to Johannes on IRC about where to put it and in the en

Re: [PHP-DEV] Writing PHPT tests

2008-02-02 Thread Jani Taskinen
You simply ignored my email or never got it? The correct place for such scripts is not in the "root" but in scripts/dev/ --Jani zoe kirjoitti: Hi - for any of you that are writing PHPT tests for existing extensions - I put a PHP script called generate_phpt.php into PHP 5.3 yesterday which mi

Re: [PHP-DEV] Writing PHPT tests

2008-02-02 Thread Rob Nicholson
Hi Zoe, I notice also that the testcase generator and the testcases we have been committing differ slightly from the conventions listed at: http://qa.php.net/write-test.php . This was based on feedback we received so I think that http://qa.php.net/write-test.php should be updated. Specifically