Re: [PHP-DEV] Volnitsky substring search algo

2011-03-03 Thread Leonid Volnitsky
Damien Tournoud damz.org> writes: > > On Sun, Feb 27, 2011 at 12:50 PM, Jordi Boggiano seld.be> wrote: > The algorithm seems flawed to me, at least in its reference implementation. > There does not seem to be any guarantee that the returned position is really > the *first* occurrence of the ne

Re: [PHP-DEV] Volnitsky substring search algo

2011-03-02 Thread Damien Tournoud
On Sun, Feb 27, 2011 at 12:50 PM, Jordi Boggiano wrote: > http://volnitsky.com/project/str_search/ The algorithm seems flawed to me, at least in its reference implementation. There does not seem to be any guarantee that the returned position is really the *first* occurrence of the needle in the

Re: [PHP-DEV] Volnitsky substring search algo

2011-03-02 Thread Ángel González
Stas Malyshev wrote: > Hi! > >> http://volnitsky.com/project/str_search/ > > I'm not sure it'd be easy to integrate this into PHP codebase as-is, > provided it relies on C++ standard libraries which PHP makes no use of > (and thus potentially introduces a world of dependencies and > complexities in

Re: [PHP-DEV] Volnitsky substring search algo

2011-02-28 Thread Pierre Joye
On Mon, Feb 28, 2011 at 10:35 AM, Jordi Boggiano wrote: > On 28.02.2011 10:15, Pierre Joye wrote: >>>  I don't see why it can't be >>> integrated. >> >> We should wait for a new license before even looking at it. > > Then please ask him directly on behalf of PHP. He told me it was no > problem, bu

Re: [PHP-DEV] Volnitsky substring search algo

2011-02-28 Thread Jordi Boggiano
On 28.02.2011 10:15, Pierre Joye wrote: >> I don't see why it can't be >> integrated. > > We should wait for a new license before even looking at it. Then please ask him directly on behalf of PHP. He told me it was no problem, but I didn't think it was really my place to ask. As for looking at

Re: [PHP-DEV] Volnitsky substring search algo

2011-02-28 Thread Pierre Joye
hi! On Mon, Feb 28, 2011 at 1:25 AM, Stas Malyshev wrote: > I don't see why it can't be > integrated. We should wait for a new license before even looking at it. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Maili

Re: [PHP-DEV] Volnitsky substring search algo

2011-02-27 Thread Stas Malyshev
Hi! http://volnitsky.com/project/str_search/ I'm not sure it'd be easy to integrate this into PHP codebase as-is, provided it relies on C++ standard libraries which PHP makes no use of (and thus potentially introduces a world of dependencies and complexities into the build process). I'm sur