It will make "attribute" a reserved keyword, which caused more BC break
comparing to Attribute class.
Regards,
CHU Zhaowei
-Original Message-
From: Aleksander Machniak
Sent: Sunday, May 3, 2020 1:38 AM
To: internals@lists.php.net
Subject: Re: [PHP-DEV] Renaming PhpAt
On 02.05.2020 18:02, Benas IML wrote:
> From my standpoint, I don't really believe we can remove it. As without it,
> any class would be considered as an attribute - even one that isn't
> supposed to be.
I don't remember if it was considered, but... why not define attributes
with "class attribute
> Davey Shafik wrote:
>
>> I believe that using the PHP namespace is the right way to go, and look
>> forward to seeing code like this in the future:
>>
>> > namespace Dshafik;
>>
>> use PHP\Attribute;
>>
>> <>
>> class Foo { }
> Chase Peeler wrote:
>
>> I don't think PhpAttribute is a bad n
Hello,
You should ask Benjamin this question as he is the Attributes RFC author.
>From my standpoint, I don't really believe we can remove it. As without it,
any class would be considered as an attribute - even one that isn't
supposed to be.
Best regards,
Ben.
On Sat, May 2, 2020 at 5:57 PM Niklas Keller wrote:
> Hey Benas,
>
> a question has come up whether we even need the PhpAttribute /
> Attribute attribute at all. We could prevent any conflict if we just
> delete it.
>
> Best,
> Niklas
>
We need Attribute so static analysis tooling and IDEs can c
Hey Benas,
a question has come up whether we even need the PhpAttribute /
Attribute attribute at all. We could prevent any conflict if we just
delete it.
Best,
Niklas
Am Di., 28. Apr. 2020 um 17:37 Uhr schrieb Benas IML
:
>
> Hey internals,
>
> Since it's safe to say that the Attributes v2 RFC h
On 2 May 2020 08:23:14 BST, Davey Shafik wrote:
>IMO, the onus of proof should be on those wishing to introduce a change
>that has a potential conflict, not those trying to prevent one.
While I totally understand the principle here, it does lead to two questions:
1) What evidence would you acce
On Wed, Apr 29, 2020 at 08:24 Benas IML wrote:
> Hello,
>
> > Again, your assumption that just about everyone uses namespaced classes
> > doesn't take into account closed source projects. I don't care if it's a
> major
> > release or not - BC breaks should always be avoided without a major
> bene
Hello,
> Again, your assumption that just about everyone uses namespaced classes
> doesn't take into account closed source projects. I don't care if it's a
major
> release or not - BC breaks should always be avoided without a major
benefit
With an introduction of any new language construct, funct
On 29/04/2020 15:41, Chase Peeler wrote:
I don't think PhpAttribute is a bad name [...] nor is it logically inconsistent
with other Php* named classes.
One of the things I dislike about "PhpAttribute" is that it's still
really generic - I know I'm writing PHP, so it feels like broken
Hungar
On Wed, Apr 29, 2020 at 9:35 AM Benas IML wrote:
> Hello,
>
>
I honestly don't care what it's called, but I am seeing some arguments
being used in favor of changing it that I think are invalid.
> Since your project is just a single example, we still can't make such a
> bold
> claim that `\Attri
On 29/04/2020 13:50, Côme Chilliet wrote:
Le mardi 28 avril 2020, 18:59:22 CEST Benas IML a écrit :
Could you provide any examples as to where '\Attribute' is being used in the
wild? I haven't seen a single project that has an Attribute class and uses the
global namespace.
We do use an Attribut
On Wed, 29 Apr 2020, Nikita Popov wrote:
> On Wed, Apr 29, 2020 at 3:24 PM Côme Chilliet <
> come.chill...@fusiondirectory.org> wrote:
>
> > Le mercredi 29 avril 2020, 14:58:02 CEST Nikita Popov a écrit :
> > > On Wed, Apr 29, 2020 at 2:51 PM Côme Chilliet <
> > > come.chill...@fusiondirectory.or
On Wed, Apr 29, 2020 at 3:24 PM Côme Chilliet <
come.chill...@fusiondirectory.org> wrote:
> Le mercredi 29 avril 2020, 14:58:02 CEST Nikita Popov a écrit :
> > On Wed, Apr 29, 2020 at 2:51 PM Côme Chilliet <
> > come.chill...@fusiondirectory.org> wrote:
> > > Le mardi 28 avril 2020, 18:59:22 CEST
Hello,
Since your project is just a single example, we still can't make such a bold
claim that `\Attribute` is used a lot.
While "attribute" is a fairly generic word, just about everyone uses
namespaced
classes and therefore it's not a huge problem. Moreover, PHP 8 is a major
release so BC in suc
Le mercredi 29 avril 2020, 14:58:02 CEST Nikita Popov a écrit :
> On Wed, Apr 29, 2020 at 2:51 PM Côme Chilliet <
> come.chill...@fusiondirectory.org> wrote:
> > Le mardi 28 avril 2020, 18:59:22 CEST Benas IML a écrit :
> > > Could you provide any examples as to where '\Attribute' is being used in
On Wed, Apr 29, 2020 at 2:51 PM Côme Chilliet <
come.chill...@fusiondirectory.org> wrote:
> Le mardi 28 avril 2020, 18:59:22 CEST Benas IML a écrit :
> > Could you provide any examples as to where '\Attribute' is being used in
> the
> > wild? I haven't seen a single project that has an Attribute c
Le mardi 28 avril 2020, 18:59:22 CEST Benas IML a écrit :
> Could you provide any examples as to where '\Attribute' is being used in the
> wild? I haven't seen a single project that has an Attribute class and uses the
> global namespace.
We do use an Attribute class in FusionDirectory:
https://gi
Hey Benas,
I've also tried to get that change into the original RFC, but wasn't able to.
I'm in favor of an amendment RFC to change the name to Attribute.
Best,
Niklas
Am Di., 28. Apr. 2020 um 17:37 Uhr schrieb Benas IML
:
>
> Hey internals,
>
> Since it's safe to say that the Attributes v2 RFC
Hello,
> Speaking on the other note, is there any problem on my side but it doesn't
> seem that I am able to register for a PHP wiki account [1]. I keep getting an
> error message "That wasn't the answer we were expecting".
This is no longer a problem, I successfully registered my wiki account.
Hey,
> Like many other things in life, just because you don't see something doesn't
> mean that it is certainly not there ;-)
I do understand your point and I do agree that there may be some minimal
collision but stating that `Attribute` is too generic and will needlessly
collide with code in the
On Tue, Apr 28, 2020 at 6:21 PM Aaron Piotrowski wrote:
>
> > On Apr 28, 2020, at 10:37 AM, Benas IML
> wrote:
> >
> > Hey internals,
> >
> > Since it's safe to say that the Attributes v2 RFC has passed, I wanted to
> > make a separate thread based on the comment by Rowan Tommins in the PHP
> >
> On Apr 28, 2020, at 10:37 AM, Benas IML wrote:
>
> Hey internals,
>
> Since it's safe to say that the Attributes v2 RFC has passed, I wanted to
> make a separate thread based on the comment by Rowan Tommins in the PHP
> namespace policy thread. This is a quote from his comment:
>
>> One pre
Hey Benas,
On Tue, Apr 28, 2020 at 5:59 PM Benas IML wrote:
> > `Attribute` is certainly too generic, and will needlessly collide with
> code
> > in the wild.
>
> Could you provide any examples as to where '\Attribute' is being used in
> the
> wild? I haven't seen a single project that has an A
On Tue, 28 Apr 2020 at 16:43, Marco Pivetta wrote:
> `Attribute` is certainly too generic, and will needlessly collide with code
> in the wild.
>
I wonder how true that is, precisely because it *is* so generic, so people
will likely have used it with a prefix or in their own namespace. It might
Hello,
> `Attribute` is certainly too generic, and will needlessly collide with code
> in the wild.
Could you provide any examples as to where '\Attribute' is being used in the
wild? I haven't seen a single project that has an Attribute class and uses the
global namespace.
> I suggest circling b
Heya,
On Tue, Apr 28, 2020 at 5:37 PM Benas IML wrote:
> Hey internals,
>
> Since it's safe to say that the Attributes v2 RFC has passed, I wanted to
> make a separate thread based on the comment by Rowan Tommins in the PHP
> namespace policy thread. This is a quote from his comment:
>
> > One
27 matches
Mail list logo
