On Fri, Aug 23, 2019 at 3:33 AM Nikita Popov wrote:
> Any objections to dropping this and have a single php-src karma for the
> whole tree (with the exception of php_version.h, which is used to prevent
> bad merges)?
>
> No objections from me. This divide dates back to /long/ before the RFC
proc
Hi!
> Any objections to dropping this and have a single php-src karma for the
> whole tree (with the exception of php_version.h, which is used to prevent
> bad merges)?
Makes sense to merge Zend karma into php-src karma (I imagine smaller
karma sets, e.g. for tests or specific ext only, remain?).
On Fri, Aug 23, 2019 at 11:25 AM Zeev Suraski wrote:
>
> On 23 Aug 2019, at 10:56, Zeev Suraski wrote:
>
>
>
> On 23 Aug 2019, at 10:33, Nikita Popov wrote:
>
>
> Hi internals,
>
>
> We currently have separate karma for the Zend/TSRM directories in php-src.
>
> I think this separation has becom
On 23 Aug 2019, at 10:56, Zeev Suraski mailto:z...@zend.com>>
wrote:
On 23 Aug 2019, at 10:33, Nikita Popov
mailto:nikita@gmail.com>> wrote:
Hi internals,
We currently have separate karma for the Zend/TSRM directories in php-src.
I think this separation has become more annoying than use
> On 23 Aug 2019, at 10:33, Nikita Popov wrote:
>
> Hi internals,
>
> We currently have separate karma for the Zend/TSRM directories in php-src.
> I think this separation has become more annoying than useful at this point.
> Most changes from newer contributors are approved on GitHub first, a
+1
Cheers
Joe
On Fri, 23 Aug 2019 at 10:33, Nikita Popov wrote:
> Hi internals,
>
> We currently have separate karma for the Zend/TSRM directories in php-src.
> I think this separation has become more annoying than useful at this point.
> Most changes from newer contributors are approved on Git
