On Thu, Aug 29, 2013 at 5:59 PM, Levi Morrison wrote:
> On Thu, Aug 29, 2013 at 5:00 AM, Nikita Popov wrote:
>
>> On Fri, Aug 2, 2013 at 6:47 PM, Julien Pauli wrote:
>>
>> > Hi internals.
>> >
>> > I started a work of refactoring magic methods from internals.
>> >
>> > The first goal was to never
On Thu, Aug 29, 2013 at 5:00 AM, Nikita Popov wrote:
> On Fri, Aug 2, 2013 at 6:47 PM, Julien Pauli wrote:
>
> > Hi internals.
> >
> > I started a work of refactoring magic methods from internals.
> >
> > The first goal was to never write ourselves things like "__get", but use
> > macros for tho
On Fri, Aug 2, 2013 at 6:47 PM, Julien Pauli wrote:
> Hi internals.
>
> I started a work of refactoring magic methods from internals.
>
> The first goal was to never write ourselves things like "__get", but use
> macros for those names. (get, set, invoke, etc...).
>
> A second goal was to rewrite
On Fri, Aug 2, 2013 at 9:55 PM, Levi Morrison wrote:
> If you have ideas or things to say, I'm listening.
>> https://github.com/jpauli/php-src/compare/macroing
>
>
> Is there a reason you switched from names like `__toString` to
> `__tostring` (https://github.com/jpauli/php-src/compare/macroing#L2
>
> If you have ideas or things to say, I'm listening.
> https://github.com/jpauli/php-src/compare/macroing
Is there a reason you switched from names like `__toString` to `__tostring`
(https://github.com/jpauli/php-src/compare/macroing#L2R12)?
Visually the macros clean things up a lot and better
