Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-13 Thread Jan Schneider
Zitat von Wez Furlong <[EMAIL PROTECTED]>: On Thu, 12 Aug 2004 16:16:51 -0400, Jon Parise <[EMAIL PROTECTED]> wrote: And what if Jan doesn't know C or feel comfortable writing PHP extension code, for example? Even more reason to stop complaining and wait for someone with the appropriate skill to ge

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Wez Furlong
On Thu, 12 Aug 2004 16:16:51 -0400, Jon Parise <[EMAIL PROTECTED]> wrote: > And what if Jan doesn't know C or feel comfortable writing PHP > extension code, for example? Even more reason to stop complaining and wait for someone with the appropriate skill to get home from work and give the problem

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Jon Parise
On Thu, Aug 12, 2004 at 07:59:39PM +0100, Wez Furlong wrote: > > > Quit complaining and fix the patch properly then. > > Be nice. > > Jan doesn't have php-src commit privileges, so he can't fix it > > himself. > > The wonder of OpenSource allows Jan to write the patch on his > machine and post it

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Andi Gutmans
Thanks! At 03:50 PM 8/12/2004 -0400, Ilia Alshanetsky wrote: On August 12, 2004 03:47 pm, Andi Gutmans wrote: > OK guys. I'd like to roll so please check this problem and give me an ack > if it's OK. Should be ok now. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visi

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Ilia Alshanetsky
On August 12, 2004 03:47 pm, Andi Gutmans wrote: > OK guys. I'd like to roll so please check this problem and give me an ack > if it's OK. Should be ok now. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Chuck Hagenbuch
Quoting Andi Gutmans <[EMAIL PROTECTED]>: OK guys. I'd like to roll so please check this problem and give me an ack if it's OK. I believe with Ilia's correction it should be fine now. -chuck -- "Regard my poor demoralized mule!" - Juan Valdez -- PHP Internals - PHP Runtime Development Mailing List

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Andi Gutmans
OK guys. I'd like to roll so please check this problem and give me an ack if it's OK. At 02:38 PM 8/12/2004 -0400, Ilia Alshanetsky wrote: Chuck already applied a patch that should resolve the problem that Jan had reported. Ilia On August 12, 2004 02:21 pm, Andi Gutmans wrote: > At 05:55 PM 8/12/

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Wez Furlong
On Thu, 12 Aug 2004 14:28:44 -0400, Jon Parise <[EMAIL PROTECTED]> wrote: > On Thu, Aug 12, 2004 at 05:38:33PM +0100, Wez Furlong wrote: > > Quit complaining and fix the patch properly then. > Be nice. > Jan doesn't have php-src commit privileges, so he can't fix it > himself. The wonder of OpenSo

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Chuck Hagenbuch
Quoting Jon Parise <[EMAIL PROTECTED]>: The patch, as committed, breaks backwards compatibility in a point release. The proper "fix" is to revert it unless someone has a version that actually works. I committed a change that should avoid the range check if the FT_UID flag is set. If someone could

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Ilia Alshanetsky
Chuck already applied a patch that should resolve the problem that Jan had reported. Ilia On August 12, 2004 02:21 pm, Andi Gutmans wrote: > At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote: > >Zitat von Jan Schneider <[EMAIL PROTECTED]>: > >>Ilia Alshanetsky wrote: > >>>iliaa Wed Jul

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Jon Parise
On Thu, Aug 12, 2004 at 05:38:33PM +0100, Wez Furlong wrote: > Quit complaining and fix the patch properly then. Be nice. The patch, as committed, breaks backwards compatibility in a point release. The proper "fix" is to revert it unless someone has a version that actually works. Jan doesn't h

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Andi Gutmans
At 05:55 PM 8/12/2004 +0200, Jan Schneider wrote: Zitat von Jan Schneider <[EMAIL PROTECTED]>: Ilia Alshanetsky wrote: iliaa Wed Jul 21 17:57:03 2004 EDT Modified files: /php-src/ext/imapphp_imap.c Log: Fixed bug #29209 (imap_fetchbody() doesn't check message in

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Wez Furlong
Quit complaining and fix the patch properly then. --Wez. On Thu, 12 Aug 2004 17:55:33 +0200, Jan Schneider <[EMAIL PROTECTED]> wrote: > Zitat von Jan Schneider <[EMAIL PROTECTED]>: > > > Ilia Alshanetsky wrote: > >> iliaaWed Jul 21 17:57:03 2004 EDT > >> > >> Modified files:

Re: [PHP-DEV] Re: cvs: php-src /ext/imap php_imap.c

2004-08-12 Thread Jan Schneider
Zitat von Jan Schneider <[EMAIL PROTECTED]>: Ilia Alshanetsky wrote: iliaa Wed Jul 21 17:57:03 2004 EDT Modified files: /php-src/ext/imap php_imap.c Log: Fixed bug #29209 (imap_fetchbody() doesn't check message index). # Initial Patch by tony2001 at phpclub dot