Hi!
> Should we use size_t/ptrdiff_t everywhere applicable?
We should use it everywhere where we deal with zend_string and such -
i.e. where the size_t parameter is expected. If it's related to outside
library - we should use its type and check (e.g. ICU uses int32_t). For
internal things, I gue
Hi all,
On Wed, Jan 21, 2015 at 8:22 AM, Rasmus Lerdorf wrote:
> On 01/20/2015 02:46 PM, Stanislav Malyshev wrote:
> > Hi!
> >
> >> So, I guess the lesson is that we need to be careful when we migrate
> >> extensions to PHP 7. Passing ints instead of size_t string length params
> >> to zpp can c
On 01/20/2015 02:46 PM, Stanislav Malyshev wrote:
> Hi!
>
>> So, I guess the lesson is that we need to be careful when we migrate
>> extensions to PHP 7. Passing ints instead of size_t string length params
>> to zpp can cause extreme weirdness and we should go through all our
>> bundled extensions
Hi!
> So, I guess the lesson is that we need to be careful when we migrate
> extensions to PHP 7. Passing ints instead of size_t string length params
> to zpp can cause extreme weirdness and we should go through all our
> bundled extensions and make sure things that are still using "s" have
> all
On Tue, 2015-01-20 at 14:13 -0800, Rasmus Lerdorf wrote:
> So, I guess the lesson is that we need to be careful when we migrate
> extensions to PHP 7. Passing ints instead of size_t string length params
> to zpp can cause extreme weirdness and we should go through all our
> bundled extensions and m
