Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Xinchen Hui
Hey: On Thu, Jan 15, 2015 at 7:52 AM, Pierre Joye wrote: > On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev > wrote: >> Hi! >> >>> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing >>> >>> in benchmark this can brings more than 30% performance gain in >>> arra

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Pierre Joye
On Wed, Jan 14, 2015 at 9:09 PM, Stanislav Malyshev wrote: > Hi! > >> I made a PR here: https://github.com/php/php-src/pull/999 for reviewing >> >> in benchmark this can brings more than 30% performance gain in >> array_sort etc functions. >> >> tests fails are related to non-stable vs

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-14 Thread Stanislav Malyshev
Hi! > I made a PR here: https://github.com/php/php-src/pull/999 for reviewing > > in benchmark this can brings more than 30% performance gain in > array_sort etc functions. > > tests fails are related to non-stable vs stable sorting difference. > > anyway, I feel it's better to

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Sanford Whiteman
Sounds more like a bugfix to me and def'ly an acceptable BC break in either case. The behavior isn't specified and if anything I would assume there _wouldn't_ be a swap with SORT_FLAG_CASE on. Interesting though that many sorting examples (across languages) sidestep this clearly common case. -- S.

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Xinchen Hui
Hey: > On Jan 6, 2015, at 1:27 AM, Julien Pauli wrote: > >> On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui wrote: >> On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui wrote: >> > Hey: >> > >> > I was working on zend_qsort improvement. but I got a problem need >> > to be disscussed with you fist..

Re: [PHP-DEV] Re: Faster zend sorting implementation

2015-01-05 Thread Julien Pauli
On Mon, Jan 5, 2015 at 6:09 PM, Xinchen Hui wrote: > On Tue, Jan 6, 2015 at 1:08 AM, Xinchen Hui wrote: > > Hey: > > > > I was working on zend_qsort improvement. but I got a problem need > > to be disscussed with you fist.. > first > > > > as we know, previously zend_qsort is not a st