On Wed, Feb 2, 2022, at 9:14 PM, tyson andre wrote:
> Hi Larry Garfield,
>
>> >> Returning $this would resolve that, I think. (Making it return a new,
>> >> immutable copy of the Deque would be even nicer, but I realize that's
>> >> probably not an argument I'm going to win at this point on this
Hi Larry Garfield,
> >> Returning $this would resolve that, I think. (Making it return a new,
> >> immutable copy of the Deque would be even nicer, but I realize that's
> >> probably not an argument I'm going to win at this point on this RFC.)
> >
> > Technically, you still can have single-expr
Hi Jordan,
> > 4. Returning $this makes code easier to write at some cost to readability
> > - Developers new to php or using `Collections\Deque` for the first time
> > would not immediately know what the code they're reading is doing.
> > (less of a problem with a good IDE, typechecker, and
On Wed, Feb 2, 2022 at 6:59 AM tyson andre
wrote:
>
> 4. Returning $this makes code easier to write at some cost to readability
> - Developers new to php or using `Collections\Deque` for the first time
> would not immediately know what the code they're reading is doing.
>(less of a problem w
On Wed, Feb 2, 2022, at 8:59 AM, tyson andre wrote:
> Hi Larry Garfield,
>> Returning $this would resolve that, I think. (Making it return a new,
>> immutable copy of the Deque would be even nicer, but I realize that's
>> probably not an argument I'm going to win at this point on this RFC.)
>
>
Hi Larry Garfield,
> Request:
>
> push() and unshift() currently return void. That's not helpful. It would be
> vastly more useful if they both returned $this. Not as much for chaining,
> but more so that you can add a value to a queue and pass it as an argument to
> another call (often recu
On Tue, Feb 1, 2022, at 8:46 AM, tyson andre wrote:
> I plan to start voting on https://wiki.php.net/rfc/deque on Friday,
> February 4th.
>
> Several changes have been made to https://wiki.php.net/rfc/deque#changelog
> after the feedback in https://externals.io/message/116100
>
> - The class is
